[edk2-devel] [PATCH] RedfishClientPkg: fix uninitialized variable build error

[edk2-devel] [PATCH] RedfishClientPkg: fix uninitialized variable build error

[Mike Maslenkin]

Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
index c0c3ec476f19..f2373b080c70 100644
--- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
+++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
@@ -146,6 +146,7 @@ StartUpFeatureDriver (
   }
 
   ThisList = ThisFeatureDriverList;
+  Status   = EFI_SUCCESS;
   while (TRUE) {
     if (ThisList->Callback != NULL) {
       ThisList->InformationExchange = mInformationExchange;
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113161): https://edk2.groups.io/g/devel/message/113161
Mute This Topic: https://groups.io/mt/103520603/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishClientPkg: fix uninitialized variable build error

[Nickle Wang via groups.io]

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]


Reviewed-by: Nickle Wang <nicklew@nvidia.com<mailto:nicklew@nvidia.com>>



Regards,

Nickle

________________________________
From: Mike Maslenkin <mike.maslenkin@gmail.com>
Sent: Thursday, January 4, 2024 7:56 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>; Abner Chang <abner.chang@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
Subject: [PATCH] RedfishClientPkg: fix uninitialized variable build error

External email: Use caution opening links or attachments


Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
index c0c3ec476f19..f2373b080c70 100644
--- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
+++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
@@ -146,6 +146,7 @@ StartUpFeatureDriver (
   }



   ThisList = ThisFeatureDriverList;

+  Status   = EFI_SUCCESS;

   while (TRUE) {

     if (ThisList->Callback != NULL) {

       ThisList->InformationExchange = mInformationExchange;

--
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113162): https://edk2.groups.io/g/devel/message/113162
Mute This Topic: https://groups.io/mt/103520603/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3931 bytes --]