From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0FB9B74003B for ; Fri, 5 Jan 2024 11:49:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0lBFM1QnctbpKPNg5tCcg5wSm2HLLMHSSldO1WIyzts=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704455392; v=1; b=eKvjkxXEwQAzKFhSM4zYV48AVfkkVeh55CbFLaE8x5Viu7FKbCP4jPCCfiF5zkZ0XBQDuicI NJ82ShZ3baqmF+7ikzuVuQZ6dHntmV0Gvk6RlVJI+d/YvYZEdg2jv0skpN0uqF61A0R7AlXZ5wN cAu8tN4RLDPCBqMTKrtKO8Ao= X-Received: by 127.0.0.2 with SMTP id VQCnYY7687511xLdcfT48UqZ; Fri, 05 Jan 2024 03:49:52 -0800 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.85]) by mx.groups.io with SMTP id smtpd.web11.21783.1704455391461712096 for ; Fri, 05 Jan 2024 03:49:52 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JOp2zjMSAvXG4b+XlM5xMYF8PsSk20x9DVSWdLM/Z/F/XjpypfIh8lM5dCqqreEAQkb9YRJ+nFL1iKXgxh1g2N7eySycYk67pMQsp43Z78rrZUAZyIxzXAmOMR7upJlOh3Yp+HJlfRbEI8ethyWH/wWmJjfflNDUvqDRM9bVY1aCRJBfReCWO3t9/m8f0UJcN/9cFttdNWhuzN06UXdeFs2RG77B9/ImWSeahyFp1Q59FOAOAy88celWdsXTy6H36xVsPDDV16hXIqqXaAYM8sQswdIsfYYqdVQTG2ndg6hHuokGkW5qH1eXRh72fCt11+K/HSMqCCr1XnbphxBQgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9gML6QLlrE4EJFr0nOo0PBfFrGMCUFr+MaJuN+5Lu+Q=; b=f9w1eIUs38VyjjcFaVBmFafH2GEjNjmd+3zSojuZeksHFoKlh3fhVDldT6ZXVhEks9ODetRxQUVgmHk+U47KKP226RfFDYkf2Y9uAzsBuZKFWonkOxm4TsK+4DG4DdOfPOf45yaTDRvcOP6g4hFe2mpOrwAv9x8XC0Outj6Lldtp8/sAW7p/lRuOU2RYLJHDg44FCkofnQxpfVhPQbCviMRURi7vkUbQRgikXHrIYUFxDtFJg4u0PSkPF5mdxNtij6pqDMz8K+YLNPLoWCyB0LOyffVEPwDfXVDowKJZhQWVp7YAV8JqjOvjqOJgq4UmDb33tXpikOAG3CfJ53pGrg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AS9PR06CA0001.eurprd06.prod.outlook.com (2603:10a6:20b:462::31) by AS2PR08MB10373.eurprd08.prod.outlook.com (2603:10a6:20b:546::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 11:49:45 +0000 X-Received: from AMS1EPF0000004A.eurprd04.prod.outlook.com (2603:10a6:20b:462:cafe::12) by AS9PR06CA0001.outlook.office365.com (2603:10a6:20b:462::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16 via Frontend Transport; Fri, 5 Jan 2024 11:49:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS1EPF0000004A.mail.protection.outlook.com (10.167.16.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Fri, 5 Jan 2024 11:49:45 +0000 X-Received: ("Tessian outbound 52fd419df13e:v239"); Fri, 05 Jan 2024 11:49:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 17efdddc2bd7e864 X-CR-MTA-TID: 64aa7808 X-Received: from 5f3ce3f49c99.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5396C05-091C-402D-8B72-BF15F4C6A494.1; Fri, 05 Jan 2024 11:49:37 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5f3ce3f49c99.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 Jan 2024 11:49:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAalGlmyhA4DAMwJNK+8FG2/RAUMjzbfL4Jnfefr3oGRO1O2auegA3IzXkTPx8wts10Rc+LL0aGKTv9yp1lPwYqinlNqGnz+6X8uJiRh/b7v+EXfGWh7BoFmr39v2iNhZNsz090VOM709mr+M2UmpVMgXZPU2T8bUheokwUlRxfa/Fo32b8yqs757HGJBkzfCdLyvyAg0anCzpiBP8Gwwf9soyN1ALgBCtlZXvYcD+vTq4TSn5fzJvXANIqSpK14XR5P766go3vhBFEIQBENu3f1tX4IJ5GfnakbxXwzEFa2rQCyD5Ij2Byi4fx+5u+lSBxK1OumiRtMFR6AW5+D0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9gML6QLlrE4EJFr0nOo0PBfFrGMCUFr+MaJuN+5Lu+Q=; b=dPRiYN1XI1WbYFDxSt5NjfFsJ3Lv3CHsg4tjVxiqdb4jeUJPYk5Mb7boEObvLviggZ74ILV0g4xzqChz/fUW7qweVJsSwQ61Eq2IwabO2HwE50w5zpJiH+xqGfTsT0+tI76XoBhVh9WQHlMi7XI4OMvrdBQB29S9jCxgaE9e5OJw1b/y6esB+wj9Eku4ogH9GVEXVjF1YG9QDAx8xEO/vLkc3NZbWA6SQxeIdXxNbkF+5Sk//OuT3k0VUF5n07OPq65uw2sHhXpXbkkT4ivuoG0TJK7DaW7mefBrGwsvWUR8em/iGQxf2pzcIKdJseekcIEDdp7t+TPLQdVTIh2qdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) X-Received: from AS9PR06CA0574.eurprd06.prod.outlook.com (2603:10a6:20b:486::12) by PAXPR08MB6480.eurprd08.prod.outlook.com (2603:10a6:102:155::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 11:49:36 +0000 X-Received: from AMS0EPF00000191.eurprd05.prod.outlook.com (2603:10a6:20b:486:cafe::81) by AS9PR06CA0574.outlook.office365.com (2603:10a6:20b:486::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.15 via Frontend Transport; Fri, 5 Jan 2024 11:49:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AMS0EPF00000191.mail.protection.outlook.com (10.167.16.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7159.9 via Frontend Transport; Fri, 5 Jan 2024 11:49:36 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 5 Jan 2024 11:49:35 +0000 X-Received: from e129823.cambridge.arm.com (10.1.197.6) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.32 via Frontend Transport; Fri, 5 Jan 2024 11:49:34 +0000 From: "levi.yun" To: CC: , , , , , Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint Date: Fri, 5 Jan 2024 11:49:31 +0000 Message-ID: <20240105114931.844886-1-yeoreum.yun@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AMS0EPF00000191:EE_|PAXPR08MB6480:EE_|AMS1EPF0000004A:EE_|AS2PR08MB10373:EE_ X-MS-Office365-Filtering-Correlation-Id: 8eb7804e-33e7-447a-31b7-08dc0de46982 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d5uEgZvIYVs9v1u6hGbsBzNKghkVgY6hpPYvwAv7e9B0fU2OJAjq7AslyNVvqv8seoo/HJ8+oFfLng2PYyHY/9I9b7wJ77KWsm8dX3YATpQ/8u6R7yUL2kiMI9tcG3w4muKIVzvKqE9yl0N6NUzjaVSagmSoi4CCxJTLyJ7UZGdz+YElnE7ygVr/NbZR5P5KiVmYC0UJUDahynHlp5NCPrNxu4fU53W2bapQzUaz4kA7750c30SSITYqGcvU7xpNdBrF+R1UcAypIo7aMgIDFWGzajE49GnSbWbEPxR6LHrkATdmBIL/Lse2wCDI2F7gojIYRz+VRYp/p9+N6FbrCw24j/p+5guwouo2xd+DMZfdpHEk/HvMhD0ccfBg9NpO7opVSS4aqV+SnuaEOut32utmSO3lksedAbRXQeupPe/jM65co6kqEKacAfXiPyEnlcs146BgmWif/RfYMni3Z6PUv3G5idqDBXkfG4GNXqqV+FrO2ee/dtTSIHg2dXGu14KTeXYQonm1Zzg312wVWd/JBeDzCBfLxpfUhObVPSSRWUfHAGolfwT2Rx3KP8J13RKGeWH29QSQvh8I8F9EhQXUpwyzQWI2tSFRshJ5ZfA03a/NcHny4laNkKWWqtxGPyNQToz9cC0fGe914YR7CDpHVNeFjGCoRvsq/GL1BEGJOnDWZuSp3Urnt3LwSsJ3lZn8h3fiJveAErQSZVaP/+5Z67XNtLhNh+CCLm23fh/5K8h7sURgzB1gA2fsBF4s X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(6029001)(4636009)(136003)(39860400002)(346002)(396003)(376002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(82310400011)(46966006)(40470700004)(36840700001)(2616005)(426003)(336012)(1076003)(26005)(6666004)(7696005)(86362001)(83380400001)(4326008)(316002)(8676002)(54906003)(8936002)(36756003)(2906002)(70586007)(5660300002)(478600001)(966005)(6916009)(70206006)(82740400003)(81166007)(356005)(47076005)(36860700001)(41300700001)(40460700003)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6480 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004A.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c24e969-2aab-4198-3f26-08dc0de46417 X-Microsoft-Antispam-Message-Info: AL1C/UE1e7BQ2Gj/SzXeSfoFUdbC01221PAwa6F7AH6cH6irMfQPDnN5zKVb/VrPo1tBt+/EdBku77DsH+v6nv6id6xeSXgscWTQ6ZeB2fIZljr8JUO8EGgqZChQYvzjpsObHkmKJv2laEzobQlfc9epy7yvbaNDLz5IzquNv2v2FcGV4vBApwCdNwl6R6tM0O1Ap2tVAg0PqxayyMHMTC42MBdhbyzd0kP+s7Vr8k+IUneaPiuOLKcFddVXVMftkhpHrF7Rk643m7RErMEvV33TYQ2SxaP5KU0ZrIxJH78TxrQZVWXst+secYUjHV6HcgCVJ/tQrR+aMk0U2YdlZxNY/UTw+sgF386/RCup1qEQfHjBZvz6BGSZpPMm+3QzKfkuhepzep9gKCJO3Bp4WVYunnVsiWDJ+pqvq/xi3a6eJ5bvTdMvlEkCUlte0x9mWtS2wylOdi/NtQgcOCvjRQiGsnWu5dB+5b46WW3yl0pLnT1hkjrCcS7gi/97LpG42wC64XrgFK3qquD1W9Qsky2KoSO0NboREqT8F2Lc372H/YeTD4Waqzrqr7yOPIHBQpQLrTgwHiQvISpRGnaAX33MmWeuJ0395+aAhjOivR8cbCOOcbSxAcfV4N6hYlZBsv8Nhi+zv/JsOA3cA8s3W01sB703TWUK8K7juUGNeEvq+aRewHYTE9XOrrjgfMC+/WiCmct8UT9/76CDWUBfeV1HinrZbf0GOiucC2ttnqY= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 11:49:45.3143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb7804e-33e7-447a-31b7-08dc0de46982 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10373 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: y03NQfxrH03AN4iSDmpuO2mwx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eKvjkxXE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Serial port used by the DEBUG macro is initialised in StandaloneMmMain by the DebugLib constructor. When we use a serial port initialised by TF-A it is not a problem. However, if we use a serial port that is not initialised by TF-A, the debug log prints hangs. Therefore, initialise the serial port early on in the entry point. Signed-off-by: levi.yun --- These changes can be seen at https://github.com/LeviYeoReum/edk2/tree/levi/2956_init_serial too. StandaloneMmPkg/StandaloneMmPkg.dsc = | 1 + StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPo= int.inf | 1 + StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCoreEnt= ryPoint.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/Standalo= neMmPkg.dsc index 8012f93b7dcc38ea8fdd2de98912bbc09157ec53..040a4aa5b3d268fdfaaec9a975c= fc6ff31aa37b4 100644 --- a/StandaloneMmPkg/StandaloneMmPkg.dsc +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc @@ -66,6 +66,7 @@ [LibraryClasses.AARCH64, LibraryClasses.ARM] ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMainte= nanceLib.inf PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActi= onLib/StandaloneMmPeCoffExtraActionLib.inf + SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneM= mCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/St= andaloneMmCoreEntryPoint.inf index 75cfb98c0e75cd7cee2a59723035679612da4528..086639ecfbc983627aed7381781= 5e2485104375e 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEn= tryPoint.inf @@ -42,6 +42,7 @@ [LibraryClasses] DebugLib [LibraryClasses.ARM, LibraryClasses.AARCH64] + SerialPortLib StandaloneMmMmuLib ArmSvcLib diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/Standal= oneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/= Arm/StandaloneMmCoreEntryPoint.c index 96de10405af829c66e3f43ed4692f785d8df113e..66b56bdfe4959d5ab6152ff024c= aa6e900e7a948 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCo= reEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/StandaloneMmCo= reEntryPoint.c @@ -335,6 +335,9 @@ _ModuleEntryPoint ( UINTN TeDataSize; EFI_PHYSICAL_ADDRESS ImageBase; + // Initialize the Serial Port early to print debug log before Standalone= MmMain. + SerialPortInitialize (); + // Get Secure Partition Manager Version Information Status =3D GetSpmVersion (); if (EFI_ERROR (Status)) { -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113276): https://edk2.groups.io/g/devel/message/113276 Mute This Topic: https://groups.io/mt/103540969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-