From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A77EEAC1345 for ; Sun, 7 Jan 2024 13:27:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oT+BPKyiamR4cSWqElg8D7djKCstGKPBuLc8nJeVkro=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704634063; v=1; b=RvCev3aLsjWwzQWw4Tq/JLGCxigeUDOx/IWyoyIn82a4431WsIME82IN/vgr9z2yIkLJuHqU oEllaA87+wtXxoktgkqNsz2zogFuzV98NykaUnIKtD8dGwty46pBa/QebftIFwaFmZW6Njuc3lx nCyvWWrwOcVgfrt4TJkNSbO8= X-Received: by 127.0.0.2 with SMTP id ldSTYY7687511xKk2QYS10m2; Sun, 07 Jan 2024 05:27:43 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.14875.1704634062411129769 for ; Sun, 07 Jan 2024 05:27:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jF7Mmfg6oMUggJPkwwmLGOgftEU9U8CzIm5+by7YAFq/R7Vwf6EnLBxCzkijS5KpYiYqfejQhy/AhYrmB8ygdWGD7JMEFA3gSN+y2J21AfPxpa5LHDG3feE/g6aAsTHEgCL5gDeYoUcTaAWBCusytNi0zvmvBJ6h5l9i0K58kxxEhOFqMLMFuZDnhS44pgBU+/7kSw3aL34ySRohtyZ7pt08VvFZcZ4dSzOdeG7AGwagwST70Mt5NeHxLlyjwvaq9BJRi/cwlyzaOzonlfu4DNplCEpBQQtn+Bsr+a7FmRidQJ4pns9M42AyD4V+EEh7CpDDlXxq0fQGnsCUeWO6Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pB0w99VuPUV0zuRxssAa8PMHd9VoZGl9/35puTXZfE4=; b=SYzbeCXgRQSsb/1aXVzORr4hy3kK1CxSDCqPP0WqFbOnxCWBmOopZt6ml/aaSPDEvmDKqSymdqqBQOcSzXA9RcDtQ5PfXYtHyloT+bM3d5vr67ouyETPmAfS70Sj34QmDRoOCyBpUvbq0zpPwzJM8M3sGRDbv9LXrkKDFpr8ggtrkNAdiIRMD9FyssC8N3ROHMFRzbeVZRYI1Z0AzWyOX6qAxvR9AzYWa9FiiQxoSrtMvZMZ4bZTI2MUixdLOoc39Cyn6/gYT6yxwlKttD1H15zNsDNvpI2dzhlGX2Pjjyq74LdinNXkqEbrad2th3WSs8t4No5YlXRWQFNWs3UPLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from BL0PR02CA0006.namprd02.prod.outlook.com (2603:10b6:207:3c::19) by CY5PR12MB6249.namprd12.prod.outlook.com (2603:10b6:930:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Sun, 7 Jan 2024 13:27:38 +0000 X-Received: from BL6PEPF0001AB4F.namprd04.prod.outlook.com (2603:10b6:207:3c:cafe::37) by BL0PR02CA0006.outlook.office365.com (2603:10b6:207:3c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21 via Frontend Transport; Sun, 7 Jan 2024 13:27:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB4F.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7181.13 via Frontend Transport; Sun, 7 Jan 2024 13:27:38 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 7 Jan 2024 07:27:19 -0600 From: "Chang, Abner via groups.io" To: CC: Saloni Kasbekar , Zachary Clark-williams , Michael Brown , Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH V2 2/6] NetworkPkg/HttpDxe: Consider TLS certificate not found as a success case Date: Sun, 7 Jan 2024 21:26:57 +0800 Message-ID: <20240107132701.302-3-abner.chang@amd.com> In-Reply-To: <20240107132701.302-1-abner.chang@amd.com> References: <20240107132701.302-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4F:EE_|CY5PR12MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: 18f6cd72-f173-42df-ae90-08dc0f846adb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: jZ9yqhAN1P8z+uWHVL7uxEV9IRX3m1mrtjxFCBtI0DC4vLtrF6nbPj7bpQteLkdoj3CI6vWvltM4fndVGPDGpSDx8q8IfHOdSCfThW4I6CkbhO/gU3XKJ238v0tHvE9DhnFeOJxcB3/81LxECPu2HUKOfBYeqmpKYW7/u0pxf/+cByPBz9qK9/Kn5UZYpM78pTveS5cmn1itRQQvpmiY1NeqsLFaUMuMSwUFpePN52vWDHXqiaCLxWqYpH04ZLpHS54w6Ankj+iU5GiYimlTtubSieACGt3GQRgaG7sfv4slVnHU2GEOkZPnYPzKn7W/iJ6WChaWEUmOOxlmLs0njo9aEdXbSDhokvkjp+VWWdVCNvCKtBmQP09NEUicPDMNMKvo/4te8lEPNic255vbhkdkfmRxRdwMq19Ykrwe64VpKz8dfjRI5v46G5+9J60p9/XAUsex4xw0uK2DwHUIOVciRGJ+xrS3sh2PakToZQ0y6zVmNt5qxGDRIS0skycPrt9dhY4Qn6KlEsQGeBSuBMWv0hpGpfymSWySyQAhhYBt538/2sIXW9MPpaQbF6/htJek86J/z05D0QLZC3nDytPHZBpDQKStQ1ScfcGqqTY6UIYHFRq+2EkeIUQXZLZdwgJtA3sCAMZDv2ugwYO5hJR0YbSty61lbfJ2SZoKwd9Wvo77FwCIC/4Im0kI3sYCsJ5lsuVHPHBTZhnxMXpeRxEfVYHupZuKEaPH6p30VNxKHjT2BNa87y/Ke6l166/3yHYcI7RmsRLQZtRyWtDNNQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2024 13:27:38.2336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18f6cd72-f173-42df-ae90-08dc0f846adb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6249 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UPb8bJNFqN1Uy5Ak2gBHf3iAx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RvCev3aL; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Abner Chang We still return EFI_SUCCESS to the caller when TlsConfigCertificate returns error, for the use case the platform doesn't require certificate for the specific HTTP session. This ensures HttpInitSession function still initiated and returns EFI_SUCCESS to the caller. The failure is pushed back to TLS DXE driver if the HTTP communication actually requires certificate. Signed-off-by: Abner Chang Cc: Saloni Kasbekar Cc: Zachary Clark-williams Cc: Michael Brown Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Michael Brown Reviewed-by: Saloni Kasbekar --- NetworkPkg/HttpDxe/HttpsSupport.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSu= pport.c index a07323ff0bd..04a830f7152 100644 --- a/NetworkPkg/HttpDxe/HttpsSupport.c +++ b/NetworkPkg/HttpDxe/HttpsSupport.c @@ -722,8 +722,21 @@ TlsConfigureSession ( // Status =3D TlsConfigCertificate (HttpInstance); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "TLS Certificate Config Error!\n")); - return Status; + if (Status =3D=3D EFI_NOT_FOUND) { + DEBUG((DEBUG_WARN, "TLS Certificate is not found on the system!\n"))= ; + // + // We still return EFI_SUCCESS to the caller when TlsConfigCertifica= te + // returns error, for the use case the platform doesn't require + // certificate for the specific HTTP session. This ensures + // HttpInitSession function still initiated and returns EFI_SUCCESS = to + // the caller. The failure is pushed back to TLS DXE driver if the + // HTTP communication actually requires certificate. + // + Status =3D EFI_SUCCESS; + } else { + DEBUG((DEBUG_ERROR, "TLS Certificate Config Error!\n")); + return Status; + } } =20 // --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113329): https://edk2.groups.io/g/devel/message/113329 Mute This Topic: https://groups.io/mt/103577245/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-