From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F2D5D811A6 for ; Mon, 8 Jan 2024 07:23:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zRM50V/CuIOTKfkS3YyLV32h3xEHjVj9wiPbArpVvEg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704698635; v=1; b=Cl/Ry2ruR+ztI9zORCO1E8HKpOiLbKarsKpzZOh0I2AjxWs/flojdSYbN/agGJWM0+LMnu1p Q+V5MLTY1qt7R5cdYR7eauv5emX/4fvYfOcG3ZKuJaGyqnmsDqdGIJhwhjhhdb/MnemkSMf2/mZ IfYwMsnYToSuN6iQniNOYY1U= X-Received: by 127.0.0.2 with SMTP id mLJuYY7687511xYaZxjQ56ui; Sun, 07 Jan 2024 23:23:55 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1906.1704698634279040144 for ; Sun, 07 Jan 2024 23:23:54 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="464212646" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="464212646" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 23:23:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="731027898" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="731027898" X-Received: from gchen29.sh.intel.com ([10.239.154.135]) by orsmga003.jf.intel.com with ESMTP; 07 Jan 2024 23:23:52 -0800 From: "Chen, Gang C" To: devel@edk2.groups.io Cc: gua.guo@intel.com, guo.dong@intel.com, james.lu@intel.com, sean@starlabs.systems, Gang Chen Subject: [edk2-devel] [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check Date: Mon, 8 Jan 2024 15:25:29 +0800 Message-Id: <20240108072531.3344290-2-gang.c.chen@intel.com> In-Reply-To: <20240108072531.3344290-1-gang.c.chen@intel.com> References: <20240108072531.3344290-1-gang.c.chen@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AC4Eanxro5VGwU5NtIahsQp2x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Cl/Ry2ru"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) It's too early to check the SCI enable status, which is set in the BDS phase ususally. Remove the check from UPL. Signed-off-by: Gang Chen Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes --- UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 --------------------- 1 file changed, 38 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c b/UefiPayloadPkg/U= efiPayloadEntry/AcpiTable.c index 1b9208b6d3..748728981a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c +++ b/UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c @@ -134,44 +134,6 @@ Done: ASSERT (Fadt->Pm1aEvtBlk !=3D 0);=0D ASSERT (Fadt->Gpe0Blk !=3D 0);=0D =0D - DEBUG_CODE_BEGIN ();=0D - BOOLEAN SciEnabled;=0D -=0D - //=0D - // Check the consistency of SCI enabling=0D - //=0D -=0D - //=0D - // Get SCI_EN value=0D - //=0D - if (Fadt->Pm1CntLen =3D=3D 4) {=0D - SciEnabled =3D (IoRead32 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;=0D - } else {=0D - //=0D - // if (Pm1CntLen =3D=3D 2), use 16 bit IO read;=0D - // if (Pm1CntLen !=3D 2 && Pm1CntLen !=3D 4), use 16 bit IO read as a = fallback=0D - //=0D - SciEnabled =3D (IoRead16 (Fadt->Pm1aCntBlk) & BIT0) ? TRUE : FALSE;=0D - }=0D -=0D - if (!(Fadt->Flags & EFI_ACPI_5_0_HW_REDUCED_ACPI) &&=0D - (Fadt->SmiCmd =3D=3D 0) &&=0D - !SciEnabled)=0D - {=0D - //=0D - // The ACPI enabling status is inconsistent: SCI is not enabled but AC= PI=0D - // table does not provide a means to enable it through FADT->SmiCmd=0D - //=0D - DEBUG ((=0D - DEBUG_ERROR,=0D - "ERROR: The ACPI enabling status is inconsistent: SCI is not"=0D - " enabled but the ACPI table does not provide a means to enable it t= hrough FADT->SmiCmd."=0D - " This may cause issues in OS.\n"=0D - ));=0D - }=0D -=0D - DEBUG_CODE_END ();=0D -=0D return RETURN_SUCCESS;=0D }=0D =0D --=20 2.40.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113363): https://edk2.groups.io/g/devel/message/113363 Mute This Topic: https://groups.io/mt/103593438/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-