From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9EFE67803E6 for ; Tue, 9 Jan 2024 11:29:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pXEW2ffttxFxTv4taYIvSmonpuBbMt0AKp2g941mFKI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704799750; v=1; b=Evnpil+OHqyyBxklDwLYXvHZ8vonJ9di8Z09NWf5kcZu9nSRWh4dtvgo1Kf2N2JBwl3s3I/2 L26mprDaw7ertYF8wLowsP8Rcw/taljf83q1KzT0SEKGb70gbijqbnaepEav6aRMI59LKL5qn3u Blhhy1xmmlbCFoC2KKH30Kzk= X-Received: by 127.0.0.2 with SMTP id uUIXYY7687511xfpqlDwre7P; Tue, 09 Jan 2024 03:29:10 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.14477.1704799749698613291 for ; Tue, 09 Jan 2024 03:29:09 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-47zyEsB9PMWuUPTb9BHIAQ-1; Tue, 09 Jan 2024 06:29:04 -0500 X-MC-Unique: 47zyEsB9PMWuUPTb9BHIAQ-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D4AA82DFE2; Tue, 9 Jan 2024 11:29:04 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.194.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B9DB51E3; Tue, 9 Jan 2024 11:29:04 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 0613FA7A58; Tue, 9 Jan 2024 12:29:03 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Sunil V L , Gerd Hoffmann , Jiewen Yao , oliver@redhat.com, Laszlo Ersek , Andrei Warkentin , Ard Biesheuvel Subject: [edk2-devel] [PATCH v5 1/3] OvmfPkg/RiscVVirt: use gEfiAuthenticatedVariableGuid unconditionally Date: Tue, 9 Jan 2024 12:29:00 +0100 Message-ID: <20240109112902.30002-2-kraxel@redhat.com> In-Reply-To: <20240109112902.30002-1-kraxel@redhat.com> References: <20240109112902.30002-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5wuUyBzctggBma7liMZLHHrdx7686176AA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Evnpil+O; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io ArmVirt and OVMF are doing the same. See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER generation") for details. Suggested-by: László Érsek Signed-off-by: Gerd Hoffmann Reviewed-by: Sunil V L Reviewed-by: Laszlo Ersek --- OvmfPkg/RiscVVirt/VarStore.fdf.inc | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/OvmfPkg/RiscVVirt/VarStore.fdf.inc b/OvmfPkg/RiscVVirt/VarStore.fdf.inc index aba32315cc37..6679c246b3ea 100644 --- a/OvmfPkg/RiscVVirt/VarStore.fdf.inc +++ b/OvmfPkg/RiscVVirt/VarStore.fdf.inc @@ -36,19 +36,12 @@ # Blockmap[1]: End 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, ## This is the VARIABLE_STORE_HEADER -!if $(SECURE_BOOT_ENABLE) == TRUE + # It is compatible with SECURE_BOOT_ENABLE == FALSE as well. # Signature: gEfiAuthenticatedVariableGuid = # { 0xaaf32c78, 0x947b, 0x439a, # { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 }} 0x78, 0x2c, 0xf3, 0xaa, 0x7b, 0x94, 0x9a, 0x43, 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92, -!else - # Signature: gEfiVariableGuid = - # { 0xddcf3616, 0x3275, 0x4164, - # { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d }} - 0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41, - 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d, -!endif # Size: 0x40000 (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize) - # 0x48 (size of EFI_FIRMWARE_VOLUME_HEADER) = 0x3FFB8 # This can speed up the Variable Dispatch a bit. -- 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113442): https://edk2.groups.io/g/devel/message/113442 Mute This Topic: https://groups.io/mt/103617813/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-