From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9F557AC157F for ; Tue, 9 Jan 2024 16:30:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=si+xhRRA31WVWF9FVC/AbJ/y0Vcz7y9C4QkoaGLGhvs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704817829; v=1; b=DpWb3P7BP0XjKDsmIfDRlcQfevcpFluy9xju74il6LkOpJMMqenK/vyNGo4UOeVvkZWEhZ+q ljYitcdn/Uzh4zue7vJZUMo4HN4f8a5jEhE1gbGILcc2VxLbFUtT+Iw7UrS6VXNCatjmSi/VxfD 7tr0zg1RWLYUwq5nuipmCLgQ= X-Received: by 127.0.0.2 with SMTP id BbpRYY7687511xCum4dYp8Ze; Tue, 09 Jan 2024 08:30:29 -0800 X-Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx.groups.io with SMTP id smtpd.web11.21054.1704817828899243465 for ; Tue, 09 Jan 2024 08:30:28 -0800 X-Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d3e2972f65so10767545ad.3 for ; Tue, 09 Jan 2024 08:30:28 -0800 (PST) X-Gm-Message-State: y2NBTwOzcOzHBAs1DCSw8gxsx7686176AA= X-Google-Smtp-Source: AGHT+IHrK4cufSt2uxBd5LQ53xDTJLDPQp1lHFhcq1CxqyxZG18+zMe2OngoAHxRi32MN+WoUkaizQ== X-Received: by 2002:a17:903:41d2:b0:1d4:ca35:3cd9 with SMTP id u18-20020a17090341d200b001d4ca353cd9mr3601534ple.119.1704817828045; Tue, 09 Jan 2024 08:30:28 -0800 (PST) X-Received: from localhost.localdomain ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id c12-20020a170902b68c00b001d457090851sm1983596pls.289.2024.01.09.08.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 08:30:27 -0800 (PST) From: "Sunil V L" To: devel@edk2.groups.io Cc: Sunil V L , Ard Biesheuvel , Leif Lindholm , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [RFC PATCH v1 11/20] DynamicTablesPkg: TableHelperLib: Populate OemTableId using ConfigManager Date: Tue, 9 Jan 2024 21:59:35 +0530 Message-Id: <20240109162944.528006-12-sunilvl@ventanamicro.com> In-Reply-To: <20240109162944.528006-1-sunilvl@ventanamicro.com> References: <20240109162944.528006-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DpWb3P7B; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io To support multiple CPU architectures/vendors, it is better to create OemTableId using the platform provided value instead of default ARM. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../Common/TableHelperLib/TableHelper.c | 24 ++++++++----------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index 549cee1b3fd5..219f94e0dbcc 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -161,20 +161,16 @@ AddAcpiHeader ( CopyMem (AcpiHeader->OemId, CfgMfrInfo->OemId, sizeof (AcpiHeader->OemId)); // UINT64 OemTableId - if (AcpiTableInfo->OemTableId != 0) { - AcpiHeader->OemTableId = AcpiTableInfo->OemTableId; - } else { - AcpiHeader->OemTableId = SIGNATURE_32 ( - CfgMfrInfo->OemId[0], - CfgMfrInfo->OemId[1], - CfgMfrInfo->OemId[2], - CfgMfrInfo->OemId[3] - ) | - LShiftU64 ( - (UINT64)Generator->AcpiTableSignature, - 32 - ); - } + AcpiHeader->OemTableId = SIGNATURE_32 ( + CfgMfrInfo->OemId[0], + CfgMfrInfo->OemId[1], + CfgMfrInfo->OemId[2], + CfgMfrInfo->OemId[3] + ) | + LShiftU64 ( + (UINT64)Generator->AcpiTableSignature, + 32 + ); // UINT32 OemRevision if (AcpiTableInfo->OemRevision != 0) { -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113473): https://edk2.groups.io/g/devel/message/113473 Mute This Topic: https://groups.io/mt/103622727/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-