From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 09AEF74004E for ; Tue, 9 Jan 2024 16:30:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OkocGJyfM4MrHe89KbQVRCcDMSc7WzLSXezI6ROG2X4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704817849; v=1; b=MdnuJGdcpz9n39s+Mmc2i8zJqgWlDibQxiG8bS1GXTnJLRCsB8Gn0rlgFXoVpMz2cjMZDR73 TaROh3p7HccG3CkrMNxo3UHGwkuVNfwBilb3o/yUOMqEELBziPSUKSmkF/JQokrdm34Ay14dI34 mhNKvJc96SHIEw8TiolTqKTk= X-Received: by 127.0.0.2 with SMTP id fgBDYY7687511xepGkTdgjNP; Tue, 09 Jan 2024 08:30:49 -0800 X-Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mx.groups.io with SMTP id smtpd.web10.21275.1704817849121671510 for ; Tue, 09 Jan 2024 08:30:49 -0800 X-Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d509222c11so10310955ad.1 for ; Tue, 09 Jan 2024 08:30:49 -0800 (PST) X-Gm-Message-State: fqeiSAhypqsLvolW6DuaqFEyx7686176AA= X-Google-Smtp-Source: AGHT+IFwvHRxbjyzXD9vLOqOGEctrV1w4v2/Suzaoutmai/YG2MG+gUd1056HYOibX92k7Hd7GX59A== X-Received: by 2002:a17:903:11d1:b0:1d4:e2bc:88fd with SMTP id q17-20020a17090311d100b001d4e2bc88fdmr3343789plh.1.1704817847715; Tue, 09 Jan 2024 08:30:47 -0800 (PST) X-Received: from localhost.localdomain ([106.51.188.200]) by smtp.gmail.com with ESMTPSA id c12-20020a170902b68c00b001d457090851sm1983596pls.289.2024.01.09.08.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 08:30:47 -0800 (PST) From: "Sunil V L" To: devel@edk2.groups.io Cc: Sunil V L , Ard Biesheuvel , Leif Lindholm , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [RFC PATCH v1 18/20] DynamicTablesPkg: X86: Add interfaces to succeed CI tests Date: Tue, 9 Jan 2024 21:59:42 +0530 Message-Id: <20240109162944.528006-19-sunilvl@ventanamicro.com> In-Reply-To: <20240109162944.528006-1-sunilvl@ventanamicro.com> References: <20240109162944.528006-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sunilvl@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MdnuJGdc; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io CI tests builds DynamicTablesPkg even for X86. Though the current ACPI table list is very ARM specific, it looks like there is a value in building it for x86. So, add dummy interfaces to help CI tests to succeed. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Sunil V L --- .../DynamicTableManagerDxe.inf | 5 ++- .../X86DynamicTableManagerDxe.c | 44 +++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/X86DynamicTableManagerDxe.c diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf index b49f6b811691..646454a64bc2 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf +++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf @@ -17,7 +17,7 @@ [Defines] # # The following information is for reference only and not required by the build tools. # -# VALID_ARCHITECTURES = ARM AARCH64 +# VALID_ARCHITECTURES = ARM AARCH64 IA32 X64 # [Sources] @@ -27,6 +27,9 @@ [Sources] [Sources.ARM, Sources.AARCH64] ArmDynamicTableManagerDxe.c +[Sources.IA32, Sources.X64] + X86DynamicTableManagerDxe.c + [Packages] MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/X86DynamicTableManagerDxe.c b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/X86DynamicTableManagerDxe.c new file mode 100644 index 000000000000..f8b35eeb1c3c --- /dev/null +++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/X86DynamicTableManagerDxe.c @@ -0,0 +1,44 @@ +/** @file + X86 Dynamic Table Manager Dxe + + Copyright (c) 2024, Ventana Micro Systems Inc. All rights reserved.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include "DynamicTableManagerDxe.h" + +// TODO: Dummy interfaces for X86 for now. + +/** The function checks if the Configuration Manager has provided the + mandatory ACPI tables for installation. + + @param [in] AcpiTableInfo Pointer to the ACPI Table Info list. + @param [in] AcpiTableCount Count of ACPI Table Info. + + @retval EFI_SUCCESS Success. +**/ +EFI_STATUS +EFIAPI +VerifyMandatoryTablesArePresent ( + IN CONST CM_STD_OBJ_ACPI_TABLE_INFO *CONST AcpiTableInfo, + IN UINT32 AcpiTableCount + ) +{ + return EFI_SUCCESS; +} + +/** The function checks if the FADT table is present and installed + + @retval TRUE FADT is present and installed. +**/ +BOOLEAN +IsFadtPresentInstalled ( + VOID + ) +{ + return TRUE; +} -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113480): https://edk2.groups.io/g/devel/message/113480 Mute This Topic: https://groups.io/mt/103622745/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-