From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 063A4AC0F9C for ; Fri, 12 Jan 2024 11:38:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aYX5gcshHK+zvT4Zk973dNxwrxavG2BfIXUlhYS3qOE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1705059483; v=1; b=j6+XH7k9iQHcJbinp90178JUnLFbUQZCVKxbtQFPvvLtXIZsjFIvWyJRrVIALDLkGAm8t3PW r/0tith5leAfqe1FfT88Kd+K0lzDTHqNK7itVzW4DuQdGULpcoxp4nHuXWLF9610FHlXhjD8s7b /TbI/esyPCy5tCycExko7Lc8= X-Received: by 127.0.0.2 with SMTP id jvydYY7687511xNUuPs3DzUd; Fri, 12 Jan 2024 03:38:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.5239.1705059483085844652 for ; Fri, 12 Jan 2024 03:38:03 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-Nt2IqbnhPxyozPzrxSeZTw-1; Fri, 12 Jan 2024 06:37:59 -0500 X-MC-Unique: Nt2IqbnhPxyozPzrxSeZTw-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBD273C00097; Fri, 12 Jan 2024 11:37:58 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.194.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C13FC1D368; Fri, 12 Jan 2024 11:37:58 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 88FEFABB84; Fri, 12 Jan 2024 12:37:54 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Laszlo Ersek , Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , oliver@redhat.com Subject: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too Date: Fri, 12 Jan 2024 12:37:54 +0100 Message-ID: <20240112113754.14710-5-kraxel@redhat.com> In-Reply-To: <20240112113754.14710-1-kraxel@redhat.com> References: <20240112113754.14710-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QdLtR5Ofdlp7KhdKZTAwuuY5x7686176AA= Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=j6+XH7k9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io It is possible to find variable entries with State being 0xff, i.e. not updated since flash block erase. This indicates the header write was not completed (and therefore State was not set to VAR_HEADER_VALID_ONLY). Treat this as additional "end of variable list" condition. Signed-off-by: Gerd Hoffmann --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c index 8fcd999ac6df..c8b5e0be1379 100644 --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c @@ -302,6 +302,11 @@ ValidateFvHeader ( break; } + if (VarHeader->State == 0xff) { + DEBUG ((DEBUG_INFO, "%a: end of var list (unwritten state)\n", __func__)); + break; + } + VarName = NULL; switch (VarHeader->State) { // usage: State = VAR_HEADER_VALID_ONLY -- 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113719): https://edk2.groups.io/g/devel/message/113719 Mute This Topic: https://groups.io/mt/103680936/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-