* [edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature
@ 2024-01-13 2:39 caiyuqing_hz
2024-01-13 2:39 ` [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension caiyuqing_hz
0 siblings, 1 reply; 4+ messages in thread
From: caiyuqing_hz @ 2024-01-13 2:39 UTC (permalink / raw)
To: devel; +Cc: Sunil V L, USER0FISH
From: caiyuqing379 <caiyuqing_hz@outlook.com>
By default the Sstc feature is enabled and Sophgo SG2042 platform need
to set the PCD to disable the feature because Sstc is not supported.
Changes since v1:
1) Format error resolved.
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
caiyuqing379 (1):
Sophgo/SG2042Pkg: Override Sstc extension
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113852): https://edk2.groups.io/g/devel/message/113852
Mute This Topic: https://groups.io/mt/103752456/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension
2024-01-13 2:39 [edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature caiyuqing_hz
@ 2024-01-13 2:39 ` caiyuqing_hz
2024-01-15 4:41 ` Sunil V L
0 siblings, 1 reply; 4+ messages in thread
From: caiyuqing_hz @ 2024-01-13 2:39 UTC (permalink / raw)
To: devel; +Cc: Sunil V L, USER0FISH
From: caiyuqing379 <caiyuqing_hz@outlook.com>
Override Sstc extension and use SBI calls itself by default for RISC-V
Sophgo SG2042 platform.
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
---
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 3bbaeca16970..127182487126 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -265,6 +265,7 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+ gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113851): https://edk2.groups.io/g/devel/message/113851
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension
2024-01-13 2:39 ` [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension caiyuqing_hz
@ 2024-01-15 4:41 ` Sunil V L
2024-01-15 7:33 ` caiyuqing379
0 siblings, 1 reply; 4+ messages in thread
From: Sunil V L @ 2024-01-15 4:41 UTC (permalink / raw)
To: caiyuqing_hz; +Cc: devel, USER0FISH
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing_hz@163.com wrote:
> From: caiyuqing379 <caiyuqing_hz@outlook.com>
>
> Override Sstc extension and use SBI calls itself by default for RISC-V
> Sophgo SG2042 platform.
>
Since the change disables CMO also (BIT 0) which is expected, could you
update the commit message to reflect it?
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks,
Sunil
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
> ---
> Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> index 3bbaeca16970..127182487126 100644
> --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> @@ -265,6 +265,7 @@
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
> gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
> --
> 2.34.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113790): https://edk2.groups.io/g/devel/message/113790
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension
2024-01-15 4:41 ` Sunil V L
@ 2024-01-15 7:33 ` caiyuqing379
0 siblings, 0 replies; 4+ messages in thread
From: caiyuqing379 @ 2024-01-15 7:33 UTC (permalink / raw)
To: Sunil V L; +Cc: devel@edk2.groups.io, libing1202@outlook.com
[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]
Hi, Sunil
Thanks for the suggestion, I'll keep the commit message up to date.
Thanks again!
Yuqing Cai
---- Replied Message ----
| From | Sunil V L<sunilvl@ventanamicro.com> |
| Date | 1/15/2024 12:41 |
| To | <caiyuqing_hz@163.com> |
| Cc | <devel@edk2.groups.io> ,
USER0FISH<libing1202@outlook.com> |
| Subject | Re: [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension |
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing_hz@163.com wrote:
From: caiyuqing379 <caiyuqing_hz@outlook.com>
Override Sstc extension and use SBI calls itself by default for RISC-V
Sophgo SG2042 platform.
Since the change disables CMO also (BIT 0) which is expected, could you
update the commit message to reflect it?
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks,
Sunil
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
---
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 3bbaeca16970..127182487126 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -265,6 +265,7 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+ gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113853): https://edk2.groups.io/g/devel/message/113853
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 6498 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-16 5:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-13 2:39 [edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature caiyuqing_hz
2024-01-13 2:39 ` [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension caiyuqing_hz
2024-01-15 4:41 ` Sunil V L
2024-01-15 7:33 ` caiyuqing379
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox