[edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature

[edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature

[caiyuqing_hz]

From: caiyuqing379 <caiyuqing_hz@outlook.com>

By default the Sstc feature is enabled and Sophgo SG2042 platform need
to set the PCD to disable the feature because Sstc is not supported.

Changes since v1:
    1) Format error resolved.

Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>

caiyuqing379 (1):
  Sophgo/SG2042Pkg: Override Sstc extension

 Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
 1 file changed, 1 insertion(+)

--
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113852): https://edk2.groups.io/g/devel/message/113852
Mute This Topic: https://groups.io/mt/103752456/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

[caiyuqing_hz]

From: caiyuqing379 <caiyuqing_hz@outlook.com>

Override Sstc extension and use SBI calls itself by default for RISC-V
Sophgo SG2042 platform.

Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
---
 Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 3bbaeca16970..127182487126 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -265,6 +265,7 @@
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
   gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113851): https://edk2.groups.io/g/devel/message/113851
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

[Sunil V L]

On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing_hz@163.com wrote:
> From: caiyuqing379 <caiyuqing_hz@outlook.com>
> 
> Override Sstc extension and use SBI calls itself by default for RISC-V
> Sophgo SG2042 platform.
> 
Since the change disables CMO also (BIT 0) which is expected, could you
update the commit message to reflect it? 

Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks,
Sunil
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
> ---
>  Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> index 3bbaeca16970..127182487126 100644
> --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> @@ -265,6 +265,7 @@
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> +  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
>    gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
> -- 
> 2.34.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113790): https://edk2.groups.io/g/devel/message/113790
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension

[caiyuqing379]

[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]

Hi, Sunil
Thanks for the suggestion, I'll keep the commit message up to date.


Thanks again!
Yuqing Cai
---- Replied Message ----
| From | Sunil V L<sunilvl@ventanamicro.com> |
| Date | 1/15/2024 12:41 |
| To | <caiyuqing_hz@163.com> |
| Cc | <devel@edk2.groups.io> ,
USER0FISH<libing1202@outlook.com> |
| Subject | Re: [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension |
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing_hz@163.com wrote:
From: caiyuqing379 <caiyuqing_hz@outlook.com>

Override Sstc extension and use SBI calls itself by default for RISC-V
Sophgo SG2042 platform.

Since the change disables CMO also (BIT 0) which is expected, could you
update the commit message to reflect it?

Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks,
Sunil
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
---
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 3bbaeca16970..127182487126 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -265,6 +265,7 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
--
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113853): https://edk2.groups.io/g/devel/message/113853
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6498 bytes --]