[edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: update doc a bit

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: update doc a bit

[Marcin Juszkiewicz]

We emulate XHCI controller already. No need to add it.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Platform/Qemu/SbsaQemu/Readme.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md
index 3355adebd4c6..883535dfd20e 100644
--- a/Platform/Qemu/SbsaQemu/Readme.md
+++ b/Platform/Qemu/SbsaQemu/Readme.md
@@ -113,9 +113,9 @@ Create a directory $WORKSPACE that would hold source code of the components.
   ```
   $INSTALL_PATH/qemu-system-aarch64 -m 1024 -M sbsa-ref -pflash SBSA_FLASH0.fd -pflash SBSA_FLASH1.fd -serial stdio
   ```
-  You can add XHCI controller with keyboard and mouse by:
+  You can keyboard and mouse by:
   ```
-  -device qemu-xhci -device usb-mouse -device usb-kbd
+  -device usb-mouse -device usb-kbd
   ```
   You can add the hard drive to platform AHCI controller by `hda` parameter:
   ```
-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113923): https://edk2.groups.io/g/devel/message/113923
Mute This Topic: https://groups.io/mt/103768126/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: update doc a bit

[Leif Lindholm]

On Tue, Jan 16, 2024 at 19:05:35 +0100, Marcin Juszkiewicz wrote:
> We emulate XHCI controller already. No need to add it.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>  Platform/Qemu/SbsaQemu/Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md
> index 3355adebd4c6..883535dfd20e 100644
> --- a/Platform/Qemu/SbsaQemu/Readme.md
> +++ b/Platform/Qemu/SbsaQemu/Readme.md
> @@ -113,9 +113,9 @@ Create a directory $WORKSPACE that would hold source code of the components.
>    ```
>    $INSTALL_PATH/qemu-system-aarch64 -m 1024 -M sbsa-ref -pflash SBSA_FLASH0.fd -pflash SBSA_FLASH1.fd -serial stdio
>    ```
> -  You can add XHCI controller with keyboard and mouse by:
> +  You can keyboard and mouse by:

missing "add".
I added that.
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Pushed as 82c4c4b03865.

Thanks!

/
    Leif

>    ```
> -  -device qemu-xhci -device usb-mouse -device usb-kbd
> +  -device usb-mouse -device usb-kbd
>    ```
>    You can add the hard drive to platform AHCI controller by `hda` parameter:
>    ```
> -- 
> 2.43.0
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114094): https://edk2.groups.io/g/devel/message/114094
Mute This Topic: https://groups.io/mt/103768126/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-