From: "duke.zhai via groups.io" <duke.zhai=amd.com@groups.io>
To: <devel@edk2.groups.io>
Cc: Eric Xing <eric.xing@amd.com>, Ken Yao <ken.yao@amd.com>,
Igniculus Fu <igniculus.fu@amd.com>,
Abner Chang <abner.chang@amd.com>
Subject: [edk2-devel] [PATCH 09/33] AMD/VanGoghBoard: Check in Flash_AB
Date: Thu, 18 Jan 2024 14:50:22 +0800 [thread overview]
Message-ID: <20240118065046.961-10-duke.zhai@amd.com> (raw)
In-Reply-To: <20240118065046.961-1-duke.zhai@amd.com>
From: Duke Zhai <Duke.Zhai@amd.com>
BZ #:4640
Chachani board supports AB recovery function.
Initial Flash_AB module to create AB recovery header in BIOS binary.
Signed-off-by: Duke Zhai <duke.zhai@amd.com>
Cc: Eric Xing <eric.xing@amd.com>
Cc: Ken Yao <ken.yao@amd.com>
Cc: Igniculus Fu <igniculus.fu@amd.com>
Cc: Abner Chang <abner.chang@amd.com>
---
.../ImageSlotHeader/ImageSlotHeader_1.inf | 34 ++++++++++++++++
.../ImageSlotHeader/ImageSlotHeader_1.nasmb | 18 +++++++++
.../ImageSlotHeader/ImageSlotHeader_2.inf | 34 ++++++++++++++++
.../ImageSlotHeader/ImageSlotHeader_2.nasmb | 18 +++++++++
.../Flash_AB/NewEFS/NewEFS.inf | 26 ++++++++++++
.../Flash_AB/NewEFS/NewEFS.nasmb | 40 +++++++++++++++++++
.../PspL1Directory/PspL1Directory.inf | 38 ++++++++++++++++++
.../PspL1Directory/PspL1Directory.nasmb | 28 +++++++++++++
8 files changed, 236 insertions(+)
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.inf
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.nasmb
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.inf
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.nasmb
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.inf
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.nasmb
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.inf
create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.nasmb
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.inf b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.inf
new file mode 100644
index 0000000000..61184ca544
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.inf
@@ -0,0 +1,34 @@
+## @file
+# ImageSlotHeader_1
+#
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = ImageSlotHeader_1
+ FILE_GUID = 3FAD5469-976C-4BBB-8127-43D536A71356
+ MODULE_TYPE = SEC
+ VERSION_STRING = 1.1
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64
+#
+
+[Sources]
+ ImageSlotHeader_1.nasmb
+
+[Packages]
+ MdePkg/MdePkg.dec
+ ChachaniBoardPkg/Project.dec
+
+[Pcd]
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotImageSize
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotDefaultPriority
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotUpdateRetries
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotGlitchRetry
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlot1Base
\ No newline at end of file
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.nasmb b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.nasmb
new file mode 100644
index 0000000000..6b57199f2f
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_1.nasmb
@@ -0,0 +1,18 @@
+;/** @file
+; ImageSlotHeader_1
+;
+; Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+; SPDX-License-Identifier: BSD-2-Clause-Patent
+;
+;**/
+
+BITS 16
+
+ALIGN 16
+
+ImageSlotHeader:
+ DD FixedPcdGet32 (PcdFlashAbImageSlotDefaultPriority) ; Priority
+ DD FixedPcdGet32 (PcdFlashAbImageSlotUpdateRetries) ; UpdateRetries - [2^(n+1) - 1]
+ DD FixedPcdGet32 (PcdFlashAbImageSlotGlitchRetry) ; GlitchRetry
+ DD FixedPcdGet32 (PcdFlashAbImageSlot1Base) ; Location of IMAGES_SLOT No.
+ ; Enhanced Structure
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.inf b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.inf
new file mode 100644
index 0000000000..df23e3d8fd
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.inf
@@ -0,0 +1,34 @@
+## @file
+# ImageSlotHeader_2
+#
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = ImageSlotHeader_2
+ FILE_GUID = 889470B2-F0EC-456b-9D23-5379959AB561
+ MODULE_TYPE = SEC
+ VERSION_STRING = 1.1
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64
+#
+
+[Sources]
+ ImageSlotHeader_2.nasmb
+
+[Packages]
+ MdePkg/MdePkg.dec
+ ChachaniBoardPkg/Project.dec
+
+[Pcd]
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotImageSize
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotDefaultPriority
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotUpdateRetries
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotGlitchRetry
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlot2Base
\ No newline at end of file
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.nasmb b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.nasmb
new file mode 100644
index 0000000000..c257cf3c3f
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/ImageSlotHeader/ImageSlotHeader_2.nasmb
@@ -0,0 +1,18 @@
+;/** @file
+; ImageSlotHeader_2
+;
+; Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+; SPDX-License-Identifier: BSD-2-Clause-Patent
+;
+;**/
+
+BITS 16
+
+ALIGN 16
+
+ImageSlotHeader:
+ DD FixedPcdGet32 (PcdFlashAbImageSlotDefaultPriority) - 1 ; Priority
+ DD FixedPcdGet32 (PcdFlashAbImageSlotUpdateRetries) ; UpdateRetries - [2^(n+1) - 1]
+ DD FixedPcdGet32 (PcdFlashAbImageSlotGlitchRetry) ; GlitchRetry
+ DD FixedPcdGet32 (PcdFlashAbImageSlot2Base) ; Location of IMAGES_SLOT No.
+ ; Enhanced Structure
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.inf b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.inf
new file mode 100644
index 0000000000..2315f0e2e1
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.inf
@@ -0,0 +1,26 @@
+## @file
+# EFS header
+#
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = NewEFS
+ FILE_GUID = 9EB20E65-AA38-44e8-8315-BE4305EAB250
+ MODULE_TYPE = SEC
+ VERSION_STRING = 1.1
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64
+#
+
+[Sources]
+ NewEFS.nasmb
+
+[Packages]
+ MdePkg/MdePkg.dec
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.nasmb b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.nasmb
new file mode 100644
index 0000000000..1133fe21ae
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/NewEFS/NewEFS.nasmb
@@ -0,0 +1,40 @@
+;/** @file
+; ImageSlotHeader_2
+;
+; Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+; SPDX-License-Identifier: BSD-2-Clause-Patent
+;
+;**/
+
+BITS 16
+
+ALIGN 16
+
+OemRomSignature:
+ DD 0x55AA55AA ; 0x00 - Signature
+ DD 0x00000000 ; 0x04 - Reserved
+ DD 0x00000000 ; 0x08 - Reserved
+ DD 0x00000000 ; 0x0C - Reserved
+ DD 0x00000000 ; 0x10 - Reserved
+ DD 0x00021000 ; 0x14 - PSP_L1_DIRECTORY
+ DD 0x00000000 ; 0x18 - Reserved
+ DD 0x00000000 ; 0x1C - Reserved
+ DD 0x00000000 ; 0x20 - Reserved
+ DD 0x00000000 ; 0x24 - Reserved
+ DD 0x00000000 ; 0x28 - Reserved
+ DD 0x00000000 ; 0x2C - Reserved
+ DD 0x00000000 ; 0x30 - Reserved
+ DD 0x00000000 ; 0x34 - Reserved
+ DD 0x00000000 ; 0x38 - Reserved
+ DD 0x00000000 ; 0x3C - Reserved
+ DB 0xFF ; 0x40 - SPI read mode for
+ DB 0xFF ; 0x41 - SPI read speed for
+ DB 0x00 ; 0x42 - Reserved
+ DB 0xFF ; 0x43 - SPI read mode
+ DB 0xFF ; 0x44 - SPI read speed
+ DB 0xFF ; 0x45 - SPI Dummy Cycle Config
+ DB 0x00 ; 0x46 - Reserved
+ DB 0x05 ; 0x47 - SpiReadMode
+ DB 0x00 ; 0x48 - SpiFastSpeed
+ DB 0x55 ; 0x49 - MicronDetectFlag
+ DB 0x01 ; 0x4A - SpiWriteSpeed
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.inf b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.inf
new file mode 100644
index 0000000000..b96f6774d5
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.inf
@@ -0,0 +1,38 @@
+## @file
+# PspL1Directory
+#
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = PspL1Directory
+ FILE_GUID = A41C64EC-9702-42bd-8C4A-84F64CA6DCFE
+ MODULE_TYPE = SEC
+ VERSION_STRING = 1.1
+
+#
+# The following information is for reference only and not required by the build tools.
+#
+# VALID_ARCHITECTURES = IA32 X64
+#
+
+[Sources]
+ PspL1Directory.nasmb
+
+[Packages]
+ MdePkg/MdePkg.dec
+ ChachaniBoardPkg/Project.dec
+
+[Pcd]
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotNumbers
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader1Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader2Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader3Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader4Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader5Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader6Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader7Base
+ gPlatformPkgTokenSpaceGuid.PcdFlashAbImageSlotHeader8Base
diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.nasmb b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.nasmb
new file mode 100644
index 0000000000..65cbc4565a
--- /dev/null
+++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Flash_AB/PspL1Directory/PspL1Directory.nasmb
@@ -0,0 +1,28 @@
+;/** @file
+; ImageSlotHeader_2
+;
+; Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
+; SPDX-License-Identifier: BSD-2-Clause-Patent
+;
+;**/
+
+BITS 16
+
+ALIGN 16
+
+PspL1Directory:
+ ; Header
+ DD 0x50535024 ; Signature â$PSPâ
+ DD 0x00000000 ; Checksum of PSP_L1_DIRECTORY
+ DD FixedPcdGet32 (PcdFlashAbImageSlotNumbers) ; Total enties of IMAGE_SLOT
+ DD 0x00000000 ; Reserved
+ ; Entry 1
+ DD 0x00000048 ; Type
+ DD 0x00000000 ; Size - Reserved
+ DD FixedPcdGet32 (PcdFlashAbImageSlotHeader1Base) ; Location (L) of IMAGE_SLOT_HEADER No.
+ DD 0x00000000 ; Location (H) of IMAGE_SLOT_HEADER No.
+ ; Entry 2
+ DD 0x0000004A ; Type
+ DD 0x00000000 ; Size - Reserved
+ DD FixedPcdGet32 (PcdFlashAbImageSlotHeader2Base) ; Location (L) of IMAGE_SLOT_HEADER No.
+ DD 0x00000000 ; Location (H) of IMAGE_SLOT_HEADER No.
--
2.31.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114058): https://edk2.groups.io/g/devel/message/114058
Mute This Topic: https://groups.io/mt/103831170/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-19 14:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 6:50 [edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 01/33] AMD/AmdPlatformPkg: Check in AMD S3 logo duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 02/33] AMD/VanGoghBoard: Check in ACPI tables duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 03/33] AMD/VanGoghBoard: Check in Capsule update duke.zhai via groups.io
2024-01-23 4:42 ` Chang, Abner via groups.io
2024-01-25 8:25 ` Zhai, MingXin (Duke) via groups.io
2024-01-25 11:45 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg duke.zhai via groups.io
2024-01-23 4:44 ` Chang, Abner via groups.io
2024-01-25 8:17 ` Xing, Eric via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 05/33] AMD/VanGoghBoard: Check in PlatformSecLib duke.zhai via groups.io
2024-01-23 4:46 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 06/33] AMD/VanGoghBoard: Check in AmdIdsExtLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 07/33] AMD/VanGoghBoard: Check in PciPlatform duke.zhai via groups.io
2024-01-23 4:50 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 08/33] AMD/VanGoghBoard: Check in UDKFlashUpdate duke.zhai via groups.io
2024-01-18 6:50 ` duke.zhai via groups.io [this message]
2024-01-18 6:50 ` [edk2-devel] [PATCH 10/33] AMD/VanGoghBoard: Check in FlashUpdate duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 11/33] AMD/VanGoghBoard: Check in FvbServices duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 12/33] AMD/VanGoghBoard: Check in AMD BaseSerialPortLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 13/33] AMD/VanGoghBoard: Check in PlatformFlashAccessLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 14/33] AMD/VanGoghBoard: Check in SmbiosLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 15/33] AMD/VanGoghBoard: Check in SpiFlashDeviceLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 16/33] AMD/VanGoghBoard: Check in BaseTscTimerLib duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 17/33] AMD/VanGoghBoard: Check in Smm access module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 18/33] AMD/VanGoghBoard: Check in PciHostBridge module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 19/33] AMD/VanGoghBoard: Check in PcatRealTimeClockRuntimeDxe module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 20/33] AMD/VanGoghBoard: Check in FTPM module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 21/33] AMD/VanGoghBoard: Check in SignedCapsule duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 22/33] AMD/VanGoghBoard: Check in Vtf0 duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 23/33] AMD/VanGoghBoard: Check in AcpiPlatform duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 24/33] AMD/VanGoghBoard: Check in FchSpi module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 25/33] AMD/VanGoghBoard: Check in PlatformInitPei module duke.zhai via groups.io
2024-01-23 6:35 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 26/33] AMD/VanGoghBoard: Check in Smbios platform dxe drivers duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 27/33] AMD/VanGoghBoard: Check in Fsp2WrapperPkg duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module duke.zhai via groups.io
2024-01-23 5:14 ` Chang, Abner via groups.io
2024-01-23 10:20 ` Xing, Eric via groups.io
2024-01-23 10:44 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in SmramSaveState module duke.zhai via groups.io
2024-01-20 14:37 ` Abdul Lateef Attar via groups.io
2024-01-23 5:15 ` Chang, Abner via groups.io
2024-01-23 10:27 ` Xing, Eric via groups.io
2024-01-23 10:44 ` Chang, Abner via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 30/33] AMD/VanGoghBoard: Check in EDK2 override files duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 31/33] AMD/VanGoghBoard: Check in AMD SmmControlPei module duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 32/33] AMD/VanGoghBoard: Check in Chachani board project files and build script duke.zhai via groups.io
2024-01-18 6:50 ` [edk2-devel] [PATCH 33/33] AMD/VanGoghBoard: Improvement coding style duke.zhai via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118065046.961-10-duke.zhai@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox