* [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
@ 2024-01-20 13:45 Wenxing Hou
2024-01-21 7:57 ` Li, Yi
0 siblings, 1 reply; 2+ messages in thread
From: Wenxing Hou @ 2024-01-20 13:45 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Yi Li, Guomin Jiang
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642
When use Mbedtls, there is a clang build error.
Add dummy inttypes header to fix clang build.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 1 +
CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
2 files changed, 10 insertions(+)
create mode 100644 CryptoPkg/Library/Include/inttypes.h
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index f961d85927..b601bcf85c 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -44,6 +44,7 @@
# This has Mbedtls interfaces that aren't UEFI spec compliant
"Library/Include/stdint.h",
"Library/Include/stubs-32.h",
+ "Library/Include/inttypes.h",
# These directories contain auto-generated OpenSSL content
"Library/OpensslLib",
"Library/IntrinsicLib",
diff --git a/CryptoPkg/Library/Include/inttypes.h b/CryptoPkg/Library/Include/inttypes.h
new file mode 100644
index 0000000000..3d44d8201d
--- /dev/null
+++ b/CryptoPkg/Library/Include/inttypes.h
@@ -0,0 +1,9 @@
+/** @file
+ Include file to support building the third-party cryptographic library.
+
+Copyright (c) 2024, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <CrtLibSupport.h>
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114115): https://edk2.groups.io/g/devel/message/114115
Mute This Topic: https://groups.io/mt/103849296/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
2024-01-20 13:45 [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build Wenxing Hou
@ 2024-01-21 7:57 ` Li, Yi
0 siblings, 0 replies; 2+ messages in thread
From: Li, Yi @ 2024-01-21 7:57 UTC (permalink / raw)
To: Hou, Wenxing, devel@edk2.groups.io; +Cc: Yao, Jiewen, Jiang, Guomin
Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>
-----Original Message-----
From: Hou, Wenxing <wenxing.hou@intel.com>
Sent: Saturday, January 20, 2024 9:45 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642
When use Mbedtls, there is a clang build error.
Add dummy inttypes header to fix clang build.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 1 +
CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
2 files changed, 10 insertions(+)
create mode 100644 CryptoPkg/Library/Include/inttypes.h
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927..b601bcf85c 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -44,6 +44,7 @@
# This has Mbedtls interfaces that aren't UEFI spec compliant "Library/Include/stdint.h", "Library/Include/stubs-32.h",+ "Library/Include/inttypes.h", # These directories contain auto-generated OpenSSL content "Library/OpensslLib", "Library/IntrinsicLib",diff --git a/CryptoPkg/Library/Include/inttypes.h b/CryptoPkg/Library/Include/inttypes.h
new file mode 100644
index 0000000000..3d44d8201d
--- /dev/null
+++ b/CryptoPkg/Library/Include/inttypes.h
@@ -0,0 +1,9 @@
+/** @file+ Include file to support building the third-party
+cryptographic library.++Copyright (c) 2024, Intel Corporation. All
+rights reserved.<BR>+SPDX-License-Identifier:
+BSD-2-Clause-Patent++**/++#include <CrtLibSupport.h>--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114123): https://edk2.groups.io/g/devel/message/114123
Mute This Topic: https://groups.io/mt/103849296/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-21 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-20 13:45 [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build Wenxing Hou
2024-01-21 7:57 ` Li, Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox