From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48D38D80471 for ; Sat, 27 Jan 2024 00:01:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BTI8HxgFUkIclvmGXe3XCiYh8UtQMT+DWmyCxk9aAXA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1706313695; v=1; b=chpS/p3z+3UCEwHDOZv2T7/Fu85bJEOGFbaqw0+RNmltSxBMp0nR8iqfjQTcRmzj8W13/u5T KAvyN+Ey3ySuKyHni93c3j+OZQF1GWFeTEeqI8znuPB72z7KxJslMRHxpo6r74YmdxvcwQ1vm6n ZHVkgb4u6zZqJTQUZugfH20s= X-Received: by 127.0.0.2 with SMTP id rTKfYY7687511xpNaqaowYTp; Fri, 26 Jan 2024 16:01:35 -0800 X-Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web10.5478.1706313694545459142 for ; Fri, 26 Jan 2024 16:01:34 -0800 X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-51021ba75edso1087333e87.3 for ; Fri, 26 Jan 2024 16:01:34 -0800 (PST) X-Gm-Message-State: kISo8NVnu0fxZY8KxA45JWYux7686176AA= X-Google-Smtp-Source: AGHT+IGoXCFdhzTzNjwktdmvp3YetAz+P5MTJCPKnd1bCg1ioYvtKX/rsClHhmmObc4wmQJTvBgfxA== X-Received: by 2002:a05:6512:1284:b0:510:fdd:37d3 with SMTP id u4-20020a056512128400b005100fdd37d3mr345642lfs.65.1706313692554; Fri, 26 Jan 2024 16:01:32 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id u17-20020ac243d1000000b0050f076b43ccsm323874lfl.182.2024.01.26.16.01.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 26 Jan 2024 16:01:32 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory leak in ConverterLib Date: Sat, 27 Jan 2024 03:01:28 +0300 Message-Id: <20240127000128.67202-3-mike.maslenkin@gmail.com> In-Reply-To: <20240127000128.67202-1-mike.maslenkin@gmail.com> References: <20240127000128.67202-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="chpS/p3z"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) The memory returned by json_dumps() must be freed. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c b/RedfishC= lientPkg/ConverterLib/src/RedfishCsCommon.c index 126200dd019c..250ef75e40de 100644 --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c @@ -379,15 +379,19 @@ CreateCsJsonByNode ( if (TempChar !=3D NULL) {=0D Status =3D allocateRecordCsMemory (Cs, sizeof (RedfishCS_Type_JSON_Dat= a), (void **)&CsTypeJson);=0D if (Status !=3D RedfishCS_status_success) {=0D + free (TempChar);=0D return Status;=0D }=0D =0D Status =3D allocateRecordCsMemory (Cs, (RedfishCS_int)strlen (TempChar= ) + 1, (void **)&DumpStr);=0D if (Status !=3D RedfishCS_status_success) {=0D + free (TempChar);=0D return Status;=0D }=0D =0D strncpy (DumpStr, TempChar, strlen (TempChar) + 1);=0D + free (TempChar);=0D +=0D InitializeLinkHead (&CsTypeJson->Header.LinkEntry);=0D CsTypeJson->Header.ResourceType =3D RedfishCS_Type_JSON;=0D CsTypeJson->Header.ThisUri =3D ParentUri;=0D @@ -1506,9 +1510,10 @@ RemoveUnchangeableProperties ( Status =3D RedfishCS_status_insufficient_memory;=0D } else {=0D memcpy (NewJsonBuffer, TempChar, strlen (TempChar) + 1);=0D - free (TempChar);=0D Status =3D RedfishCS_status_success;=0D }=0D +=0D + free (TempChar);=0D } else {=0D Status =3D RedfishCS_status_unknown_error;=0D }=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114645): https://edk2.groups.io/g/devel/message/114645 Mute This Topic: https://groups.io/mt/103988340/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-