From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39AF4941098 for ; Mon, 29 Jan 2024 05:42:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=74O30C2jAF0/iYcp5EveE81TMYM3tYAmtVOiqI1FxWg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1706506969; v=1; b=gRZz8Oy7mM0ojAJLMpwjGHQWwjQq1hFd+GDqoLq2LFAlv4+J+EYzJc9tAwMrlZHjH4X0U6JM T8y4TvXm5q0/hxuh6VELEBiI9/pJI1JmWvI2XG9aVRn1evaLbdFGsNa9Npm8zmmmSE3ENng55ZK 9dpOf4GmqhmTfHFX+ScYPIoU= X-Received: by 127.0.0.2 with SMTP id nN8eYY7687511xWfJD9kcuY7; Sun, 28 Jan 2024 21:42:49 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.8339.1706506968633794223 for ; Sun, 28 Jan 2024 21:42:49 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10967"; a="406580380" X-IronPort-AV: E=Sophos;i="6.05,226,1701158400"; d="scan'208";a="406580380" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2024 21:42:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,226,1701158400"; d="scan'208";a="36015814" X-Received: from shwdesssddpdwei.ccr.corp.intel.com ([10.239.157.28]) by orviesa001.jf.intel.com with ESMTP; 28 Jan 2024 21:42:47 -0800 From: "Sheng Wei" To: devel@edk2.groups.io Cc: Ray Ni , Rangasai V Chaganty , Jenny Huang , Chiang Chris Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Remove ASSERT in VTdSetAttribute Date: Mon, 29 Jan 2024 13:42:41 +0800 Message-Id: <20240129054241.948-1-w.sheng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,w.sheng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KkyWaCKSVB7YHTsnTcdPeAGex7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gRZz8Oy7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io When PcdVTdPolicyPropertyMask BIT2 is set and ACPI DMAR table is not ready, It is no need to hit an assert, and just returns EFI_NOT_READY. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Chiang Chris Signed-off-by: Sheng Wei --- .../Feature/VTd/IntelVTdCoreDxe/IntelVTdCoreDxe.c | 1 - .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c | 1 - 2 files changed, 2 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/Inte= lVTdCoreDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/I= ntelVTdCoreDxe.c index 8449b288..27821782 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/IntelVTdCor= eDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/IntelVTdCor= eDxe.c @@ -253,7 +253,6 @@ VTdSetAttribute ( //=0D // Force no IOMMU access attribute request recording before DMAR tab= le is installed.=0D //=0D - ASSERT_EFI_ERROR (EFI_NOT_READY);=0D return EFI_NOT_READY;=0D }=0D Status =3D RequestAccessAttribute (Segment, SourceId, DeviceAddress, L= ength, IoMmuAccess);=0D diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTd= Dxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c index a6287be2..d7aa106f 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c @@ -252,7 +252,6 @@ VTdSetAttribute ( //=0D // Force no IOMMU access attribute request recording before DMAR tab= le is installed.=0D //=0D - ASSERT_EFI_ERROR (EFI_NOT_READY);=0D return EFI_NOT_READY;=0D }=0D Status =3D RequestAccessAttribute (Segment, SourceId, DeviceAddress, L= ength, IoMmuAccess);=0D --=20 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114676): https://edk2.groups.io/g/devel/message/114676 Mute This Topic: https://groups.io/mt/104026555/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-