From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 732A1941050 for ; Wed, 31 Jan 2024 04:45:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XVPcSW3rYynu59kKI1AxAwA5pHpjHBxJaZr6pTXGJHs=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1706676305; v=1; b=TdwLGuOJ7TRVFY+WtIvWhbQd1hag49JHaHy8oDPUlMY9a3ldwhbK0HNuM0HzF4qmoJ3s3tm5 E07LxQF4V+FIkgIVXYZa/ppqO3UgJlF9uBzNohAYVQmdU0UJkrl8RrhVgcVLs2cn18GpaRnV9XC rMxWOn7NjG8JalU685L/2pIY= X-Received: by 127.0.0.2 with SMTP id pmF4YY7687511xhu5YITQYAF; Tue, 30 Jan 2024 20:45:05 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.7653.1706676304504518376 for ; Tue, 30 Jan 2024 20:45:04 -0800 X-Received: from localhost.localdomain (unknown [47.201.241.198]) by linux.microsoft.com (Postfix) with ESMTPSA id C77272057C11; Tue, 30 Jan 2024 20:45:02 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C77272057C11 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Ray Ni Subject: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion Date: Tue, 30 Jan 2024 23:44:21 -0500 Message-ID: <20240131044422.1837-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FCoPgBN3AZjIt5YsS8QA74M1x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TdwLGuOJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Michael Kubacki Currently, if a MMI handler returns an unexpected failure status code, ASSERT (FALSE) is used. It is more useful to use ASSERT_EFI_ERROR() which also outputs the status code value. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Michael Kubacki --- StandaloneMmPkg/Core/Mmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c index 8252355a48eb..0de6fd17fc88 100644 --- a/StandaloneMmPkg/Core/Mmi.c +++ b/StandaloneMmPkg/Core/Mmi.c @@ -208,7 +208,7 @@ MmiManage ( // // Unexpected status code returned. // - ASSERT (FALSE); + ASSERT_EFI_ERROR (Status); break; } } --=20 2.43.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114854): https://edk2.groups.io/g/devel/message/114854 Mute This Topic: https://groups.io/mt/104069723/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-