* [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
@ 2024-02-02 16:32 Lee, Chun-Yi
2024-02-04 9:35 ` joeyli via groups.io
0 siblings, 1 reply; 12+ messages in thread
From: Lee, Chun-Yi @ 2024-02-02 16:32 UTC (permalink / raw)
To: devel
Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi
In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. But the default valid date can _NOT_ pass the Microsoft
SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
the error message:
BIOS Release Date string is unexpected length: 8. This string must be in
MM/DD/YYYY format. No other format is allowed and no additional information
may be included. See field description in the SMBIOS specification.
Base on SMBIOS spec v3.7.0:
08h 2.0+ BIOS Release Date BYTE STRING
String number of the BIOS release date. The date
string, if supplied, is in either mm/dd/yy or
mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS
version 2.3 and later.
So, let's tweek the fallback release date again.
Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
CryptoPkg/Library/OpensslLib/openssl | 2 +-
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
index de90e54bbe..830bf8e1e4 160000
--- a/CryptoPkg/Library/OpensslLib/openssl
+++ b/CryptoPkg/Library/OpensslLib/openssl
@@ -1 +1 @@
-Subproject commit de90e54bbe82e5be4fb9608b6f5c308bb837d355
+Subproject commit 830bf8e1e4749ad65c51b6a1d0d769ae689404ba
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index 0ca3776045..e929da6b81 100644
--- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -160,7 +160,7 @@ InstallAllStructures (
DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
DateLen = StrLen (DateStr);
if (DateLen < 3) {
- DateStr = L"2/2/2022";
+ DateStr = L"02/02/2022";
DateLen = StrLen (DateStr);
}
--
2.12.3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115090): https://edk2.groups.io/g/devel/message/115090
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-02 16:32 [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Lee, Chun-Yi
@ 2024-02-04 9:35 ` joeyli via groups.io
0 siblings, 0 replies; 12+ messages in thread
From: joeyli via groups.io @ 2024-02-04 9:35 UTC (permalink / raw)
To: Lee, Chun-Yi
Cc: devel, Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao
Hi experts,
On Sat, Feb 03, 2024 at 12:32:01AM +0800, Lee, Chun-Yi wrote:
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. But the default valid date can _NOT_ pass the Microsoft
> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> the error message:
>
> BIOS Release Date string is unexpected length: 8. This string must be in
> MM/DD/YYYY format. No other format is allowed and no additional information
> may be included. See field description in the SMBIOS specification.
>
> Base on SMBIOS spec v3.7.0:
>
> 08h 2.0+ BIOS Release Date BYTE STRING
> String number of the BIOS release date. The date
> string, if supplied, is in either mm/dd/yy or
> mm/dd/yyyy format. If the year portion of the string
> is two digits, the year is assumed to be 19yy.
> NOTE: The mm/dd/yyyy format is required for SMBIOS
> version 2.3 and later.
>
> So, let's tweek the fallback release date again.
>
> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
> CryptoPkg/Library/OpensslLib/openssl | 2 +-
> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
> index de90e54bbe..830bf8e1e4 160000
> --- a/CryptoPkg/Library/OpensslLib/openssl
> +++ b/CryptoPkg/Library/OpensslLib/openssl
> @@ -1 +1 @@
> -Subproject commit de90e54bbe82e5be4fb9608b6f5c308bb837d355
> +Subproject commit 830bf8e1e4749ad65c51b6a1d0d769ae689404ba
Sorry for I touched openssl commit when generating this patch.
I will re-send patch again.
Joey Lee
> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index 0ca3776045..e929da6b81 100644
> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -160,7 +160,7 @@ InstallAllStructures (
> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> DateLen = StrLen (DateStr);
> if (DateLen < 3) {
> - DateStr = L"2/2/2022";
> + DateStr = L"02/02/2022";
> DateLen = StrLen (DateStr);
> }
>
> --
> 2.12.3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115082): https://edk2.groups.io/g/devel/message/115082
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread
* [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
@ 2024-02-04 9:29 Lee, Chun-Yi
2024-02-04 9:38 ` joeyli via groups.io
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Lee, Chun-Yi @ 2024-02-04 9:29 UTC (permalink / raw)
To: devel
Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi
In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. But the default valid date can _NOT_ pass the Microsoft
SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
the error message:
BIOS Release Date string is unexpected length: 8. This string must be in
MM/DD/YYYY format. No other format is allowed and no additional information
may be included. See field description in the SMBIOS specification.
Base on SMBIOS spec v3.7.0:
08h 2.0+ BIOS Release Date BYTE STRING
String number of the BIOS release date. The date
string, if supplied, is in either mm/dd/yy or
mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS
version 2.3 and later.
So, let's tweek the fallback release date again.
Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index 0ca3776045..e929da6b81 100644
--- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -160,7 +160,7 @@ InstallAllStructures (
DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
DateLen = StrLen (DateStr);
if (DateLen < 3) {
- DateStr = L"2/2/2022";
+ DateStr = L"02/02/2022";
DateLen = StrLen (DateStr);
}
--
2.12.3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115093): https://edk2.groups.io/g/devel/message/115093
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-04 9:29 Lee, Chun-Yi
@ 2024-02-04 9:38 ` joeyli via groups.io
2024-02-05 7:31 ` Laszlo Ersek
2024-02-05 16:41 ` Laszlo Ersek
2 siblings, 0 replies; 12+ messages in thread
From: joeyli via groups.io @ 2024-02-04 9:38 UTC (permalink / raw)
To: Lee, Chun-Yi
Cc: devel, Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao
Hi experts,
On Sun, Feb 04, 2024 at 05:29:14PM +0800, Lee, Chun-Yi wrote:
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. But the default valid date can _NOT_ pass the Microsoft
> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> the error message:
>
> BIOS Release Date string is unexpected length: 8. This string must be in
> MM/DD/YYYY format. No other format is allowed and no additional information
> may be included. See field description in the SMBIOS specification.
>
> Base on SMBIOS spec v3.7.0:
>
> 08h 2.0+ BIOS Release Date BYTE STRING
> String number of the BIOS release date. The date
> string, if supplied, is in either mm/dd/yy or
> mm/dd/yyyy format. If the year portion of the string
> is two digits, the year is assumed to be 19yy.
> NOTE: The mm/dd/yyyy format is required for SMBIOS
> version 2.3 and later.
>
> So, let's tweek the fallback release date again.
>
> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
I also filed a pull request on github against this patch:
https://github.com/tianocore/edk2/pull/5343
Thanks a lot!
Joey Lee
> ---
> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index 0ca3776045..e929da6b81 100644
> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -160,7 +160,7 @@ InstallAllStructures (
> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> DateLen = StrLen (DateStr);
> if (DateLen < 3) {
> - DateStr = L"2/2/2022";
> + DateStr = L"02/02/2022";
> DateLen = StrLen (DateStr);
> }
>
> --
> 2.12.3
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115083): https://edk2.groups.io/g/devel/message/115083
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-04 9:29 Lee, Chun-Yi
2024-02-04 9:38 ` joeyli via groups.io
@ 2024-02-05 7:31 ` Laszlo Ersek
2024-02-05 16:41 ` Laszlo Ersek
2 siblings, 0 replies; 12+ messages in thread
From: Laszlo Ersek @ 2024-02-05 7:31 UTC (permalink / raw)
To: devel, joeyli.kernel
Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi
On 2/4/24 10:29, Lee, Chun-Yi wrote:
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. But the default valid date can _NOT_ pass the Microsoft
> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> the error message:
>
> BIOS Release Date string is unexpected length: 8. This string must be in
> MM/DD/YYYY format. No other format is allowed and no additional information
> may be included. See field description in the SMBIOS specification.
>
> Base on SMBIOS spec v3.7.0:
>
> 08h 2.0+ BIOS Release Date BYTE STRING
> String number of the BIOS release date. The date
> string, if supplied, is in either mm/dd/yy or
> mm/dd/yyyy format. If the year portion of the string
> is two digits, the year is assumed to be 19yy.
> NOTE: The mm/dd/yyyy format is required for SMBIOS
> version 2.3 and later.
>
> So, let's tweek the fallback release date again.
>
> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index 0ca3776045..e929da6b81 100644
> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -160,7 +160,7 @@ InstallAllStructures (
> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> DateLen = StrLen (DateStr);
> if (DateLen < 3) {
> - DateStr = L"2/2/2022";
> + DateStr = L"02/02/2022";
> DateLen = StrLen (DateStr);
> }
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115096): https://edk2.groups.io/g/devel/message/115096
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-04 9:29 Lee, Chun-Yi
2024-02-04 9:38 ` joeyli via groups.io
2024-02-05 7:31 ` Laszlo Ersek
@ 2024-02-05 16:41 ` Laszlo Ersek
2024-02-07 7:55 ` joeyli via groups.io
2 siblings, 1 reply; 12+ messages in thread
From: Laszlo Ersek @ 2024-02-05 16:41 UTC (permalink / raw)
To: devel, joeyli.kernel
Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi
On 2/4/24 10:29, Lee, Chun-Yi wrote:
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. But the default valid date can _NOT_ pass the Microsoft
> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> the error message:
>
> BIOS Release Date string is unexpected length: 8. This string must be in
> MM/DD/YYYY format. No other format is allowed and no additional information
> may be included. See field description in the SMBIOS specification.
>
> Base on SMBIOS spec v3.7.0:
>
> 08h 2.0+ BIOS Release Date BYTE STRING
> String number of the BIOS release date. The date
> string, if supplied, is in either mm/dd/yy or
> mm/dd/yyyy format. If the year portion of the string
> is two digits, the year is assumed to be 19yy.
> NOTE: The mm/dd/yyyy format is required for SMBIOS
> version 2.3 and later.
>
> So, let's tweek the fallback release date again.
>
> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> ---
> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index 0ca3776045..e929da6b81 100644
> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -160,7 +160,7 @@ InstallAllStructures (
> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> DateLen = StrLen (DateStr);
> if (DateLen < 3) {
> - DateStr = L"2/2/2022";
> + DateStr = L"02/02/2022";
> DateLen = StrLen (DateStr);
> }
>
Are you proposing this as an important (but low risk) bugfix that might
qualify for the freeze(s)? If so, please loop in Liming and Mike.
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115119): https://edk2.groups.io/g/devel/message/115119
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-05 16:41 ` Laszlo Ersek
@ 2024-02-07 7:55 ` joeyli via groups.io
2024-02-07 8:02 ` joeyli via groups.io
[not found] ` <17B185EB8F3EA51B.19081@groups.io>
0 siblings, 2 replies; 12+ messages in thread
From: joeyli via groups.io @ 2024-02-07 7:55 UTC (permalink / raw)
To: Laszlo Ersek
Cc: devel, joeyli.kernel, Gerd Hoffmann, Jiewen Yao, Jordan Justen,
Pawel Polawski, Oliver Steffen, Ard Biesheuvel, ruifeng.gao
Hi Laszlo,
First, thanks for your review!
On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> On 2/4/24 10:29, Lee, Chun-Yi wrote:
> > In case PcdFirmwareReleaseDateString is not set use a valid date
> > as fallback. But the default valid date can _NOT_ pass the Microsoft
> > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> > the error message:
> >
> > BIOS Release Date string is unexpected length: 8. This string must be in
> > MM/DD/YYYY format. No other format is allowed and no additional information
> > may be included. See field description in the SMBIOS specification.
> >
> > Base on SMBIOS spec v3.7.0:
> >
> > 08h 2.0+ BIOS Release Date BYTE STRING
> > String number of the BIOS release date. The date
> > string, if supplied, is in either mm/dd/yy or
> > mm/dd/yyyy format. If the year portion of the string
> > is two digits, the year is assumed to be 19yy.
> > NOTE: The mm/dd/yyyy format is required for SMBIOS
> > version 2.3 and later.
> >
> > So, let's tweek the fallback release date again.
> >
> > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > ---
> > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > index 0ca3776045..e929da6b81 100644
> > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > @@ -160,7 +160,7 @@ InstallAllStructures (
> > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> > DateLen = StrLen (DateStr);
> > if (DateLen < 3) {
> > - DateStr = L"2/2/2022";
> > + DateStr = L"02/02/2022";
> > DateLen = StrLen (DateStr);
> > }
> >
>
> Are you proposing this as an important (but low risk) bugfix that might
> qualify for the freeze(s)? If so, please loop in Liming and Mike.
>
hm... What does freeze mean?
Thanks!
Joey Lee
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115232): https://edk2.groups.io/g/devel/message/115232
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-02-07 7:55 ` joeyli via groups.io
@ 2024-02-07 8:02 ` joeyli via groups.io
[not found] ` <17B185EB8F3EA51B.19081@groups.io>
1 sibling, 0 replies; 12+ messages in thread
From: joeyli via groups.io @ 2024-02-07 8:02 UTC (permalink / raw)
To: Laszlo Ersek, Gao, Liming, Michael D Kinney
Cc: devel, joeyli.kernel, Gerd Hoffmann, Jiewen Yao, Jordan Justen,
Pawel Polawski, Oliver Steffen, Ard Biesheuvel, ruifeng.gao
On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
> Hi Laszlo,
>
> First, thanks for your review!
>
> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> > On 2/4/24 10:29, Lee, Chun-Yi wrote:
> > > In case PcdFirmwareReleaseDateString is not set use a valid date
> > > as fallback. But the default valid date can _NOT_ pass the Microsoft
> > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> > > the error message:
> > >
> > > BIOS Release Date string is unexpected length: 8. This string must be in
> > > MM/DD/YYYY format. No other format is allowed and no additional information
> > > may be included. See field description in the SMBIOS specification.
> > >
> > > Base on SMBIOS spec v3.7.0:
> > >
> > > 08h 2.0+ BIOS Release Date BYTE STRING
> > > String number of the BIOS release date. The date
> > > string, if supplied, is in either mm/dd/yy or
> > > mm/dd/yyyy format. If the year portion of the string
> > > is two digits, the year is assumed to be 19yy.
> > > NOTE: The mm/dd/yyyy format is required for SMBIOS
> > > version 2.3 and later.
> > >
> > > So, let's tweek the fallback release date again.
> > >
> > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> > > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > > ---
> > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > index 0ca3776045..e929da6b81 100644
> > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > @@ -160,7 +160,7 @@ InstallAllStructures (
> > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> > > DateLen = StrLen (DateStr);
> > > if (DateLen < 3) {
> > > - DateStr = L"2/2/2022";
> > > + DateStr = L"02/02/2022";
> > > DateLen = StrLen (DateStr);
> > > }
> > >
> >
> > Are you proposing this as an important (but low risk) bugfix that might
> > qualify for the freeze(s)? If so, please loop in Liming and Mike.
> >
>
> hm... What does freeze mean?
>
ah... You mean soft feature freeze for edk2-stable202402.
Hi Liming, Michael,
This change is important but low risk. Could you please consider to add it
to edk2-stable202402 release?
Thanks a lot!
Joey Lee
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115233): https://edk2.groups.io/g/devel/message/115233
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread[parent not found: <17B185EB8F3EA51B.19081@groups.io>]
* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
[not found] ` <17B185EB8F3EA51B.19081@groups.io>
@ 2024-03-04 11:37 ` joeyli via groups.io
2024-03-05 8:53 ` Laszlo Ersek
0 siblings, 1 reply; 12+ messages in thread
From: joeyli via groups.io @ 2024-03-04 11:37 UTC (permalink / raw)
To: devel
Cc: Laszlo Ersek, Gao, Liming, Michael D Kinney, joeyli.kernel,
Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao
Hi,
On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote:
> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
> > Hi Laszlo,
> >
> > First, thanks for your review!
> >
> > On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> > > On 2/4/24 10:29, Lee, Chun-Yi wrote:
> > > > In case PcdFirmwareReleaseDateString is not set use a valid date
> > > > as fallback. But the default valid date can _NOT_ pass the Microsoft
> > > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> > > > the error message:
> > > >
> > > > BIOS Release Date string is unexpected length: 8. This string must be in
> > > > MM/DD/YYYY format. No other format is allowed and no additional information
> > > > may be included. See field description in the SMBIOS specification.
> > > >
> > > > Base on SMBIOS spec v3.7.0:
> > > >
> > > > 08h 2.0+ BIOS Release Date BYTE STRING
> > > > String number of the BIOS release date. The date
> > > > string, if supplied, is in either mm/dd/yy or
> > > > mm/dd/yyyy format. If the year portion of the string
> > > > is two digits, the year is assumed to be 19yy.
> > > > NOTE: The mm/dd/yyyy format is required for SMBIOS
> > > > version 2.3 and later.
> > > >
> > > > So, let's tweek the fallback release date again.
> > > >
> > > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> > > > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > > > ---
> > > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > > index 0ca3776045..e929da6b81 100644
> > > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > > @@ -160,7 +160,7 @@ InstallAllStructures (
> > > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> > > > DateLen = StrLen (DateStr);
> > > > if (DateLen < 3) {
> > > > - DateStr = L"2/2/2022";
> > > > + DateStr = L"02/02/2022";
> > > > DateLen = StrLen (DateStr);
> > > > }
> > > >
> > >
> > > Are you proposing this as an important (but low risk) bugfix that might
> > > qualify for the freeze(s)? If so, please loop in Liming and Mike.
> > >
> >
> > hm... What does freeze mean?
> >
>
> ah... You mean soft feature freeze for edk2-stable202402.
>
> Hi Liming, Michael,
>
> This change is important but low risk. Could you please consider to add it
> to edk2-stable202402 release?
>
> Thanks a lot!
> Joey Lee
This patch is not in edk2-stable202402. Will it to be merged to next release?
Thanks a lot!
Joey Lee
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116311): https://edk2.groups.io/g/devel/message/116311
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-03-04 11:37 ` joeyli via groups.io
@ 2024-03-05 8:53 ` Laszlo Ersek
2024-03-07 9:04 ` joeyli via groups.io
0 siblings, 1 reply; 12+ messages in thread
From: Laszlo Ersek @ 2024-03-05 8:53 UTC (permalink / raw)
To: devel, jlee
Cc: Liming, Michael D Kinney, joeyli.kernel, Gerd Hoffmann,
Jiewen Yao, Jordan Justen, Pawel Polawski, Oliver Steffen,
Ard Biesheuvel, ruifeng.gao
On 3/4/24 12:37, joeyli via groups.io wrote:
> Hi,
>
> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote:
>> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
>>> Hi Laszlo,
>>>
>>> First, thanks for your review!
>>>
>>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
>>>> On 2/4/24 10:29, Lee, Chun-Yi wrote:
>>>>> In case PcdFirmwareReleaseDateString is not set use a valid date
>>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft
>>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
>>>>> the error message:
>>>>>
>>>>> BIOS Release Date string is unexpected length: 8. This string must be in
>>>>> MM/DD/YYYY format. No other format is allowed and no additional information
>>>>> may be included. See field description in the SMBIOS specification.
>>>>>
>>>>> Base on SMBIOS spec v3.7.0:
>>>>>
>>>>> 08h 2.0+ BIOS Release Date BYTE STRING
>>>>> String number of the BIOS release date. The date
>>>>> string, if supplied, is in either mm/dd/yy or
>>>>> mm/dd/yyyy format. If the year portion of the string
>>>>> is two digits, the year is assumed to be 19yy.
>>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS
>>>>> version 2.3 and later.
>>>>>
>>>>> So, let's tweek the fallback release date again.
>>>>>
>>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
>>>>> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
>>>>> ---
>>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>> index 0ca3776045..e929da6b81 100644
>>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>> @@ -160,7 +160,7 @@ InstallAllStructures (
>>>>> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
>>>>> DateLen = StrLen (DateStr);
>>>>> if (DateLen < 3) {
>>>>> - DateStr = L"2/2/2022";
>>>>> + DateStr = L"02/02/2022";
>>>>> DateLen = StrLen (DateStr);
>>>>> }
>>>>>
>>>>
>>>> Are you proposing this as an important (but low risk) bugfix that might
>>>> qualify for the freeze(s)? If so, please loop in Liming and Mike.
>>>>
>>>
>>> hm... What does freeze mean?
>>>
>>
>> ah... You mean soft feature freeze for edk2-stable202402.
>>
>> Hi Liming, Michael,
>>
>> This change is important but low risk. Could you please consider to add it
>> to edk2-stable202402 release?
>>
>> Thanks a lot!
>> Joey Lee
>
> This patch is not in edk2-stable202402. Will it to be merged to next release?
Thanks for the reminder, and sorry about the delay!
Merged as commit 2a0d4a2641a7, via
<https://github.com/tianocore/edk2/pull/5441>.
For future contributions: please run PatchCheck.py on the patch series
before formatting and posting it (better yet, submit a personal CI build
PR).
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116356): https://edk2.groups.io/g/devel/message/116356
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-03-05 8:53 ` Laszlo Ersek
@ 2024-03-07 9:04 ` joeyli via groups.io
2024-03-07 11:23 ` Laszlo Ersek
0 siblings, 1 reply; 12+ messages in thread
From: joeyli via groups.io @ 2024-03-07 9:04 UTC (permalink / raw)
To: Laszlo Ersek
Cc: devel, Liming, Michael D Kinney, joeyli.kernel, Gerd Hoffmann,
Jiewen Yao, Jordan Justen, Pawel Polawski, Oliver Steffen,
Ard Biesheuvel, ruifeng.gao
Hi Laszlo,
On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote:
> On 3/4/24 12:37, joeyli via groups.io wrote:
> > Hi,
> >
> > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote:
> >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
> >>> Hi Laszlo,
> >>>
> >>> First, thanks for your review!
> >>>
> >>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> >>>> On 2/4/24 10:29, Lee, Chun-Yi wrote:
> >>>>> In case PcdFirmwareReleaseDateString is not set use a valid date
> >>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft
> >>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> >>>>> the error message:
> >>>>>
> >>>>> BIOS Release Date string is unexpected length: 8. This string must be in
> >>>>> MM/DD/YYYY format. No other format is allowed and no additional information
> >>>>> may be included. See field description in the SMBIOS specification.
> >>>>>
> >>>>> Base on SMBIOS spec v3.7.0:
> >>>>>
> >>>>> 08h 2.0+ BIOS Release Date BYTE STRING
> >>>>> String number of the BIOS release date. The date
> >>>>> string, if supplied, is in either mm/dd/yy or
> >>>>> mm/dd/yyyy format. If the year portion of the string
> >>>>> is two digits, the year is assumed to be 19yy.
> >>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS
> >>>>> version 2.3 and later.
> >>>>>
> >>>>> So, let's tweek the fallback release date again.
> >>>>>
> >>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> >>>>> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> >>>>> ---
> >>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> >>>>> index 0ca3776045..e929da6b81 100644
> >>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> >>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> >>>>> @@ -160,7 +160,7 @@ InstallAllStructures (
> >>>>> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> >>>>> DateLen = StrLen (DateStr);
> >>>>> if (DateLen < 3) {
> >>>>> - DateStr = L"2/2/2022";
> >>>>> + DateStr = L"02/02/2022";
> >>>>> DateLen = StrLen (DateStr);
> >>>>> }
> >>>>>
> >>>>
> >>>> Are you proposing this as an important (but low risk) bugfix that might
> >>>> qualify for the freeze(s)? If so, please loop in Liming and Mike.
> >>>>
> >>>
> >>> hm... What does freeze mean?
> >>>
> >>
> >> ah... You mean soft feature freeze for edk2-stable202402.
> >>
> >> Hi Liming, Michael,
> >>
> >> This change is important but low risk. Could you please consider to add it
> >> to edk2-stable202402 release?
> >>
> >> Thanks a lot!
> >> Joey Lee
> >
> > This patch is not in edk2-stable202402. Will it to be merged to next release?
>
> Thanks for the reminder, and sorry about the delay!
>
> Merged as commit 2a0d4a2641a7, via
> <https://github.com/tianocore/edk2/pull/5441>.
Thanks for your review and merge!
>
> For future contributions: please run PatchCheck.py on the patch series
> before formatting and posting it (better yet, submit a personal CI build
> PR).
>
For 'submit personal CI build PR', I was created a pull requests on github:
https://github.com/tianocore/edk2/pull/5349
Is it the right approach for triggering a CI build PR?
Thanks a lot!
Joey Lee
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116478): https://edk2.groups.io/g/devel/message/116478
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
2024-03-07 9:04 ` joeyli via groups.io
@ 2024-03-07 11:23 ` Laszlo Ersek
0 siblings, 0 replies; 12+ messages in thread
From: Laszlo Ersek @ 2024-03-07 11:23 UTC (permalink / raw)
To: devel, jlee
Cc: Liming, Michael D Kinney, joeyli.kernel, Gerd Hoffmann,
Jiewen Yao, Jordan Justen, Pawel Polawski, Oliver Steffen,
Ard Biesheuvel, ruifeng.gao
On 3/7/24 10:04, joeyli via groups.io wrote:
> Hi Laszlo,
>
> On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote:
>> On 3/4/24 12:37, joeyli via groups.io wrote:
>>> Hi,
>>>
>>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote:
>>>> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
>>>>> Hi Laszlo,
>>>>>
>>>>> First, thanks for your review!
>>>>>
>>>>> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
>>>>>> On 2/4/24 10:29, Lee, Chun-Yi wrote:
>>>>>>> In case PcdFirmwareReleaseDateString is not set use a valid date
>>>>>>> as fallback. But the default valid date can _NOT_ pass the Microsoft
>>>>>>> SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
>>>>>>> the error message:
>>>>>>>
>>>>>>> BIOS Release Date string is unexpected length: 8. This string must be in
>>>>>>> MM/DD/YYYY format. No other format is allowed and no additional information
>>>>>>> may be included. See field description in the SMBIOS specification.
>>>>>>>
>>>>>>> Base on SMBIOS spec v3.7.0:
>>>>>>>
>>>>>>> 08h 2.0+ BIOS Release Date BYTE STRING
>>>>>>> String number of the BIOS release date. The date
>>>>>>> string, if supplied, is in either mm/dd/yy or
>>>>>>> mm/dd/yyyy format. If the year portion of the string
>>>>>>> is two digits, the year is assumed to be 19yy.
>>>>>>> NOTE: The mm/dd/yyyy format is required for SMBIOS
>>>>>>> version 2.3 and later.
>>>>>>>
>>>>>>> So, let's tweek the fallback release date again.
>>>>>>>
>>>>>>> Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
>>>>>>> Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
>>>>>>> ---
>>>>>>> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> index 0ca3776045..e929da6b81 100644
>>>>>>> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>>>>>>> @@ -160,7 +160,7 @@ InstallAllStructures (
>>>>>>> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
>>>>>>> DateLen = StrLen (DateStr);
>>>>>>> if (DateLen < 3) {
>>>>>>> - DateStr = L"2/2/2022";
>>>>>>> + DateStr = L"02/02/2022";
>>>>>>> DateLen = StrLen (DateStr);
>>>>>>> }
>>>>>>>
>>>>>>
>>>>>> Are you proposing this as an important (but low risk) bugfix that might
>>>>>> qualify for the freeze(s)? If so, please loop in Liming and Mike.
>>>>>>
>>>>>
>>>>> hm... What does freeze mean?
>>>>>
>>>>
>>>> ah... You mean soft feature freeze for edk2-stable202402.
>>>>
>>>> Hi Liming, Michael,
>>>>
>>>> This change is important but low risk. Could you please consider to add it
>>>> to edk2-stable202402 release?
>>>>
>>>> Thanks a lot!
>>>> Joey Lee
>>>
>>> This patch is not in edk2-stable202402. Will it to be merged to next release?
>>
>> Thanks for the reminder, and sorry about the delay!
>>
>> Merged as commit 2a0d4a2641a7, via
>> <https://github.com/tianocore/edk2/pull/5441>.
>
> Thanks for your review and merge!
>
>>
>> For future contributions: please run PatchCheck.py on the patch series
>> before formatting and posting it (better yet, submit a personal CI build
>> PR).
>>
>
> For 'submit personal CI build PR', I was created a pull requests on github:
> https://github.com/tianocore/edk2/pull/5349
>
> Is it the right approach for triggering a CI build PR?
Yes, it is.
... I think the enforcement of Cc: tags in commit messages may have been
introduced later than your PR. New PRs like yours will catch missing Cc:
tags.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116483): https://edk2.groups.io/g/devel/message/116483
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-03-07 11:23 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 16:32 [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Lee, Chun-Yi
2024-02-04 9:35 ` joeyli via groups.io
-- strict thread matches above, loose matches on Subject: below --
2024-02-04 9:29 Lee, Chun-Yi
2024-02-04 9:38 ` joeyli via groups.io
2024-02-05 7:31 ` Laszlo Ersek
2024-02-05 16:41 ` Laszlo Ersek
2024-02-07 7:55 ` joeyli via groups.io
2024-02-07 8:02 ` joeyli via groups.io
[not found] ` <17B185EB8F3EA51B.19081@groups.io>
2024-03-04 11:37 ` joeyli via groups.io
2024-03-05 8:53 ` Laszlo Ersek
2024-03-07 9:04 ` joeyli via groups.io
2024-03-07 11:23 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox