From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B9E847803CF for ; Mon, 5 Feb 2024 00:54:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hz1RFsKM/x1xyJs+ckEls88hc0067jbkWiv30sVcDbo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe; s=20140610; t=1707094492; v=1; b=jzfENeTGwMSMtbnz8dQwAPY5LgApoSXPe/knQn/UxSo1MY9hR8FSp3yPjlOzMjgw9eXM2DZp OcWuPzxDlmlK8OfWgIkpaH3muCl4pd0CL4B35TXx6ydjC7aWyZTr2hwTQHJCKYRt1bCZabYVPoh zGLRKmgx/hC8xET8+LGos5yY= X-Received: by 127.0.0.2 with SMTP id QxTbYY7687511x1tlSoTwVpi; Sun, 04 Feb 2024 16:54:52 -0800 X-Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web10.35683.1707038957926255799 for ; Sun, 04 Feb 2024 01:29:17 -0800 X-Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-296717ccc2aso355020a91.1 for ; Sun, 04 Feb 2024 01:29:17 -0800 (PST) X-Gm-Message-State: Tu1oNfhUvvsfHnndCDktaKkIx7686176AA= X-Google-Smtp-Source: AGHT+IF8438QgpG9SGnaaildfEE6YmdBz+4bwo2RBbpkwkctwzM1QahbVI2zxVjYS7YKeO6voELF+Q== X-Received: by 2002:a17:90a:644f:b0:296:72ff:4662 with SMTP id y15-20020a17090a644f00b0029672ff4662mr3131386pjm.15.1707038957031; Sun, 04 Feb 2024 01:29:17 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWiomqQ6ybv8T9gNdUmZSVUGLhF14SpdsxNVUlS7ElIzn9Ho4ChtbrojiTBUfTcMbBAyvmmfWtqxnt2K8JorZSVvGLqRaeTgKpgK37G9n+KPFM4EtuZ9ElRBFG/DkVbj7xe4GyX/KvZqmX1mgxNjs/swkCWqj91ko0tV7cRw/AVUNPZb5YFRgCzNedhUhVLYm+Lg1Zis0Qb2JlGpMKVHPRNQ21H4cQFBjEUtMcWC2cYAW1tf6YG0QAkvacw4E+/47jELLe/BEoyFPv8 X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id l6-20020a17090a150600b002966a13f2e9sm2451418pja.37.2024.02.04.01.29.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2024 01:29:16 -0800 (PST) From: "Lee, Chun-Yi" X-Google-Original-From: "Lee, Chun-Yi" To: devel@edk2.groups.io Cc: Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com, "Lee, Chun-Yi" Subject: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Date: Sun, 4 Feb 2024 17:29:14 +0800 Message-Id: <20240204092914.29813-1-jlee@suse.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joeyli.kernel@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jzfENeTG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io In case PcdFirmwareReleaseDateString is not set use a valid date as fallback. But the default valid date can _NOT_ pass the Microsoft SVVP test "Check SMBIOS Table Specific Requirements". The test emitted the error message: BIOS Release Date string is unexpected length: 8. This string must be in MM/DD/YYYY format. No other format is allowed and no additional information may be included. See field description in the SMBIOS specification. Base on SMBIOS spec v3.7.0: 08h 2.0+ BIOS Release Date BYTE STRING String number of the BIOS release date. The date string, if supplied, is in either mm/dd/yy or mm/dd/yyyy format. If the year portion of the string is two digits, the year is assumed to be 19yy. NOTE: The mm/dd/yyyy format is required for SMBIOS version 2.3 and later. So, let's tweek the fallback release date again. Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] Signed-off-by: "Lee, Chun-Yi" --- OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c index 0ca3776045..e929da6b81 100644 --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c @@ -160,7 +160,7 @@ InstallAllStructures ( DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); DateLen = StrLen (DateStr); if (DateLen < 3) { - DateStr = L"2/2/2022"; + DateStr = L"02/02/2022"; DateLen = StrLen (DateStr); } -- 2.12.3 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115093): https://edk2.groups.io/g/devel/message/115093 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-