From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 86BD27803D1 for ; Sun, 4 Feb 2024 09:36:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2NKXk5LipCUV0t12GQr2nDXp/NKAoBod67Ol/5/j5KE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707039361; v=1; b=FhMpBIknq47tWl3fKu/ghdqHxP/TvBAUtX7JToN+SDfoozhCDr8NaeBoCb6liBoa0dSlRoN3 cozqlElnOp6UfpjJLgIS6TuUifh0XNCvHKDtzCIy+TjpZCBXOoXpsX7I1ZeldBCNIyKaz8CFs5B E0faqacngNBhorsDtuJNgQHY= X-Received: by 127.0.0.2 with SMTP id 7QQtYY7687511xJJ1WiT2Dha; Sun, 04 Feb 2024 01:36:01 -0800 X-Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mx.groups.io with SMTP id smtpd.web10.35743.1707039360025346610 for ; Sun, 04 Feb 2024 01:36:00 -0800 X-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2cf45305403so42009871fa.2 for ; Sun, 04 Feb 2024 01:35:59 -0800 (PST) X-Gm-Message-State: mt9LwdaG3WfwwiujIvEu0Z21x7686176AA= X-Google-Smtp-Source: AGHT+IFQ2VY1PlguFr/kBzmoJ33TGtd1ts6OqG6FIfQd2cb89KNiYriCvuo/zcq6SVCRMIHvbL5lyA== X-Received: by 2002:a2e:9dd3:0:b0:2d0:a873:2e95 with SMTP id x19-20020a2e9dd3000000b002d0a8732e95mr365665ljj.35.1707039357944; Sun, 04 Feb 2024 01:35:57 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVaM23so+icxxUG+ptPNk/hp0T4AZi/AWFnHuImIKMDXsAq2WlW4wv2rt7G8mpIMyMJo08Ag+TRUSqLuPdEVEp6ovCjI8njz8rTuG8cHkMBDaBDARfeOfpdpcATZiTkk6qWfH3WMwomrmGa7S6rTdkGuwJtWg2IRkpFZ3r6ZJAbA7BXPGHVz7VfPL3/dBd8n9u78LXxBD319Y/x3RlCdcQhbmRIpp+4eEa7aBvvuOcqz8gQvBNdHLpt6ODaKb3MJbkTaoP0B76KklJ0sPXbfA== X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id q18-20020aa79832000000b006d0a29ad0aasm4501662pfl.5.2024.02.04.01.35.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2024 01:35:57 -0800 (PST) Date: Sun, 4 Feb 2024 17:35:53 +0800 From: "joeyli via groups.io" To: "Lee, Chun-Yi" Cc: devel@edk2.groups.io, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240204093553.GO21608@linux-l9pv.suse> References: <20240202163201.18819-1-jlee@suse.com> MIME-Version: 1.0 In-Reply-To: <20240202163201.18819-1-jlee@suse.com> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FhMpBIkn; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi experts, On Sat, Feb 03, 2024 at 12:32:01AM +0800, Lee, Chun-Yi wrote: > In case PcdFirmwareReleaseDateString is not set use a valid date > as fallback. But the default valid date can _NOT_ pass the Microsoft > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > the error message: > > BIOS Release Date string is unexpected length: 8. This string must be in > MM/DD/YYYY format. No other format is allowed and no additional information > may be included. See field description in the SMBIOS specification. > > Base on SMBIOS spec v3.7.0: > > 08h 2.0+ BIOS Release Date BYTE STRING > String number of the BIOS release date. The date > string, if supplied, is in either mm/dd/yy or > mm/dd/yyyy format. If the year portion of the string > is two digits, the year is assumed to be 19yy. > NOTE: The mm/dd/yyyy format is required for SMBIOS > version 2.3 and later. > > So, let's tweek the fallback release date again. > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > Signed-off-by: "Lee, Chun-Yi" > --- > CryptoPkg/Library/OpensslLib/openssl | 2 +- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl > index de90e54bbe..830bf8e1e4 160000 > --- a/CryptoPkg/Library/OpensslLib/openssl > +++ b/CryptoPkg/Library/OpensslLib/openssl > @@ -1 +1 @@ > -Subproject commit de90e54bbe82e5be4fb9608b6f5c308bb837d355 > +Subproject commit 830bf8e1e4749ad65c51b6a1d0d769ae689404ba Sorry for I touched openssl commit when generating this patch. I will re-send patch again. Joey Lee > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index 0ca3776045..e929da6b81 100644 > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -160,7 +160,7 @@ InstallAllStructures ( > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > DateLen = StrLen (DateStr); > if (DateLen < 3) { > - DateStr = L"2/2/2022"; > + DateStr = L"02/02/2022"; > DateLen = StrLen (DateStr); > } > > -- > 2.12.3 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115082): https://edk2.groups.io/g/devel/message/115082 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-