From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7FB55AC09B1 for ; Sun, 4 Feb 2024 09:38:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wHlozOHrfEwqAY0Rh+tcCg555BxWyXQadkyjFs+ifJI=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707039513; v=1; b=ITqQrIfNyw74RPhnpZ8e7P1EC6mlPLCAzxIHaxfo5BFb97Q/92WqhktpNODObhq0/fPzVTVq f0ppv39cDTeNou/b7UTCXlqNJVLHkB6ien0BlNJUz40BHJKh457Kn0ZKP2RigfOqc+njLeqb4cs 6O2hLTu3k0lUPXkFXlvcnLrc= X-Received: by 127.0.0.2 with SMTP id Y2EZYY7687511xy8RahLRoMo; Sun, 04 Feb 2024 01:38:33 -0800 X-Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.groups.io with SMTP id smtpd.web11.35564.1707039512071349598 for ; Sun, 04 Feb 2024 01:38:32 -0800 X-Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40fb3b5893eso28599915e9.0 for ; Sun, 04 Feb 2024 01:38:31 -0800 (PST) X-Gm-Message-State: VFZ2KgAifblXjkJb1WG1SYQIx7686176AA= X-Google-Smtp-Source: AGHT+IGjmTyAdoGFPTz7XNqhUj0KtM8EX9cQAQvYhnphwdNnNKps4RXhWP2hcxiJizcSuh7dPcll4A== X-Received: by 2002:a05:600c:46cb:b0:40f:bdf1:58cc with SMTP id q11-20020a05600c46cb00b0040fbdf158ccmr2416022wmo.33.1707039510499; Sun, 04 Feb 2024 01:38:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXTchSFV2xg2uwysJX7VdNVVxF9NYeo9A4nfmRUbCJNJTGC7Tu2B5bSj7xf3FPfgNHzINHMki+d3O1E+PDFaq7+Ud7WBOY9YiAfi0QY8iOGTWHG6VUAwLc3Voq1m9DaXsKBP9aeRA3PcNxxI1RUXc5wf2D7En3djUDrnX5VT5cJJHwH6Y9/xE7ZRwUyxBsXObnoq45NUM9Ii/dPM3cwhq5itpD1ObUG/mLmD3L5S17izrodseN21/gEsx1TfM5nu0ijmTBWFsVaUOEvFTqQcA== X-Received: from linux-691t ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id l30-20020a05600c1d1e00b0040eee852a3dsm5200257wms.10.2024.02.04.01.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 01:38:30 -0800 (PST) Date: Sun, 4 Feb 2024 17:38:22 +0800 From: "joeyli via groups.io" To: "Lee, Chun-Yi" Cc: devel@edk2.groups.io, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240204093822.GA1668@linux-691t> References: <20240204092914.29813-1-jlee@suse.com> MIME-Version: 1.0 In-Reply-To: <20240204092914.29813-1-jlee@suse.com> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ITqQrIfN; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi experts, On Sun, Feb 04, 2024 at 05:29:14PM +0800, Lee, Chun-Yi wrote: > In case PcdFirmwareReleaseDateString is not set use a valid date > as fallback. But the default valid date can _NOT_ pass the Microsoft > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > the error message: > > BIOS Release Date string is unexpected length: 8. This string must be in > MM/DD/YYYY format. No other format is allowed and no additional information > may be included. See field description in the SMBIOS specification. > > Base on SMBIOS spec v3.7.0: > > 08h 2.0+ BIOS Release Date BYTE STRING > String number of the BIOS release date. The date > string, if supplied, is in either mm/dd/yy or > mm/dd/yyyy format. If the year portion of the string > is two digits, the year is assumed to be 19yy. > NOTE: The mm/dd/yyyy format is required for SMBIOS > version 2.3 and later. > > So, let's tweek the fallback release date again. > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > Signed-off-by: "Lee, Chun-Yi" I also filed a pull request on github against this patch: https://github.com/tianocore/edk2/pull/5343 Thanks a lot! Joey Lee > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index 0ca3776045..e929da6b81 100644 > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -160,7 +160,7 @@ InstallAllStructures ( > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > DateLen = StrLen (DateStr); > if (DateLen < 3) { > - DateStr = L"2/2/2022"; > + DateStr = L"02/02/2022"; > DateLen = StrLen (DateStr); > } > > -- > 2.12.3 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115083): https://edk2.groups.io/g/devel/message/115083 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-