[edk2-devel] [PATCH 02/11] OvmfPkg/RiscVVirt/Sec: don't #include <Library/PeimEntryPoint.h>

["Laszlo Ersek" <lersek@redhat.com>]

"OvmfPkg/RiscVVirt/Sec/Memory.c" #includes <Library/PeimEntryPoint.h>.
This exposes a declaration of ProcessLibraryConstructorList() that is
bogus for a SEC module in general, but harmless (unused) in this
particular instance ("Memory.c" does not call
ProcessLibraryConstructorList(), and "SecMain.c", which does, gets the
proper prototype from the manual declaration in "SecMain.h", not from
<Library/PeimEntryPoint.h>).

However, after a subsequent patch in this series starts generating the
right prototype for SEC ProcessLibraryConstructorList(), just the
inclusion of <Library/PeimEntryPoint.h> will cause a build error in
"Memory.c" ("conflicting prototypes"). Remove the #include directive now.

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/OvmfPkg/RiscVVirt/Sec/Memory.c b/OvmfPkg/RiscVVirt/Sec/Memory.c
index 7c6d920bd2a6..14c9569c78d4 100644
--- a/OvmfPkg/RiscVVirt/Sec/Memory.c
+++ b/OvmfPkg/RiscVVirt/Sec/Memory.c
@@ -25,7 +25,6 @@ Module Name:
 #include <Library/HobLib.h>
 #include <Library/IoLib.h>
 #include <Library/PcdLib.h>
-#include <Library/PeimEntryPoint.h>
 #include <Library/ResourcePublicationLib.h>
 #include <Library/BaseRiscVSbiLib.h>
 #include <Register/RiscV64/RiscVEncoding.h>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115196): https://edk2.groups.io/g/devel/message/115196
Mute This Topic: https://groups.io/mt/104210773/7686176
Mute #include:https://edk2.groups.io/g/devel/mutehashtag/include
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-