Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

["joeyli via groups.io" <jlee=suse.com@groups.io>]

Hi Laszlo,

First, thanks for your review!

On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> On 2/4/24 10:29, Lee, Chun-Yi wrote:
> > In case PcdFirmwareReleaseDateString is not set use a valid date
> > as fallback. But the default valid date can _NOT_ pass the Microsoft
> > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> > the error message:
> > 
> > BIOS Release Date string is unexpected length: 8. This string must be in
> > MM/DD/YYYY format. No other format is allowed and no additional information
> > may be included. See field description in the SMBIOS specification.
> > 
> > Base on SMBIOS spec v3.7.0:
> > 
> > 08h     2.0+    BIOS Release Date       BYTE    STRING
> > String number of the BIOS release date. The date
> > string, if supplied, is in either mm/dd/yy or
> > mm/dd/yyyy format. If the year portion of the string
> > is two digits, the year is assumed to be 19yy.
> > NOTE: The mm/dd/yyyy format is required for SMBIOS
> > version 2.3 and later.
> > 
> > So, let's tweek the fallback release date again.
> > 
> > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > ---
> >  OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > index 0ca3776045..e929da6b81 100644
> > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > @@ -160,7 +160,7 @@ InstallAllStructures (
> >      DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> >      DateLen = StrLen (DateStr);
> >      if (DateLen < 3) {
> > -      DateStr = L"2/2/2022";
> > +      DateStr = L"02/02/2022";
> >        DateLen = StrLen (DateStr);
> >      }
> >  
> 
> Are you proposing this as an important (but low risk) bugfix that might
> qualify for the freeze(s)? If so, please loop in Liming and Mike.
>

hm... What does freeze mean? 

Thanks!
Joey Lee 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115232): https://edk2.groups.io/g/devel/message/115232
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-