From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 00B9D941472 for ; Wed, 7 Feb 2024 07:55:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7z+uRrrCEEkQzikE/uWA34CNyLR4uzOrUYGrXM8nb6o=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707292557; v=1; b=H9/HPjwDTsXJDvXmwk1ciOk+pZTsMRDnpo3bD4x8NrefNXkG8KS6lJEPcysQjyX22l3vNqUq /G4FTsNht/KEDNgZE8WjM0tW35z7TLeLBSAm5KStNkmAjFry1N8V7BI4MC61wlIfUmAL0pAjzhB ALb2bKhpoC3pp5aqKeJUczkE= X-Received: by 127.0.0.2 with SMTP id ximTYY7687511xBXRq4C2m53; Tue, 06 Feb 2024 23:55:57 -0800 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.15607.1707292556381447411 for ; Tue, 06 Feb 2024 23:55:56 -0800 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d0512f6e32so4068441fa.1 for ; Tue, 06 Feb 2024 23:55:56 -0800 (PST) X-Gm-Message-State: c6hQkwme4FOgea6gmoiUsuUdx7686176AA= X-Google-Smtp-Source: AGHT+IHqnc5y2sXYd7gf4EeTgp5bo5ErRlQ9gomLR3beJahEAIaUTKMIbn7hF3VvXkEhDFcANEk/hA== X-Received: by 2002:a05:651c:19a9:b0:2d0:c996:7c99 with SMTP id bx41-20020a05651c19a900b002d0c9967c99mr688492ljb.51.1707292554478; Tue, 06 Feb 2024 23:55:54 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWNWfo7sZZUrUBH7+rvhgSoQX8NvydEFSCJ4u4niXRb2aQu7Dpix+CvBSylTfgDOCmFVpDMRlU+ceZMVZuAuCjWPKdxS5GWs+9pIlqH0QLLTD889uL7MdCHe2FbGQM8/qVJIUlEqrTtrBcnDFwBBzcRxLuQdC1fl+EwOgA0OC3IFl3bemnCDJFsC0CP7/OR6Rw5AGY+YVxGpldD10e+HG+vgMTYNf9apCsQ8f1hp30Ka9k+cB/sjIhwpIsVXRBh6N1Dnra49alguNxL8PEciIDYVAaFz3Nr5x+FRYkw+RP67VPsGIvJ4QE= X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id bz3-20020a056a02060300b005d66caee3d0sm718121pgb.22.2024.02.06.23.55.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 23:55:53 -0800 (PST) Date: Wed, 7 Feb 2024 15:55:49 +0800 From: "joeyli via groups.io" To: Laszlo Ersek Cc: devel@edk2.groups.io, joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240207075549.GZ21608@linux-l9pv.suse> References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> MIME-Version: 1.0 In-Reply-To: <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="H9/HPjwD"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Laszlo, First, thanks for your review! On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: > On 2/4/24 10:29, Lee, Chun-Yi wrote: > > In case PcdFirmwareReleaseDateString is not set use a valid date > > as fallback. But the default valid date can _NOT_ pass the Microsoft > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > > the error message: > > > > BIOS Release Date string is unexpected length: 8. This string must be in > > MM/DD/YYYY format. No other format is allowed and no additional information > > may be included. See field description in the SMBIOS specification. > > > > Base on SMBIOS spec v3.7.0: > > > > 08h 2.0+ BIOS Release Date BYTE STRING > > String number of the BIOS release date. The date > > string, if supplied, is in either mm/dd/yy or > > mm/dd/yyyy format. If the year portion of the string > > is two digits, the year is assumed to be 19yy. > > NOTE: The mm/dd/yyyy format is required for SMBIOS > > version 2.3 and later. > > > > So, let's tweek the fallback release date again. > > > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > > Signed-off-by: "Lee, Chun-Yi" > > --- > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > index 0ca3776045..e929da6b81 100644 > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > @@ -160,7 +160,7 @@ InstallAllStructures ( > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > > DateLen = StrLen (DateStr); > > if (DateLen < 3) { > > - DateStr = L"2/2/2022"; > > + DateStr = L"02/02/2022"; > > DateLen = StrLen (DateStr); > > } > > > > Are you proposing this as an important (but low risk) bugfix that might > qualify for the freeze(s)? If so, please loop in Liming and Mike. > hm... What does freeze mean? Thanks! Joey Lee -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115232): https://edk2.groups.io/g/devel/message/115232 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-