From: "joeyli via groups.io" <jlee=suse.com@groups.io>
To: Laszlo Ersek <lersek@redhat.com>,
Gao@linux-l9pv.suse, Liming <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>
Cc: devel@edk2.groups.io, joeyli.kernel@gmail.com,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Oliver Steffen <osteffen@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
ruifeng.gao@intel.com
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
Date: Wed, 7 Feb 2024 16:02:52 +0800 [thread overview]
Message-ID: <20240207080252.GA21608@linux-l9pv.suse> (raw)
In-Reply-To: <20240207075549.GZ21608@linux-l9pv.suse>
On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote:
> Hi Laszlo,
>
> First, thanks for your review!
>
> On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote:
> > On 2/4/24 10:29, Lee, Chun-Yi wrote:
> > > In case PcdFirmwareReleaseDateString is not set use a valid date
> > > as fallback. But the default valid date can _NOT_ pass the Microsoft
> > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
> > > the error message:
> > >
> > > BIOS Release Date string is unexpected length: 8. This string must be in
> > > MM/DD/YYYY format. No other format is allowed and no additional information
> > > may be included. See field description in the SMBIOS specification.
> > >
> > > Base on SMBIOS spec v3.7.0:
> > >
> > > 08h 2.0+ BIOS Release Date BYTE STRING
> > > String number of the BIOS release date. The date
> > > string, if supplied, is in either mm/dd/yy or
> > > mm/dd/yyyy format. If the year portion of the string
> > > is two digits, the year is assumed to be 19yy.
> > > NOTE: The mm/dd/yyyy format is required for SMBIOS
> > > version 2.3 and later.
> > >
> > > So, let's tweek the fallback release date again.
> > >
> > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
> > > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
> > > ---
> > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > index 0ca3776045..e929da6b81 100644
> > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > > @@ -160,7 +160,7 @@ InstallAllStructures (
> > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> > > DateLen = StrLen (DateStr);
> > > if (DateLen < 3) {
> > > - DateStr = L"2/2/2022";
> > > + DateStr = L"02/02/2022";
> > > DateLen = StrLen (DateStr);
> > > }
> > >
> >
> > Are you proposing this as an important (but low risk) bugfix that might
> > qualify for the freeze(s)? If so, please loop in Liming and Mike.
> >
>
> hm... What does freeze mean?
>
ah... You mean soft feature freeze for edk2-stable202402.
Hi Liming, Michael,
This change is important but low risk. Could you please consider to add it
to edk2-stable202402 release?
Thanks a lot!
Joey Lee
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115233): https://edk2.groups.io/g/devel/message/115233
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-07 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 9:29 [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Lee, Chun-Yi
2024-02-04 9:38 ` joeyli via groups.io
2024-02-05 7:31 ` Laszlo Ersek
2024-02-05 16:41 ` Laszlo Ersek
2024-02-07 7:55 ` joeyli via groups.io
2024-02-07 8:02 ` joeyli via groups.io [this message]
[not found] ` <17B185EB8F3EA51B.19081@groups.io>
2024-03-04 11:37 ` joeyli via groups.io
2024-03-05 8:53 ` Laszlo Ersek
2024-03-07 9:04 ` joeyli via groups.io
2024-03-07 11:23 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2024-02-02 16:32 Lee, Chun-Yi
2024-02-04 9:35 ` joeyli via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207080252.GA21608@linux-l9pv.suse \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox