From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 65192AC0FFB for ; Wed, 7 Feb 2024 08:03:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UjyjCOLLyA0Becr7pQzlChtKeNK5xEXF49No+ddEauU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707292980; v=1; b=ApV84CDoJE4PFKjEedYy/iD8IBlEGgwUg+T2wiUQfwCIeHBBTvscuI6sGQJQrqyLgHPQ4g4+ 48/6P8LdD4SXJPmfu8oAXpTSC0espS31SwE9v5pEB1ksF9fy90ShEs9c7qSY025jt1bhRoUCZMd t+4oP2PkDkPc4nFoYbTy8I/M= X-Received: by 127.0.0.2 with SMTP id kRi5YY7687511xh5yaKjo1ht; Wed, 07 Feb 2024 00:03:00 -0800 X-Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mx.groups.io with SMTP id smtpd.web11.15684.1707292979947770759 for ; Wed, 07 Feb 2024 00:03:00 -0800 X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2cf5917f049so3639251fa.2 for ; Wed, 07 Feb 2024 00:02:59 -0800 (PST) X-Gm-Message-State: bRY55grNdraFb9Ze9RRpYx9Xx7686176AA= X-Google-Smtp-Source: AGHT+IE7GC5t/FejvVN27/1OvUaVvr/gQyg3p0QO/Uo20EVxbknrH5V46ZhhP9DN5axU1zui8QgF+g== X-Received: by 2002:a2e:b046:0:b0:2d0:cbd4:5a91 with SMTP id d6-20020a2eb046000000b002d0cbd45a91mr330376ljl.45.1707292977804; Wed, 07 Feb 2024 00:02:57 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWirrIOcvafcSElYROKKIJmMN9Y+JsEoOeMPkZb1Pu7ZbTvdQFdN68cN6E1V4CVGgEX5r2cjP5GPIpUn01WQ4djGbLnICmKeOEGwKFhIPjN9I97afEEFmApGo+XlqDvKwdbAMxkEDujeZZnpU//ubtRbI0b8w0bpPCNb3Y2niF2vbze9RuOCGgRIz3iFl6fzDa7YA8XssvbPpmPiYkjWJqiN91YlkCfi5J+83TPCjxsv9snCaai4pvODCOUzN52BqSKDR8aV5BCbz6pIbzEOuUWP0MdVAbCL0rTq0thWH0ZpsZrB7AjTXwmbMhSQh1DlzbynQ/LEsEUBCiUMp5Ok02RjSset22RS7QOX4MNhh6PsR5YszqhVK6yyRKFOpBsAuKOIDTXMOf6y+G3kWERM6G+v70= X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id n29-20020a056a000d5d00b006e0322f072asm832490pfv.35.2024.02.07.00.02.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2024 00:02:57 -0800 (PST) Date: Wed, 7 Feb 2024 16:02:52 +0800 From: "joeyli via groups.io" To: Laszlo Ersek , Gao@linux-l9pv.suse, Liming , Michael D Kinney Cc: devel@edk2.groups.io, joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240207080252.GA21608@linux-l9pv.suse> References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> <20240207075549.GZ21608@linux-l9pv.suse> MIME-Version: 1.0 In-Reply-To: <20240207075549.GZ21608@linux-l9pv.suse> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ApV84CDo; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: > Hi Laszlo, > > First, thanks for your review! > > On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: > > On 2/4/24 10:29, Lee, Chun-Yi wrote: > > > In case PcdFirmwareReleaseDateString is not set use a valid date > > > as fallback. But the default valid date can _NOT_ pass the Microsoft > > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > > > the error message: > > > > > > BIOS Release Date string is unexpected length: 8. This string must be in > > > MM/DD/YYYY format. No other format is allowed and no additional information > > > may be included. See field description in the SMBIOS specification. > > > > > > Base on SMBIOS spec v3.7.0: > > > > > > 08h 2.0+ BIOS Release Date BYTE STRING > > > String number of the BIOS release date. The date > > > string, if supplied, is in either mm/dd/yy or > > > mm/dd/yyyy format. If the year portion of the string > > > is two digits, the year is assumed to be 19yy. > > > NOTE: The mm/dd/yyyy format is required for SMBIOS > > > version 2.3 and later. > > > > > > So, let's tweek the fallback release date again. > > > > > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > > > Signed-off-by: "Lee, Chun-Yi" > > > --- > > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > index 0ca3776045..e929da6b81 100644 > > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > @@ -160,7 +160,7 @@ InstallAllStructures ( > > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > > > DateLen = StrLen (DateStr); > > > if (DateLen < 3) { > > > - DateStr = L"2/2/2022"; > > > + DateStr = L"02/02/2022"; > > > DateLen = StrLen (DateStr); > > > } > > > > > > > Are you proposing this as an important (but low risk) bugfix that might > > qualify for the freeze(s)? If so, please loop in Liming and Mike. > > > > hm... What does freeze mean? > ah... You mean soft feature freeze for edk2-stable202402. Hi Liming, Michael, This change is important but low risk. Could you please consider to add it to edk2-stable202402 release? Thanks a lot! Joey Lee -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115233): https://edk2.groups.io/g/devel/message/115233 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-