public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
@ 2024-02-04  9:29 Lee, Chun-Yi
  2024-02-04  9:38 ` joeyli via groups.io
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Lee, Chun-Yi @ 2024-02-04  9:29 UTC (permalink / raw)
  To: devel
  Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
	Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi

In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. But the default valid date can _NOT_ pass the Microsoft
SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
the error message:

BIOS Release Date string is unexpected length: 8. This string must be in
MM/DD/YYYY format. No other format is allowed and no additional information
may be included. See field description in the SMBIOS specification.

Base on SMBIOS spec v3.7.0:

08h     2.0+    BIOS Release Date       BYTE    STRING
String number of the BIOS release date. The date
string, if supplied, is in either mm/dd/yy or
mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS
version 2.3 and later.

So, let's tweek the fallback release date again.

Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
 OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index 0ca3776045..e929da6b81 100644
--- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -160,7 +160,7 @@ InstallAllStructures (
     DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
     DateLen = StrLen (DateStr);
     if (DateLen < 3) {
-      DateStr = L"2/2/2022";
+      DateStr = L"02/02/2022";
       DateLen = StrLen (DateStr);
     }
 
-- 
2.12.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115093): https://edk2.groups.io/g/devel/message/115093
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again
@ 2024-02-02 16:32 Lee, Chun-Yi
  2024-02-04  9:35 ` joeyli via groups.io
  0 siblings, 1 reply; 12+ messages in thread
From: Lee, Chun-Yi @ 2024-02-02 16:32 UTC (permalink / raw)
  To: devel
  Cc: Gerd Hoffmann, Jiewen Yao, Jordan Justen, Pawel Polawski,
	Oliver Steffen, Ard Biesheuvel, ruifeng.gao, Lee, Chun-Yi

In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. But the default valid date can _NOT_ pass the Microsoft
SVVP test "Check SMBIOS Table Specific Requirements". The test emitted
the error message:

BIOS Release Date string is unexpected length: 8. This string must be in
MM/DD/YYYY format. No other format is allowed and no additional information
may be included. See field description in the SMBIOS specification.

Base on SMBIOS spec v3.7.0:

08h     2.0+    BIOS Release Date       BYTE    STRING
String number of the BIOS release date. The date
string, if supplied, is in either mm/dd/yy or
mm/dd/yyyy format. If the year portion of the string
is two digits, the year is assumed to be 19yy.
NOTE: The mm/dd/yyyy format is required for SMBIOS
version 2.3 and later.

So, let's tweek the fallback release date again.

Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327]
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
 CryptoPkg/Library/OpensslLib/openssl          | 2 +-
 OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
index de90e54bbe..830bf8e1e4 160000
--- a/CryptoPkg/Library/OpensslLib/openssl
+++ b/CryptoPkg/Library/OpensslLib/openssl
@@ -1 +1 @@
-Subproject commit de90e54bbe82e5be4fb9608b6f5c308bb837d355
+Subproject commit 830bf8e1e4749ad65c51b6a1d0d769ae689404ba
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index 0ca3776045..e929da6b81 100644
--- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -160,7 +160,7 @@ InstallAllStructures (
     DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
     DateLen = StrLen (DateStr);
     if (DateLen < 3) {
-      DateStr = L"2/2/2022";
+      DateStr = L"02/02/2022";
       DateLen = StrLen (DateStr);
     }
 
-- 
2.12.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115090): https://edk2.groups.io/g/devel/message/115090
Mute This Topic: https://groups.io/mt/104153758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-03-07 11:23 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04  9:29 [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Lee, Chun-Yi
2024-02-04  9:38 ` joeyli via groups.io
2024-02-05  7:31 ` Laszlo Ersek
2024-02-05 16:41 ` Laszlo Ersek
2024-02-07  7:55   ` joeyli via groups.io
2024-02-07  8:02     ` joeyli via groups.io
     [not found]     ` <17B185EB8F3EA51B.19081@groups.io>
2024-03-04 11:37       ` joeyli via groups.io
2024-03-05  8:53         ` Laszlo Ersek
2024-03-07  9:04           ` joeyli via groups.io
2024-03-07 11:23             ` Laszlo Ersek
  -- strict thread matches above, loose matches on Subject: below --
2024-02-02 16:32 Lee, Chun-Yi
2024-02-04  9:35 ` joeyli via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox