From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 690BBAC1A1A for ; Tue, 13 Feb 2024 19:41:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dhjx2/nLdG9xiwyxIFALZpuaeKzH5syPg5kdJwmB6SI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1707853270; v=1; b=TGvxiylvjg4fo55n4CYHPg7NeuZeqQD7FaEnLz7LIHgjXLxnr096opyqfd0NFisCZLPishyh bLTcyycwwmC78Bc8H65+nM9bGP1enSO3Wxntj2Mm6g7Kt0cv0z/XHe1t2yqVIhSVYu+QPTIQRiK 7pE+DPxOXFvjk05k38k5S1sY= X-Received: by 127.0.0.2 with SMTP id Aue1YY7687511xKQqxATtdE3; Tue, 13 Feb 2024 11:41:10 -0800 X-Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mx.groups.io with SMTP id smtpd.web10.22885.1707853269571709024 for ; Tue, 13 Feb 2024 11:41:09 -0800 X-Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d95d67ff45so35119405ad.2 for ; Tue, 13 Feb 2024 11:41:09 -0800 (PST) X-Gm-Message-State: HsTmOvTr40IDBjPLEFirsRyVx7686176AA= X-Google-Smtp-Source: AGHT+IEs5OH4Eg0MLAgdNOD0ixUDceoPT3g0mYcHzfKsUEcBc1EesyXCT2RVmjClsF/yykfei0KvZA== X-Received: by 2002:a17:902:8485:b0:1d9:8ddf:5fa0 with SMTP id c5-20020a170902848500b001d98ddf5fa0mr569410plo.62.1707853268826; Tue, 13 Feb 2024 11:41:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXuK2Q10R4a0MtajnSBeCBgC1nzcxSKdapP0sr6xg4POr9W4qGtKL55p/9OPv6HOX6OL8wNzFg8NKrZg9RNQv7BRjjecXklJNSjWRCXV/8+TU6euQSdSxB3KyUbty3g8YnSyKup9OTjQbvRRtUgsyMs2k3IELxS6RodDOm6OIKHHA== X-Received: from localhost.localdomain ([131.107.147.247]) by smtp.gmail.com with ESMTPSA id ks6-20020a170903084600b001d9588f0714sm2436189plb.177.2024.02.13.11.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 11:41:08 -0800 (PST) From: "Doug Flick via groups.io" To: devel@edk2.groups.io Cc: Doug Flick , Saloni Kasbekar , Zachary Clark-williams , "Doug Flick [MSFT]" Subject: [edk2-devel] [PATCH v2 3/4] NetworkPkg: Dhcp6Dxe: Packet-Length is not updated before appending Date: Tue, 13 Feb 2024 10:46:02 -0800 Message-Id: <20240213184603.2985-4-doug.edk2@gmail.com> In-Reply-To: <20240213184603.2985-1-doug.edk2@gmail.com> References: <20240213184603.2985-1-doug.edk2@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dougflick@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TGvxiylv; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Doug Flick In order for Dhcp6AppendIaAddrOption (..) to safely append the IA Address option, the Packet-Length field must be updated before appending the option. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: Doug Flick [MSFT] --- NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c b/NetworkPkg/Dhcp6Dxe/Dhcp6= Utility.c index e4e072562296..f38e3ee3fe1a 100644 --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Utility.c @@ -924,6 +924,11 @@ Dhcp6AppendIaOption ( *PacketCursor +=3D sizeof (T2);=0D }=0D =0D + //=0D + // Update the packet length=0D + //=0D + Packet->Length +=3D BytesNeeded;=0D +=0D //=0D // Fill all the addresses belong to the Ia=0D //=0D @@ -935,11 +940,6 @@ Dhcp6AppendIaOption ( }=0D }=0D =0D - //=0D - // Update the packet length=0D - //=0D - Packet->Length +=3D BytesNeeded;=0D -=0D //=0D // Fill the value of Ia option length=0D //=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115409): https://edk2.groups.io/g/devel/message/115409 Mute This Topic: https://groups.io/mt/104339708/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-