[edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks

[edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks

[Michael D Kinney]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680

* Reject patches that match Author email "devel@edk2.groups.io"
* Update the current check for " via Groups.Io" to perform a
  case insensitive match. It appears that groups.io has changed the
  format of this string to use all lower case.

Cc: Rebecca Cran <rebecca@bsdio.com> [bcran]
Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
Cc: Bob Feng <bob.c.feng@intel.com> [BobCF]
Cc: Yuwei Chen <yuwei.chen@intel.com> [YuweiChen1110]
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 BaseTools/Scripts/PatchCheck.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index 1675dcbd7321..e600e0be440f 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -85,7 +85,11 @@ class EmailAddressCheck:
             self.error("The email address cannot contain a space: " +
                        mo.group(3))
 
-        if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
+        if mo.group(3) == 'devel@edk2.groups.io':
+            self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
+                       email)
+
+        if ' via groups.io' in name.lower() and mo.group(3).endswith('@groups.io'):
             self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
                        email)
 
-- 
2.40.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115404): https://edk2.groups.io/g/devel/message/115404
Mute This Topic: https://groups.io/mt/104339266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks

[Rebecca Cran]

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>

On 2/13/24 12:17, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
>
> * Reject patches that match Author email "devel@edk2.groups.io"
> * Update the current check for " via Groups.Io" to perform a
>    case insensitive match. It appears that groups.io has changed the
>    format of this string to use all lower case.
>
> Cc: Rebecca Cran <rebecca@bsdio.com> [bcran]
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Bob Feng <bob.c.feng@intel.com> [BobCF]
> Cc: Yuwei Chen <yuwei.chen@intel.com> [YuweiChen1110]
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 1675dcbd7321..e600e0be440f 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -85,7 +85,11 @@ class EmailAddressCheck:
>               self.error("The email address cannot contain a space: " +
>                          mo.group(3))
>   
> -        if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
> +        if mo.group(3) == 'devel@edk2.groups.io':
> +            self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
> +                       email)
> +
> +        if ' via groups.io' in name.lower() and mo.group(3).endswith('@groups.io'):
>               self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
>                          email)
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115459): https://edk2.groups.io/g/devel/message/115459
Mute This Topic: https://groups.io/mt/104339266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks

[Ard Biesheuvel]

On Tue, 13 Feb 2024 at 20:18, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
>
> * Reject patches that match Author email "devel@edk2.groups.io"
> * Update the current check for " via Groups.Io" to perform a
>   case insensitive match. It appears that groups.io has changed the
>   format of this string to use all lower case.
>
> Cc: Rebecca Cran <rebecca@bsdio.com> [bcran]
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Bob Feng <bob.c.feng@intel.com> [BobCF]
> Cc: Yuwei Chen <yuwei.chen@intel.com> [YuweiChen1110]
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  BaseTools/Scripts/PatchCheck.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 1675dcbd7321..e600e0be440f 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -85,7 +85,11 @@ class EmailAddressCheck:
>              self.error("The email address cannot contain a space: " +
>                         mo.group(3))
>
> -        if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
> +        if mo.group(3) == 'devel@edk2.groups.io':
> +            self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
> +                       email)
> +
> +        if ' via groups.io' in name.lower() and mo.group(3).endswith('@groups.io'):
>              self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
>                         email)
>
> --
> 2.40.1.windows.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115464): https://edk2.groups.io/g/devel/message/115464
Mute This Topic: https://groups.io/mt/104339266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-