* [edk2-devel] [PATCH 1/2] ArmPkg: Remove ArmCortexA5x.h
2024-02-14 12:42 [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files PierreGondois
@ 2024-02-14 12:42 ` PierreGondois
2024-02-14 12:42 ` [edk2-devel] [PATCH 2/2] ArmPkg: Remove ArmCortexA9.h PierreGondois
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: PierreGondois @ 2024-02-14 12:42 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar, Pierre Gondois
The last reference to ArmCortexA5x.h was removed in:
commit: cffa7925a293 ("ArmPkg: remove ArmCpuLib header
and implementations")
There are no reference to the file in the edk2-platforms
repository. Remove the file.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
ArmPkg/Include/Chipset/ArmCortexA5x.h | 44 ---------------------------
1 file changed, 44 deletions(-)
delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA5x.h
diff --git a/ArmPkg/Include/Chipset/ArmCortexA5x.h b/ArmPkg/Include/Chipset/ArmCortexA5x.h
deleted file mode 100644
index cc8b23b96475..000000000000
--- a/ArmPkg/Include/Chipset/ArmCortexA5x.h
+++ /dev/null
@@ -1,44 +0,0 @@
-/** @file
-
- Copyright (c) 2012 - 2021, Arm Limited. All rights reserved.<BR>
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef ARM_CORTEX_A5X_H_
-#define ARM_CORTEX_A5X_H_
-
-//
-// Cortex A5x feature bit definitions
-//
-#define A5X_FEATURE_SMP (1 << 6)
-
-//
-// Helper functions to access CPU Extended Control Register
-//
-UINT64
-EFIAPI
-ArmReadCpuExCr (
- VOID
- );
-
-VOID
-EFIAPI
-ArmWriteCpuExCr (
- IN UINT64 Val
- );
-
-VOID
-EFIAPI
-ArmSetCpuExCrBit (
- IN UINT64 Bits
- );
-
-VOID
-EFIAPI
-ArmUnsetCpuExCrBit (
- IN UINT64 Bits
- );
-
-#endif // ARM_CORTEX_A5X_H_
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115447): https://edk2.groups.io/g/devel/message/115447
Mute This Topic: https://groups.io/mt/104351710/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel] [PATCH 2/2] ArmPkg: Remove ArmCortexA9.h
2024-02-14 12:42 [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files PierreGondois
2024-02-14 12:42 ` [edk2-devel] [PATCH 1/2] ArmPkg: Remove ArmCortexA5x.h PierreGondois
@ 2024-02-14 12:42 ` PierreGondois
2024-02-14 13:26 ` [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files Ard Biesheuvel
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: PierreGondois @ 2024-02-14 12:42 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar, Pierre Gondois
The last reference to ArmCortexA9.h in the edk2 repository
was removed in:
a913ad02479d ("ArmPlatformPkg: remove ArmVExpressPkg")
The last reference to the file in the edk2-platforms
repository was agreed to be dropped:
https://edk2.groups.io/g/devel/message/115378
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
ArmPkg/Include/Chipset/ArmCortexA9.h | 57 ----------------------------
1 file changed, 57 deletions(-)
delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA9.h
diff --git a/ArmPkg/Include/Chipset/ArmCortexA9.h b/ArmPkg/Include/Chipset/ArmCortexA9.h
deleted file mode 100644
index a89aeebd4a2a..000000000000
--- a/ArmPkg/Include/Chipset/ArmCortexA9.h
+++ /dev/null
@@ -1,57 +0,0 @@
-/** @file
-
- Copyright (c) 2011, ARM Limited. All rights reserved.
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef ARM_CORTEX_A9_H_
-#define ARM_CORTEX_A9_H_
-
-#include <Chipset/ArmV7.h>
-
-//
-// Cortex A9 feature bit definitions
-//
-#define A9_FEATURE_PARITY (1<<9)
-#define A9_FEATURE_AOW (1<<8)
-#define A9_FEATURE_EXCL (1<<7)
-#define A9_FEATURE_SMP (1<<6)
-#define A9_FEATURE_FOZ (1<<3)
-#define A9_FEATURE_DPREF (1<<2)
-#define A9_FEATURE_HINT (1<<1)
-#define A9_FEATURE_FWD (1<<0)
-
-//
-// Cortex A9 Watchdog
-//
-#define ARM_A9_WATCHDOG_REGION 0x600
-
-#define ARM_A9_WATCHDOG_LOAD_REGISTER 0x20
-#define ARM_A9_WATCHDOG_CONTROL_REGISTER 0x28
-
-#define ARM_A9_WATCHDOG_WATCHDOG_MODE (1 << 3)
-#define ARM_A9_WATCHDOG_TIMER_MODE (0 << 3)
-#define ARM_A9_WATCHDOG_SINGLE_SHOT (0 << 1)
-#define ARM_A9_WATCHDOG_AUTORELOAD (1 << 1)
-#define ARM_A9_WATCHDOG_ENABLE 1
-
-//
-// SCU register offsets & masks
-//
-#define A9_SCU_CONTROL_OFFSET 0x0
-#define A9_SCU_CONFIG_OFFSET 0x4
-#define A9_SCU_INVALL_OFFSET 0xC
-#define A9_SCU_FILT_START_OFFSET 0x40
-#define A9_SCU_FILT_END_OFFSET 0x44
-#define A9_SCU_SACR_OFFSET 0x50
-#define A9_SCU_SSACR_OFFSET 0x54
-
-UINTN
-EFIAPI
-ArmGetScuBaseAddress (
- VOID
- );
-
-#endif // ARM_CORTEX_A9_H_
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115448): https://edk2.groups.io/g/devel/message/115448
Mute This Topic: https://groups.io/mt/104351711/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files
2024-02-14 12:42 [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files PierreGondois
2024-02-14 12:42 ` [edk2-devel] [PATCH 1/2] ArmPkg: Remove ArmCortexA5x.h PierreGondois
2024-02-14 12:42 ` [edk2-devel] [PATCH 2/2] ArmPkg: Remove ArmCortexA9.h PierreGondois
@ 2024-02-14 13:26 ` Ard Biesheuvel
2024-03-11 17:03 ` PierreGondois
2024-04-05 2:41 ` Sami Mujawar
2024-04-05 8:20 ` Sami Mujawar
4 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2024-02-14 13:26 UTC (permalink / raw)
To: devel, pierre.gondois; +Cc: Leif Lindholm, Sami Mujawar
On Wed, 14 Feb 2024 at 13:42, PierreGondois <pierre.gondois@arm.com> wrote:
>
> Following the discussion at:
> https://edk2.groups.io/g/devel/message/115378
> remove ArmCortexA5x.h and ArmCortexA9.h files.
> A patch-set for the edk2-platforms repository will be posted
> to remove the remaining references.
>
> Pierre Gondois (2):
> ArmPkg: Remove ArmCortexA5x.h
> ArmPkg: Remove ArmCortexA9.h
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ArmPkg/Include/Chipset/ArmCortexA5x.h | 44 ---------------------
> ArmPkg/Include/Chipset/ArmCortexA9.h | 57 ---------------------------
> 2 files changed, 101 deletions(-)
> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA5x.h
> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA9.h
>
> --
> 2.25.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#115446): https://edk2.groups.io/g/devel/message/115446
> Mute This Topic: https://groups.io/mt/104351709/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115454): https://edk2.groups.io/g/devel/message/115454
Mute This Topic: https://groups.io/mt/104351709/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files
2024-02-14 13:26 ` [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files Ard Biesheuvel
@ 2024-03-11 17:03 ` PierreGondois
0 siblings, 0 replies; 7+ messages in thread
From: PierreGondois @ 2024-03-11 17:03 UTC (permalink / raw)
To: devel, Leif Lindholm, Sami Mujawar; +Cc: Ard Biesheuvel
Hello Sami, Leif,
Just a ping in case the patch-set was forgotten,
Regards,
Pierre
On 2/14/24 14:26, Ard Biesheuvel wrote:
> On Wed, 14 Feb 2024 at 13:42, PierreGondois <pierre.gondois@arm.com> wrote:
>>
>> Following the discussion at:
>> https://edk2.groups.io/g/devel/message/115378
>> remove ArmCortexA5x.h and ArmCortexA9.h files.
>> A patch-set for the edk2-platforms repository will be posted
>> to remove the remaining references.
>>
>> Pierre Gondois (2):
>> ArmPkg: Remove ArmCortexA5x.h
>> ArmPkg: Remove ArmCortexA9.h
>>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
>> ArmPkg/Include/Chipset/ArmCortexA5x.h | 44 ---------------------
>> ArmPkg/Include/Chipset/ArmCortexA9.h | 57 ---------------------------
>> 2 files changed, 101 deletions(-)
>> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA5x.h
>> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA9.h
>>
>> --
>> 2.25.1
>>
>>
>>
>> ------------
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#115446): https://edk2.groups.io/g/devel/message/115446
>> Mute This Topic: https://groups.io/mt/104351709/5717338
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
>> ------------
>>
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116650): https://edk2.groups.io/g/devel/message/116650
Mute This Topic: https://groups.io/mt/104351709/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files
2024-02-14 12:42 [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files PierreGondois
` (2 preceding siblings ...)
2024-02-14 13:26 ` [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files Ard Biesheuvel
@ 2024-04-05 2:41 ` Sami Mujawar
2024-04-05 8:20 ` Sami Mujawar
4 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2024-04-05 2:41 UTC (permalink / raw)
To: Pierre Gondois, devel; +Cc: Ard Biesheuvel, Leif Lindholm, nd@arm.com
Hi Pierre,
Thank you for this series.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 14/02/2024 12:42 pm, Pierre Gondois wrote:
> Following the discussion at:
> https://edk2.groups.io/g/devel/message/115378
> remove ArmCortexA5x.h and ArmCortexA9.h files.
> A patch-set for the edk2-platforms repository will be posted
> to remove the remaining references.
>
> Pierre Gondois (2):
> ArmPkg: Remove ArmCortexA5x.h
> ArmPkg: Remove ArmCortexA9.h
>
> ArmPkg/Include/Chipset/ArmCortexA5x.h | 44 ---------------------
> ArmPkg/Include/Chipset/ArmCortexA9.h | 57 ---------------------------
> 2 files changed, 101 deletions(-)
> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA5x.h
> delete mode 100644 ArmPkg/Include/Chipset/ArmCortexA9.h
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117452): https://edk2.groups.io/g/devel/message/117452
Mute This Topic: https://groups.io/mt/104351709/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files
2024-02-14 12:42 [edk2-devel] [PATCH 0/2] ArmPkg: Remove ArmCortexA[5x|9].h files PierreGondois
` (3 preceding siblings ...)
2024-04-05 2:41 ` Sami Mujawar
@ 2024-04-05 8:20 ` Sami Mujawar
4 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2024-04-05 8:20 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
Merged as 6fb3cc05dc87..8707f835ae35
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117456): https://edk2.groups.io/g/devel/message/117456
Mute This Topic: https://groups.io/mt/104351709/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 879 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread