From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D500B941BA6 for ; Fri, 16 Feb 2024 21:47:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=j0Iu71C6EVZQTNHydtht9QkTEiu3DOZhjC91TZ7hNKk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708120019; v=1; b=cxnrBB71IlgtQ+E7YNOxDL0OBsEC/8NgvloLiD3YWChZ0ijX0GDpbNLsFelYoRXAVYbWn5qS bIUw/C6AoGCppAUumO2XafiSZCJksDDLei0l/HRfVX9nFNxWhElN874TTVPmp4Z8FW/UVUyiyp3 cxa3YnKOhPqfZJqUxB3Na8hg= X-Received: by 127.0.0.2 with SMTP id 5xrcYY7687511xgIVVuHATGu; Fri, 16 Feb 2024 13:46:59 -0800 X-Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web10.10395.1708120018643719483 for ; Fri, 16 Feb 2024 13:46:58 -0800 X-Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3392b12dd21so1404735f8f.0 for ; Fri, 16 Feb 2024 13:46:58 -0800 (PST) X-Gm-Message-State: fOFF7MZiK3tdiecIQeLpFgcOx7686176AA= X-Google-Smtp-Source: AGHT+IGfD0XHYVMPNkJlNh/LJ9ijdI1e5JzMZBmilN1gAWcskEo92dRS99zNgThzjyQ3WQ1eUBVlnw== X-Received: by 2002:adf:a490:0:b0:33b:377f:7aa with SMTP id g16-20020adfa490000000b0033b377f07aamr4536839wrb.52.1708120016376; Fri, 16 Feb 2024 13:46:56 -0800 (PST) X-Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0033940016d6esm3168169wrw.93.2024.02.16.13.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 13:46:56 -0800 (PST) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , Rebecca Cran , Michael D Kinney , Jayaprakash N , pawel.karczewski@solidigm.com Subject: [edk2-devel] [PATCH edk2-libc 1/1] StdLib: Remove the 'register' keyword from public interfaces Date: Fri, 16 Feb 2024 21:46:53 +0000 Message-ID: <20240216214653.86540-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cxnrBB71; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io ISO C interfaces do not have the 'register' keyword, so this is technically non-compliant and other consumers of C headers (such as C++) will error out when seeing this keyword. This should not affect anything, functionality-wise or ABI-wise. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Cc: pawel.karczewski@solidigm.com Signed-off-by: Pedro Falcato --- This should fix your problem. Pawel, can you check? StdLib/Include/stdlib.h | 8 ++++---- StdLib/Include/string.h | 6 +++--- StdLib/LibC/StdLib/Environs.c | 4 ++-- StdLib/LibC/String/strsep.c | 10 +++++----- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h index d9aaaab39d46..42810c86e65a 100644 --- a/StdLib/Include/stdlib.h +++ b/StdLib/Include/stdlib.h @@ -33,8 +33,8 @@ void exit (int status) __noreturn; void _Exit (int status) __noreturn; char *getenv (const char *name); - int setenv (register const char * name, - register const char * value, int rewrite); + int setenv (const char * name, + const char * value, int rewrite); int system (const char *string); ################ Integer arithmetic functions @@ -279,8 +279,8 @@ char *getenv(const char *name); **/ int setenv ( - register const char * name, - register const char * value, + const char * name, + const char * value, int rewrite ); diff --git a/StdLib/Include/string.h b/StdLib/Include/string.h index 0c809441e830..6acd274b848d 100644 --- a/StdLib/Include/string.h +++ b/StdLib/Include/string.h @@ -71,7 +71,7 @@ int strncasecmp (const char *s1, const char *s2, size_t n); size_t strlcpy (char *destination, const char *source, size_t size); size_t strlcat (char *destination, const char *source, size_t size); - char *strsep (register char **stringp, register const char *delim); + char *strsep (char **stringp, const char *delim); @endverbatim Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
@@ -484,8 +484,8 @@ size_t strlcat(char *destination, const char *source, size_t size); */ char * strsep( - register char **stringp, - register const char *delim + char **stringp, + const char *delim ); __END_DECLS diff --git a/StdLib/LibC/StdLib/Environs.c b/StdLib/LibC/StdLib/Environs.c index e8cfd6d9f400..ad16444ce89c 100644 --- a/StdLib/LibC/StdLib/Environs.c +++ b/StdLib/LibC/StdLib/Environs.c @@ -209,8 +209,8 @@ char *getenv(const char *name) **/ int setenv ( - register const char * name, - register const char * value, + const char * name, + const char * value, int rewrite ) { diff --git a/StdLib/LibC/String/strsep.c b/StdLib/LibC/String/strsep.c index 234b0cabd689..d250ff781658 100644 --- a/StdLib/LibC/String/strsep.c +++ b/StdLib/LibC/String/strsep.c @@ -53,13 +53,13 @@ static char sccsid[] = "@(#)strsep.c 8.1 (Berkeley) 6/4/93"; */ char * strsep( - register char **stringp, - register const char *delim + char **stringp, + const char *delim ) { - register char *s; - register const char *spanp; - register int c, sc; + char *s; + const char *spanp; + int c, sc; char *tok; if ((s = *stringp) == NULL) -- 2.43.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115559): https://edk2.groups.io/g/devel/message/115559 Mute This Topic: https://groups.io/mt/104402243/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-