public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Bob Feng <bob.c.feng@intel.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>
Subject: [edk2-devel] [Patch 0/4] PatchCheck Updates
Date: Sun, 18 Feb 2024 12:59:47 -0800	[thread overview]
Message-ID: <20240218205951.497-1-michael.d.kinney@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4693
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694

Fix a collection of PatchCheck issues and add a new PatchCheck
featue to check for a commit that modifies files in multiple
packages with option to disable the multiple package check as
a command line option or a commit message tag.

* Reject patches that match Author email "devel@edk2.groups.io"
* Update the current check for " via Groups.Io" to perform a
  case insensitive match. It appears that groups.io has changed the
  format of this string to use all lower case.
* Update logic in CommitMessageCheck class to return errors
  detected in commit message signatures instead of silently 
  passing the check.
* Genenerate an error if no Cc tags are present to make sure
  all patches Cc the required maintainers/reviewers.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (4):
  BaseTools/Scripts/PatchCheck: Update Author checks
  BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors
  BaseTools/Scripts/PatchCheck: Error if no Cc tags are present
  BaseTools/Scripts/PatchCheck: Error if commit modifies multiple
    packages

 BaseTools/Scripts/PatchCheck.py | 91 +++++++++++++++++++++++++++++++--
 1 file changed, 86 insertions(+), 5 deletions(-)

-- 
2.40.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115568): https://edk2.groups.io/g/devel/message/115568
Mute This Topic: https://groups.io/mt/104434581/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-02-18 20:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 20:59 Michael D Kinney [this message]
2024-02-18 20:59 ` [edk2-devel] [Patch 1/4] BaseTools/Scripts/PatchCheck: Update Author checks Michael D Kinney
2024-02-27 17:59   ` Rebecca Cran
2024-02-18 20:59 ` [edk2-devel] [Patch 2/4] BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors Michael D Kinney
2024-02-24  1:26   ` Michael Kubacki
2024-02-18 20:59 ` [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present Michael D Kinney
2024-02-20 14:48   ` Ard Biesheuvel
2024-02-20 22:09     ` Michael D Kinney
2024-02-21 22:16     ` Laszlo Ersek
2024-02-21 23:32       ` Ard Biesheuvel
2024-02-24  1:26   ` Michael Kubacki
2024-02-18 20:59 ` [edk2-devel] [Patch 4/4] BaseTools/Scripts/PatchCheck: Error if commit modifies multiple packages Michael D Kinney
2024-02-24  1:27   ` Michael Kubacki
2024-02-27 19:28 ` [edk2-devel] [Patch 0/4] PatchCheck Updates Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240218205951.497-1-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox