From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 64B7C7803CC for ; Sun, 18 Feb 2024 21:00:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=W7et30d4k9z12k6+Z8Dlt75GegTgONrGBUGL5JZMdK0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708290000; v=1; b=MHrmbhEPGH89J4izA/gOBBR73wytism0txkfU0xc2flfCo48jS2DsxxxDptredeLpBIIzQJB EPP2K33KT0aWILtlXiusSMmMS8xiQavFgWYb+2Uxq0UpweyEbmoSfw1TlcQKXKLdhjh66alimSe DBkdjZ5gBlGSL4IxYccgQJk8= X-Received: by 127.0.0.2 with SMTP id AHJFYY7687511xJiwoQL2F53; Sun, 18 Feb 2024 13:00:00 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web11.26742.1708289997485769267 for ; Sun, 18 Feb 2024 12:59:58 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="2235016" X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="2235016" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 12:59:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="4351426" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.209.68.113]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 12:59:58 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Michael Kubacki Subject: [edk2-devel] [Patch 2/4] BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors Date: Sun, 18 Feb 2024 12:59:49 -0800 Message-Id: <20240218205951.497-3-michael.d.kinney@intel.com> In-Reply-To: <20240218205951.497-1-michael.d.kinney@intel.com> References: <20240218205951.497-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ulGRWMvRlRu3EZUO7pwATJSHx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MHrmbhEP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4693 Commit signatures are checked and error messages are logged but errors are not captured and returned from find_signatures() in the CommitMessageCheck class. This causes signature errors to be silently ignored by CI. Update logic in CommitMessageCheck class to return errors detected in commit message signatures. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index e600e0be440f..158a2b30a5ce 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -202,7 +202,7 @@ class CommitMessageCheck: if s[2] != ' ': self.error("There should be a space after '" + sig + ":'") - EmailAddressCheck(s[3], sig) + self.ok &= EmailAddressCheck(s[3], sig).ok return sigs -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115570): https://edk2.groups.io/g/devel/message/115570 Mute This Topic: https://groups.io/mt/104434583/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-