From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BBE4CAC1C8C for ; Sun, 18 Feb 2024 21:00:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zFvs8rsak3hxgc5oZVf1gygfg+1axCG1XC2Ixem6kzE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708290000; v=1; b=ZgCMJP/7f1uT4HkywLSmDCJ7We4uyEg4aXhbPpTjsYov+gcUhrzXo47bB6PwKLuj6dy4xsRW HCacN+fgsJIyuSHrxknWeurldFjqmek3BsldqUH14erGJk5pylwdT5M1jpWRRwDQa42DfSNMpYl 3T1pVeB1XPiYYkZAsnp+XgeM= X-Received: by 127.0.0.2 with SMTP id 73mZYY7687511xvYun2bZf0C; Sun, 18 Feb 2024 13:00:00 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web11.26742.1708289997485769267 for ; Sun, 18 Feb 2024 12:59:58 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="2235020" X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="2235020" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 12:59:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="4351429" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.209.68.113]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 12:59:58 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Michael Kubacki Subject: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present Date: Sun, 18 Feb 2024 12:59:50 -0800 Message-Id: <20240218205951.497-4-michael.d.kinney@intel.com> In-Reply-To: <20240218205951.497-1-michael.d.kinney@intel.com> References: <20240218205951.497-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Zek97z3KZjduoVf1ABslCozxx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="ZgCMJP/7"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694 If no Cc tags are detected in a commit message, then generate an error. All patches sent for review are required to provide the set of maintainers and reviewers responsible for the directories/files modified. The set of maintainers and reviewers are documented in Maintainers.txt and can be retrieved using the script BaseTools/Scripts/GetMaintainer.py. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael Kubacki Signed-off-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 158a2b30a5ce..415198e3824e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -229,8 +229,10 @@ class CommitMessageCheck: ) def check_misc_signatures(self): - for sig in self.sig_types: - self.find_signatures(sig) + for sigtype in self.sig_types: + sigs = self.find_signatures(sigtype) + if sigtype == 'Cc' and len(sigs) == 0: + self.error('No Cc: tags for maintainers/reviewers found!') cve_re = re.compile('CVE-[0-9]{4}-[0-9]{5}[^0-9]') -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115571): https://edk2.groups.io/g/devel/message/115571 Mute This Topic: https://groups.io/mt/104434584/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-