From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8D2CD940509 for ; Wed, 21 Feb 2024 00:13:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5FmlJvLpsNCg1TyAF6XrcaddbOIv+kaJkG4woARwhiQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708474390; v=1; b=OxB1gLb5FtS4po9cMjChkXQqaAc1/zXRhRM4i1CXbZ6+YpFk6tQH+PnTf61FJ4jODFQcY7cW 8JjuAFXNi37cm3yQAZDqjn7teSKRRIYGBrZteXPemCtO3ZxRon6QRl6J/trW6d7PpfGJuqVKe9t cMuT8K7FkVaCyVLyb/E23uaM= X-Received: by 127.0.0.2 with SMTP id EjNmYY7687511x5OLWxbtITd; Tue, 20 Feb 2024 16:13:10 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.1780.1708474389611573308 for ; Tue, 20 Feb 2024 16:13:09 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-512b13bf764so3537663e87.0 for ; Tue, 20 Feb 2024 16:13:09 -0800 (PST) X-Gm-Message-State: PXgV6imfzUmB0nviZ6nQY7WTx7686176AA= X-Google-Smtp-Source: AGHT+IH2qPGi99rn0On9pNfm7rkt76VWJcHNbQvYgg05Qxw3f8g0AgAKtIYvhXZ4ScemDgU5qdCG6g== X-Received: by 2002:a05:6512:1593:b0:512:c1ef:ac5 with SMTP id bp19-20020a056512159300b00512c1ef0ac5mr4091487lfb.26.1708474387654; Tue, 20 Feb 2024 16:13:07 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h27-20020a056512055b00b0051298559337sm1447103lfl.3.2024.02.20.16.13.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 20 Feb 2024 16:13:07 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Nickle Wang , Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback Date: Wed, 21 Feb 2024 03:13:01 +0300 Message-Id: <20240221001303.57384-3-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-1-mike.maslenkin@gmail.com> References: <20240221001303.57384-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OxB1gLb5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Use local variable for CollectionUri passed to HandleResource() to avoid problems in case of Private->Uri is overriden down the call stack. Suggested-by: Nickle Wang Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index f40f2d85af80..396ec22969b5 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -670,6 +670,7 @@ RedfishExternalResourceResourceFeatureCallback ( REDFISH_SERVICE RedfishService;=0D REDFISH_RESOURCE_COMMON_PRIVATE *Private;=0D EFI_STRING ResourceUri;=0D + EFI_STRING CollectionUri;=0D =0D if (FeatureAction !=3D CallbackActionStartOperation) {=0D return EFI_UNSUPPORTED;=0D @@ -707,19 +708,19 @@ RedfishExternalResourceResourceFeatureCallback ( //=0D // Initialize collection path=0D //=0D - Private->Uri =3D RedfishGetUri (ResourceUri);=0D - if (Private->Uri =3D=3D NULL) {=0D + CollectionUri =3D RedfishGetUri (ResourceUri);=0D + if (CollectionUri =3D=3D NULL) {=0D ASSERT (FALSE);=0D FreePool (ResourceUri);=0D return EFI_OUT_OF_RESOURCES;=0D }=0D =0D - Status =3D HandleResource (Private, Private->Uri);=0D + Status =3D HandleResource (Private, CollectionUri);=0D if (EFI_ERROR (Status)) {=0D - DEBUG ((DEBUG_ERROR, "%a, process external resource: %a failed: %r\n",= __func__, Private->Uri, Status));=0D + DEBUG ((DEBUG_ERROR, "%a, process external resource: %s failed: %r\n",= __func__, CollectionUri, Status));=0D }=0D =0D - FreePool (Private->Uri);=0D + FreePool (CollectionUri);=0D FreePool (ResourceUri);=0D return Status;=0D }=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115686): https://edk2.groups.io/g/devel/message/115686 Mute This Topic: https://groups.io/mt/104479572/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-