From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D6039940048 for ; Wed, 21 Feb 2024 00:13:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IvO4E1X2XoCsjXCBqPoGweStOMszY0Ipmj7GFUKboSg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708474391; v=1; b=Jh4+J9/XSkT7B35HFyNHDtz13vIJO5YD42cNR0Qe+dhpd7rZikZod73de4Damw1GLF8XiRzP /5nrhu1ZLv2WrfFWagzu1KFxqRBmnNeEMdmCYnlblbiVmlg52GP3y7wHFwPkaFZ9mRwiXPcRNGh EATF+zi81uu6s6lGHbj0g/Kw= X-Received: by 127.0.0.2 with SMTP id RtG8YY7687511xTrwoLK7nOK; Tue, 20 Feb 2024 16:13:11 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.1781.1708474390677275000 for ; Tue, 20 Feb 2024 16:13:11 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-512be87a0f3so42718e87.3 for ; Tue, 20 Feb 2024 16:13:10 -0800 (PST) X-Gm-Message-State: io3Bfn2YpScaFRqTurDgcQtNx7686176AA= X-Google-Smtp-Source: AGHT+IF4ikKNntT0gMWtDTSGK5PbmPAp5l3UrxAPbP74+nABl1GuTGc74l9eiGn/+gw/0jRpDVsjuQ== X-Received: by 2002:ac2:5ec3:0:b0:512:d14b:95c7 with SMTP id d3-20020ac25ec3000000b00512d14b95c7mr204612lfq.7.1708474388793; Tue, 20 Feb 2024 16:13:08 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id h27-20020a056512055b00b0051298559337sm1447103lfl.3.2024.02.20.16.13.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 20 Feb 2024 16:13:08 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Abner Chang , Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Date: Wed, 21 Feb 2024 03:13:02 +0300 Message-Id: <20240221001303.57384-4-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-1-mike.maslenkin@gmail.com> References: <20240221001303.57384-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Jh4+J9/X"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index 396ec22969b5..8548425c9c83 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -132,6 +132,7 @@ RedfishResourceConsumeResource ( // Check and see if "@Redfish.Settings" exist or not.=0D //=0D ZeroMem (&PendingSettingResponse, sizeof (REDFISH_RESPONSE));=0D + PendingSettingUri =3D NULL;=0D Status =3D GetPendingSettings (=0D Private->RedfishService,=0D Response.Payload,=0D @@ -206,6 +207,10 @@ RedfishResourceConsumeResource ( FreePool (Etag);=0D }=0D =0D + if (PendingSettingUri !=3D NULL) {=0D + FreePool (PendingSettingUri);=0D + }=0D +=0D return Status;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115687): https://edk2.groups.io/g/devel/message/115687 Mute This Topic: https://groups.io/mt/104479573/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-