From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 09410941CF3 for ; Wed, 21 Feb 2024 20:06:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mpvSvCjiFzKM/m1Cxax59ZqkrkXpUbFEp5A4cYUk+Bw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708545998; v=1; b=XAd9D3jaXDZPDSC+Hyj4ePOUfrI5wi9zbAMTfeX8gAjwc9ilWXROEACJVktuIGqA/i1Sfvuw mSJG6h3TratIAs7PkkD5O2VEM2pkWavBi0gy+KXtbbgLSWaVwXvdxne0gtCQEny1KAIs4+IXpAA 42pcKw/pDSwquZWmn32U4ffU= X-Received: by 127.0.0.2 with SMTP id W5d0YY7687511xJgwq4UWCyK; Wed, 21 Feb 2024 12:06:38 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.1100.1708545997848952170 for ; Wed, 21 Feb 2024 12:06:38 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-512cba0f953so2169947e87.2 for ; Wed, 21 Feb 2024 12:06:37 -0800 (PST) X-Gm-Message-State: 2QRfYxmohjeidmbhtuzTC22Dx7686176AA= X-Google-Smtp-Source: AGHT+IEOt61fhaTuiA6BPMUDaNPTe+UNgbdBZkcyV5dBEvnzmYLXGwPYnEJvnHKdc5b/WB22rlpJrQ== X-Received: by 2002:ac2:592c:0:b0:512:b00f:a55e with SMTP id v12-20020ac2592c000000b00512b00fa55emr6132547lfi.13.1708545995731; Wed, 21 Feb 2024 12:06:35 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id a12-20020a056512020c00b00512da6d23b6sm44973lfo.147.2024.02.21.12.06.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 21 Feb 2024 12:06:35 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Abner Chang , Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH v2 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Date: Wed, 21 Feb 2024 23:06:27 +0300 Message-Id: <20240221200628.74174-4-mike.maslenkin@gmail.com> In-Reply-To: <20240221200628.74174-1-mike.maslenkin@gmail.com> References: <20240221200628.74174-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XAd9D3ja; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index db77ed3dfccb..a442d446bc35 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -132,12 +132,13 @@ RedfishResourceConsumeResource ( // Check and see if "@Redfish.Settings" exist or not.=0D //=0D ZeroMem (&PendingSettingResponse, sizeof (REDFISH_RESPONSE));=0D - Status =3D GetPendingSettings (=0D - Private->RedfishService,=0D - Response.Payload,=0D - &PendingSettingResponse,=0D - &PendingSettingUri=0D - );=0D + PendingSettingUri =3D NULL;=0D + Status =3D GetPendingSettings (=0D + Private->RedfishService,=0D + Response.Payload,=0D + &PendingSettingResponse,=0D + &PendingSettingUri=0D + );=0D if (!EFI_ERROR (Status)) {=0D DEBUG ((REDFISH_DEBUG_TRACE, "%a: @Redfish.Settings found: %s\n", __fu= nc__, PendingSettingUri));=0D Private->Uri =3D PendingSettingUri;=0D @@ -206,6 +207,10 @@ RedfishResourceConsumeResource ( FreePool (Etag);=0D }=0D =0D + if (PendingSettingUri !=3D NULL) {=0D + FreePool (PendingSettingUri);=0D + }=0D +=0D return Status;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115737): https://edk2.groups.io/g/devel/message/115737 Mute This Topic: https://groups.io/mt/104495960/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-