From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 01D997803CC for ; Wed, 21 Feb 2024 20:06:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D2liy+8ynaS5//PKV7ofFJ/kM1paADXgUduQHfgRqhI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708545999; v=1; b=HNrMv7lG5wJ1uZAKVV3lWweOWiBi8G39sFmBjQ+IhoBI53yY9wTjBU16rEsBwDtznvloOjJ1 qt6Evj3NOjPs+ryKwNM0rs0WsnuukOHr4GS2j5jIXAAcT3diRqZ5IJCWLWjKEwb/3sNfp7y+HWj NTF1AuSmfvDFrAkdp+U6Vvts= X-Received: by 127.0.0.2 with SMTP id xl6NYY7687511xv38ssQUB0H; Wed, 21 Feb 2024 12:06:39 -0800 X-Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web10.1102.1708545998875166004 for ; Wed, 21 Feb 2024 12:06:39 -0800 X-Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-512b84bdaf1so4646022e87.1 for ; Wed, 21 Feb 2024 12:06:38 -0800 (PST) X-Gm-Message-State: wcMIfQ0APxQXR0ekxGRhIVNIx7686176AA= X-Google-Smtp-Source: AGHT+IFYe8PfOca42/LYQY/CiKOJSBkoCloDRtgaVmxtxdqiLESRTgiy8UO1cZBdiddKFRhAgdeavA== X-Received: by 2002:a05:6512:2182:b0:512:cebf:e8d5 with SMTP id b2-20020a056512218200b00512cebfe8d5mr2057562lft.23.1708545996961; Wed, 21 Feb 2024 12:06:36 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id a12-20020a056512020c00b00512da6d23b6sm44973lfo.147.2024.02.21.12.06.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 21 Feb 2024 12:06:36 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Abner Chang , Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH v2 4/4] RedfishClientPkg: use Json value from a function argument Date: Wed, 21 Feb 2024 23:06:28 +0300 Message-Id: <20240221200628.74174-5-mike.maslenkin@gmail.com> In-Reply-To: <20240221200628.74174-1-mike.maslenkin@gmail.com> References: <20240221200628.74174-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HNrMv7lG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This patch replaces value Private->Json with Json used as second argument for RedfishIdentifyResource(). Currently Json argument is not used at all and the pattern for caller side is: Status =3D RedfishIdentifyResourceCommon (Private, Private->Json); So in scope of RedfishIdentifyResourceCommon Json actually is the same value as Private->Json. Let's make code a bit cleaner. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- .../Features/BootOption/v1_0_4/Common/BootOptionCommon.c | 2 +- .../ComputerSystem/v1_13_0/Common/ComputerSystemCommon.c | 2 +- .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 2 +- RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/Re= dfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index 0ae841499692..f3f993c8782e 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar;=0D REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;=0D =0D - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json);=0D + Supported =3D RedfishIdentifyResource (Private->Uri, Json);=0D if (Supported) {=0D Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);=0D if (EFI_ERROR (Status)) {=0D diff --git a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionC= ommon.c b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionComm= on.c index 0b9f2bf28434..f471c01c3790 100644 --- a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c +++ b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCommon.c @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon ( {=0D BOOLEAN Supported;=0D =0D - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json);=0D + Supported =3D RedfishIdentifyResource (Private->Uri, Json);=0D if (Supported) {=0D return EFI_SUCCESS;=0D }=0D diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Comput= erSystemCommon.c b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/= ComputerSystemCommon.c index cee6c8bf9ba1..d69fc176ad94 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSyste= mCommon.c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/ComputerSyste= mCommon.c @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar;=0D REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;=0D =0D - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json);=0D + Supported =3D RedfishIdentifyResource (Private->Uri, Json);=0D if (Supported) {=0D Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);=0D if (EFI_ERROR (Status)) {=0D diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Compute= rSystemCommon.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Co= mputerSystemCommon.c index a67ef3dac283..11bcb5f76cab 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystem= Common.c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSystem= Common.c @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar;=0D REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;=0D =0D - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json);=0D + Supported =3D RedfishIdentifyResource (Private->Uri, Json);=0D if (Supported) {=0D Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);=0D if (EFI_ERROR (Status)) {=0D diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c = b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c index eb52c68c5dcb..00a69f748c3c 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon ( EFI_STRING EndOfChar;=0D REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;=0D =0D - Supported =3D RedfishIdentifyResource (Private->Uri, Private->Json);=0D + Supported =3D RedfishIdentifyResource (Private->Uri, Json);=0D if (Supported) {=0D Status =3D RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SC= HEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);=0D if (EFI_ERROR (Status)) {=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115738): https://edk2.groups.io/g/devel/message/115738 Mute This Topic: https://groups.io/mt/104495961/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-