From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53BA0AC0E68 for ; Fri, 23 Feb 2024 08:31:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=g0OPjIaAX6Eye5zdg/7pBYKdka5HdfX2r8xtwQizcJk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1708677072; v=1; b=Ry9bYYtG20TCZTnBV0f4p8IazvS1VFCrBA3xslhjFWUgvC9SPme8+pCVIhNuPazU1tKp/G7X QJ8Qd3K2YmJZORyI+rCItrZ4MTvZBUzzCnHlDLnBdP9jiO2KAm5S6zDBgkcFl5+oCFGo463/EuZ S6rHbUNJR/Ed2AtuJE43Lya0= X-Received: by 127.0.0.2 with SMTP id Z8IPYY7687511xw8izvLUctg; Fri, 23 Feb 2024 00:31:12 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.4740.1708569575328844396 for ; Wed, 21 Feb 2024 18:39:35 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="5720639" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="5720639" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2024 18:39:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="9920034" X-Received: from zhouji3x-z238.sh.intel.com (HELO zj3-desktop.ccr.corp.intel.com) ([10.239.152.99]) by fmviesa004.fm.intel.com with ESMTP; 21 Feb 2024 18:39:33 -0800 From: Zhou Jianfeng To: devel@edk2.groups.io Cc: Zhou Jianfeng , Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN Date: Thu, 22 Feb 2024 10:39:22 +0800 Message-Id: <20240222023922.29275-1-jianfeng.zhou@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jianfeng.zhou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: h8LA0LS8G851isqEa1SNat3Px7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ry9bYYtG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as IN. "IN" replaced with "IN OUT" in the following interfaces: PageTableLibSetPte4K(): Pte4K PageTableLibSetPleB(): PleB PageTableLibSetPle(): Ple PageTableLibSetPnle(): Pnle Reviewed-by: Ray Ni Signed-off-by: Zhou Jianfeng Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann --- .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c b/UefiCpu= Pkg/Library/CpuPageTableLib/CpuPageTableMap.c index ae4caf8dfe..2ea40666cc 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c @@ -20,10 +20,10 @@ **/=0D VOID=0D PageTableLibSetPte4K (=0D - IN IA32_PTE_4K *Pte4K,=0D - IN UINT64 Offset,=0D - IN IA32_MAP_ATTRIBUTE *Attribute,=0D - IN IA32_MAP_ATTRIBUTE *Mask=0D + IN OUT IA32_PTE_4K *Pte4K,=0D + IN UINT64 Offset,=0D + IN IA32_MAP_ATTRIBUTE *Attribute,=0D + IN IA32_MAP_ATTRIBUTE *Mask=0D )=0D {=0D IA32_PTE_4K LocalPte4K;=0D @@ -94,10 +94,10 @@ PageTableLibSetPte4K ( **/=0D VOID=0D PageTableLibSetPleB (=0D - IN IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB,=0D - IN UINT64 Offset,=0D - IN IA32_MAP_ATTRIBUTE *Attribute,=0D - IN IA32_MAP_ATTRIBUTE *Mask=0D + IN OUT IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB,=0D + IN UINT64 Offset,=0D + IN IA32_MAP_ATTRIBUTE *Attribute,=0D + IN IA32_MAP_ATTRIBUTE *Mask=0D )=0D {=0D IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE LocalPleB;=0D @@ -171,11 +171,11 @@ PageTableLibSetPleB ( **/=0D VOID=0D PageTableLibSetPle (=0D - IN UINTN Level,=0D - IN IA32_PAGING_ENTRY *Ple,=0D - IN UINT64 Offset,=0D - IN IA32_MAP_ATTRIBUTE *Attribute,=0D - IN IA32_MAP_ATTRIBUTE *Mask=0D + IN UINTN Level,=0D + IN OUT IA32_PAGING_ENTRY *Ple,=0D + IN UINT64 Offset,=0D + IN IA32_MAP_ATTRIBUTE *Attribute,=0D + IN IA32_MAP_ATTRIBUTE *Mask=0D )=0D {=0D if (Level =3D=3D 1) {=0D @@ -195,9 +195,9 @@ PageTableLibSetPle ( **/=0D VOID=0D PageTableLibSetPnle (=0D - IN IA32_PAGE_NON_LEAF_ENTRY *Pnle,=0D - IN IA32_MAP_ATTRIBUTE *Attribute,=0D - IN IA32_MAP_ATTRIBUTE *Mask=0D + IN OUT IA32_PAGE_NON_LEAF_ENTRY *Pnle,=0D + IN IA32_MAP_ATTRIBUTE *Attribute,=0D + IN IA32_MAP_ATTRIBUTE *Mask=0D )=0D {=0D IA32_PAGE_NON_LEAF_ENTRY LocalPnle;=0D -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115871): https://edk2.groups.io/g/devel/message/115871 Mute This Topic: https://groups.io/mt/104524856/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-