From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EE3F1D81163 for ; Thu, 22 Feb 2024 16:01:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zk7FkIVW7jCc8+AY7Og5H/Ize9AvYo3bP+wG/19hNTc=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1708617678; v=1; b=qDD9Fammcg9pXXiytlwUTQ51/pltBMBk4dOxM/Mz3TtniYNDrUqgjL9i8QeVxOnMmHZ2Gfgp ik0ORUBuc8EJkoec5KBBG+P82PkoFpFHdk8PO/U+/kP+Pc1tSMZi6qwzmEEsNHfbDCxKYf3yNeA lJxrU9Euo79Q66Z0gVTlz6uw= X-Received: by 127.0.0.2 with SMTP id m0VcYY7687511x9drnjex7e5; Thu, 22 Feb 2024 08:01:18 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16300.1708617677077005959 for ; Thu, 22 Feb 2024 08:01:17 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-ye1HHZBvN-CJGGRYydbmYw-1; Thu, 22 Feb 2024 11:01:13 -0500 X-MC-Unique: ye1HHZBvN-CJGGRYydbmYw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9DDE3816455; Thu, 22 Feb 2024 16:01:12 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B7AF200B436; Thu, 22 Feb 2024 16:01:12 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 49B811801F2C; Thu, 22 Feb 2024 17:01:06 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Laszlo Ersek , Ray Ni , Rahul Kumar , Oliver Steffen , Gerd Hoffmann Subject: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() Date: Thu, 22 Feb 2024 17:01:06 +0100 Message-ID: <20240222160106.686484-7-kraxel@redhat.com> In-Reply-To: <20240222160106.686484-1-kraxel@redhat.com> References: <20240222160106.686484-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XZG8pogrhDVE7hsfYWw0XQTVx7686176AA= Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qDD9Famm; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) After finding the BSP Number return the result instead of continuing to loop over the remaining processors. Suggested-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c index 4b6d6d02b027..2051554207dc 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1903,15 +1903,13 @@ GetBspNumber ( ) { UINT32 ApicId; - UINT32 BspNumber; UINT32 Index; CONST MP_HAND_OFF *MpHandOff; // // Get the processor number for the BSP // - BspNumber = MAX_UINT32; - ApicId = GetInitialApicId (); + ApicId = GetInitialApicId (); for (MpHandOff = FirstMpHandOff; MpHandOff != NULL; @@ -1919,14 +1917,13 @@ GetBspNumber ( { for (Index = 0; Index < MpHandOff->CpuCount; Index++) { if (MpHandOff->Info[Index].ApicId == ApicId) { - BspNumber = MpHandOff->ProcessorIndex + Index; + return MpHandOff->ProcessorIndex + Index; } } } - ASSERT (BspNumber != MAX_UINT32); - - return BspNumber; + ASSERT (FALSE); + return 0; } /** -- 2.43.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115831): https://edk2.groups.io/g/devel/message/115831 Mute This Topic: https://groups.io/mt/104510913/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-