From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F234AC06F1 for ; Tue, 27 Feb 2024 00:45:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VAu1fkCYuL/PfIRTqb7CDLRSGIDSxObGIb9tlYbDbFY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1708994737; v=1; b=Zpr1QyNZiueOtBGUjRmJWB4q/Kf62f6KENSeTOSX94jyTnBfiYzBC9yYii1/1/keAZVUsx+M s6j77a6kvrZkXAFGY7W8HdjWrkiRFNwRaQhvS2Ti42X57klq775P8Y3RGiIGgmSYTg9jFnxx93a 8i7csobLN/oq5kIc32lX0Dp4= X-Received: by 127.0.0.2 with SMTP id uNymYY7687511xuDYWZUtqGq; Mon, 26 Feb 2024 16:45:37 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.47]) by mx.groups.io with SMTP id smtpd.web10.1892.1708994736472886905 for ; Mon, 26 Feb 2024 16:45:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V1zSyrdyQ72FmgYO/t4lpzqvFJmK1CupbdIVA7ASKeN4bxV7tsNtamGH+x/QiDQwEl0kN/1VLdewUtfGZJh8VILAhg/1z6giW9s7oabiOlPSw2yZDMrhZBqRUj3wPYytHEH7afj2GHbFLxjZFTfHhMJncA9BsnBTE8K/O/99Yd3jxCAqvYwWdDe6oDviUuip+atwa/oL3IQ7tswUHvbaso3b5MglfyzBrHzA2aSPUuMURgUuZacAuCaFxPb8jWwD71vIqr62fit6iStoMHujrs2dRKsataImZsMWdwL1CsgJwhJfIdAI4XXGaHMzo1CdkK5f9Eo43q0ku62cV8zz9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5xO7keVzfC5I8/NjnuCgt4WZiZmq/feuyEy+/4Vm8A=; b=E9fBiXh5hFCBILpL1I4r1bjrNLf3G0AnOagn2BPt4mx3whjrG4UQbYtih4kcQHPsjEMyOFOJhWFT4in8Cyf4Q847tdKUSwZwAuPpZjidJNx5OjUW4shbYpGtk+alwUHWvDWQde2xAMU1fJ3Vq6MYm7e5IQsX6KQEBOYGGIeYW1ggNC80KoEjIrvr2sgy7pPtRt1lXnSK/QV/ASNk1f8QucaVZg5/+FVYFQA9YuqwX1YcCzkYEZoZNWr4mR9LC01ZHWaz6ztH5iEJ4HHeNvzCJ5F1UAXWFcqyDad9jnyqaGnSJGre7bx2c4GJRXoFlOl1HJd95Eu4jFoMVMkzsgJUDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CY8P220CA0037.NAMP220.PROD.OUTLOOK.COM (2603:10b6:930:47::7) by MW3PR12MB4585.namprd12.prod.outlook.com (2603:10b6:303:54::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Tue, 27 Feb 2024 00:45:33 +0000 X-Received: from CY4PEPF0000EE39.namprd03.prod.outlook.com (2603:10b6:930:47:cafe::38) by CY8P220CA0037.outlook.office365.com (2603:10b6:930:47::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend Transport; Tue, 27 Feb 2024 00:45:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000EE39.mail.protection.outlook.com (10.167.242.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Tue, 27 Feb 2024 00:45:32 +0000 X-Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 26 Feb 2024 16:45:22 -0800 X-Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 26 Feb 2024 16:45:21 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Mon, 26 Feb 2024 16:45:20 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH v3 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Date: Tue, 27 Feb 2024 08:45:20 +0800 Message-ID: <20240227004520.3607-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE39:EE_|MW3PR12MB4585:EE_ X-MS-Office365-Filtering-Correlation-Id: 66e131e7-ab1e-443f-8fdb-08dc372d6766 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 4SnCMKffwV6bhKPhc08gPXHi2QEhufB5QriGZbdj3QgDI/AIvcJmiDcSRfEBWO0XgD7hrQ20ZDkYGxHCPZLQQfDNYyqD9I3DKxDFAppjkFcCGz7CB22j1+6MdR0lPUyfKRb/IAfbkXXrtuIg4zpyFaRyKReKViEepRKIFq0TojHTyoEaLNH1umE7cVqsWoUBZ3GjJf0xT72ARqzxHVMU1xWPZtPIQ9qDWoKQg/qr4IYvnGQELsPaCCwRQS1MsPfsv+vFLobNWUGwox5b1H0JYSsX6RATH0IbqAS7S3oeCtq2ur5c9jLS6uHOcdfWhvqtuyUmJYODYvyqCCkve6fz1Gmaz2cgUFOzgV0nIZY58lrjztwotOn/ArAuFaaATJmZG5UiGWcyKVExuwl6NUvzz9RYjmyNUDzmYzWSiEts7xFS6I7J3EvT8YfLVoikyRWYmLiQ03b0FiKA5pirYpN0J8OjVhegkAf2iG2UFRrMoyje0pnK+IeeO8dQBYvXfoTLJ6MJ4At97/9ySF33/E4HJhEvt34iIh/j4fA5GwpSjroDCGksKMbhvVskop+Miea2wx+qt5+X1x/Q2aA1jB74EHuFnJVJ98TZ05ZHnZPfh1WaAY/rs5LQrZIl5eeLnl1RhitpbDbolcZr9+WSSB1zlpsEALvlQoxj9ICN24DzQj5s+UqRbgoGADHKKuPMagArAPuA74Pl0UXTEonEc2UoCIat9qz5+fVMZHgQmFr5uIYmi4KFPBkb8zuts+J05tcv X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 00:45:32.6661 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66e131e7-ab1e-443f-8fdb-08dc372d6766 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE39.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4585 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IAUXk5zfSLf89gjUe7crtXSxx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Zpr1QyNZ; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io -Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++- .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++ RedfishPkg/RedfishPkg.ci.yaml | 2 + 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf b/Re= dfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf index 6ff5dba75c..3a5e309d1a 100644 --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf @@ -3,6 +3,7 @@ # # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -23,6 +24,9 @@ [Sources] RedfishCrtLib.c =20 +[Sources.IA32] + Ia32/MathFtol.c | MSFT + [LibraryClasses] BaseLib SortLib @@ -35,4 +39,5 @@ MdeModulePkg/MdeModulePkg.dec RedfishPkg/RedfishPkg.dec =20 - +[BuildOptions] + MSFT:*_*_IA32_CC_FLAGS =3D /GL- diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c b/Redf= ishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c new file mode 100644 index 0000000000..e49f00eaf5 --- /dev/null +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c @@ -0,0 +1,37 @@ +/** @file This file is copied from CryptoPkg/Library/IntrinsicLib/Ia32/Mat= hFtol.c + 64-bit Math Worker Function. + The 32-bit versions of C compiler generate calls to library routines + to handle 64-bit math. These functions use non-standard calling conventi= ons. + +Copyright (c) 2019, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +/* + * Floating point to integer conversion. + */ +__declspec(naked) void +_ftol2 ( + void + ) +{ + _asm { + fistp qword ptr [esp-8] + mov edx, [esp-4] + mov eax, [esp-8] + ret + } +} + +__declspec(naked) void +_ftol2_sse ( + void + ) +{ + _asm { + fistp dword ptr [esp-4] + mov eax,[esp-4] + ret + } +} diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml index 69b6bf39f5..b95e8bfdc7 100644 --- a/RedfishPkg/RedfishPkg.ci.yaml +++ b/RedfishPkg/RedfishPkg.ci.yaml @@ -2,6 +2,7 @@ # CI configuration for NetworkPkg # # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -38,6 +39,7 @@ "PrivateInclude/Crt/string.h", "PrivateInclude/Crt/time.h", "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c", + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c", "Include/Library/RedfishCrtLib.h", ## ## For jansson library open source --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115989): https://edk2.groups.io/g/devel/message/115989 Mute This Topic: https://groups.io/mt/104594906/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-