From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: <devel@edk2.groups.io>
Cc: Abner Chang <abner.chang@amd.com>, Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol
Date: Thu, 29 Feb 2024 16:52:48 +0800 [thread overview]
Message-ID: <20240229085248.111772-1-nicklew@nvidia.com> (raw)
Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update
RedfishClientPkg to use RedfishHttpLib. And remove the use of
RedfishHttpCacheLib.
I also replace several functions from RedfishLib with the function
provided in RedfishHttpLib. In this way, there is no dependency on
RedfishLib in RedfishClientPkg.
I noticed that there is false alarm in uncrustify check. When there
are deleted files, uncrustiry cannot check them and trigger uncrustify
failure.
Pull request is created here for testing CI:
https://github.com/tianocore/edk2-redfish-client/pull/79
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Nickle Wang (13):
RedfishClientPkg/.github: do not run uncrustify to deleted file.
RedfishClientPkg: remove RedfishHttpCacheLib
RedfishClientPkg: ues RedfishHttpLib
RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib
RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib
RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib
RedfishClientPkg/BiosDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib
RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib
RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryDxe: ues RedfishHttpLib
RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib
RedfishClientPkg/RedfishClientPkg.dec | 1 -
RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +-
RedfishClientPkg/RedfishClientPkg.dsc | 1 -
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +-
.../BootOptionCollectionDxe.inf | 5 +-
.../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
.../ComputerSystemCollectionDxe.inf | 3 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
.../MemoryCollectionDxe.inf | 3 +-
.../EdkIIRedfishResourceConfigLib.inf | 2 +-
.../RedfishFeatureUtilityLib.inf | 3 +-
.../RedfishHttpCacheLib.inf | 48 --
.../RedfishVersionLib/RedfishVersionLib.inf | 3 +-
.../Library/EdkIIRedfishResourceConfigLib.h | 4 +-
.../Library/RedfishFeatureUtilityLib.h | 46 +-
.../Include/Library/RedfishHttpCacheLib.h | 59 --
.../Include/RedfishCollectionCommon.h | 3 +-
.../Include/RedfishResourceCommon.h | 3 +-
.../RedfishFeatureUtilityInternal.h | 3 +-
.../RedfishHttpCacheLibInternal.h | 63 --
.../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +--
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +--
.../v1_0_4/Common/BootOptionCommon.c | 45 +-
.../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +-
.../BootOptionCollectionDxe.c | 26 +-
.../v1_13_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +-
.../v1_5_0/Common/ComputerSystemCommon.c | 68 +-
.../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +-
.../ComputerSystemCollectionDxe.c | 15 +-
.../Memory/V1_7_1/Common/MemoryCommon.c | 86 +-
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +--
.../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +-
.../EdkIIRedfishResourceConfigLib.c | 6 +-
.../RedfishFeatureUtilityLib.c | 182 +---
.../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------
.../RedfishVersionLib/RedfishVersionLib.c | 24 +-
.github/workflows/uncrustify-check.sh | 17 +-
40 files changed, 328 insertions(+), 1838 deletions(-)
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116140): https://edk2.groups.io/g/devel/message/116140
Mute This Topic: https://groups.io/mt/104640214/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-02-29 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 8:52 Nickle Wang via groups.io [this message]
2024-02-29 9:04 ` [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Laszlo Ersek
2024-02-29 9:08 ` Nickle Wang via groups.io
2024-03-01 0:07 ` Mike Maslenkin
2024-03-01 1:24 ` Nickle Wang via groups.io
2024-03-05 17:50 ` Igor Kulchytskyy via groups.io
2024-03-06 6:40 ` Nickle Wang via groups.io
2024-03-04 2:03 ` Chang, Abner via groups.io
2024-03-05 18:14 ` Igor Kulchytskyy via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229085248.111772-1-nicklew@nvidia.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox