From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 16CFCAC0DE0 for ; Thu, 29 Feb 2024 08:54:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=exBhU3Ar+4ObH82tR81y5i0itiFwPC/Mu8MFsBLIU40=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1709196895; v=1; b=GDITiW6q60+sRGK3nuT+Eyxb4jBfL/UNr7aJbt9Cme/15FlbiYIjZ98AMkFsWL9SdljAaEwS Vbl/XHvrFltUeveW5BH3gAWWNJRaNnh9AnSNoSORXhZmGaT2CT8JVDsvopRNvlA8EAoxw2tAM8p c2ElE4YKRmOfWcFgWqvE3mws= X-Received: by 127.0.0.2 with SMTP id jaKYYY7687511xIUu9jbJ7Ej; Thu, 29 Feb 2024 00:54:55 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.58]) by mx.groups.io with SMTP id smtpd.web11.19930.1709196895265970719 for ; Thu, 29 Feb 2024 00:54:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O7rHHP97xDW5f1aU0qJLDzXAxJzYVU1oV58eBPyBncaaaTXZ2JNVFJgiTCDKpx5QR5CvaZ4K5TU86Tdm2ef4NTngXTslwZx1PFCfHwuEcVEjvHgyh2ox2P2Zq7Xk0lYTLZSCS9rBOSyYMkTzOnpc/GrQgwcqHyMfU9cT2Lw5gcqmclxFae8/laWOgHSNkBdA0X09U0BcPpfIjrWzMv2R5xHFD4jEsBor1HODzp8cHWcMc3Eyh/Y+XX0MJHliCBxDk7rMIrO7SAdJtcS70Q5eDc+MZB2yjNf3vSpzBMzLqxwqN27MCuDqybnVzy9O5AHdYqscud2Epbse4Wawiay8CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M25Bjefh+kT6zOEGGPK7VtsmUwBZUssY4vGlr7afTjg=; b=PyVeQcupVqFGaeazb+IxtjHcQyCKbHyKSmhvMBSslwSuOokX9yIELYIirFg1oUb+z/kHzqbJX7ec30RpriFW3zkgBA91amfjq1PTIDTJi23S+ZnW70myFhYDnZAwHybv2cMcNMIAcdhU25c2Lip/MPyeBl3kN9yDLmlAU8Jq5Z1VY2NrtyMrcGMmT644PAcP8bcO3MkAIHU/+XBxpk2ImydQcTUsG9srLANyj0/hPBfgP7qlQjsNtROW5+xXrcmzB09utRTfhJeekv5IXzEBZxEhhjOgX2bQh2UkeCGLEi6DxFupoqmmib6Ke0bhLyihItEchvy/rBp379vPn7A/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CH0PR03CA0418.namprd03.prod.outlook.com (2603:10b6:610:11b::19) by CY8PR12MB9035.namprd12.prod.outlook.com (2603:10b6:930:77::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 29 Feb 2024 08:54:52 +0000 X-Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:11b:cafe::f9) by CH0PR03CA0418.outlook.office365.com (2603:10b6:610:11b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.30 via Frontend Transport; Thu, 29 Feb 2024 08:54:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Thu, 29 Feb 2024 08:54:52 +0000 X-Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 29 Feb 2024 00:54:29 -0800 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 29 Feb 2024 00:54:28 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Thu, 29 Feb 2024 00:54:27 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH 06/13] RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib Date: Thu, 29 Feb 2024 16:54:27 +0800 Message-ID: <20240229085427.112372-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|CY8PR12MB9035:EE_ X-MS-Office365-Filtering-Correlation-Id: 55a6a357-d302-4aa2-138a-08dc390417ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: k4vauhi1LktKJwyuXDuYHmrG84lWTpSX3XTMskNuBbKAV+PgdMQxnBpU1Joum+TIEaTO3w8SRozZyiYtMaKISZnKVGM1lgZcA3gRQ6rnSkfwtC+BNHAC9hE4dw50NwzPO0GnIs9vsOn2nJ9y9obxecoB+PEqNNUwosmK/xRHhgWvG5NLhuVKlGWxyjVRPuptCZLHzNzMckOJKwK8P5LlZ6jXTHjhJe85gwW/NuNMYeijSFaTMxLFEVd0UMthjJovddzOWocM2BN9kDxKXtV0Nlnpgo9IfPmvf1CtvSAy7ifipeiDm+oj105u96KNwXOyPaPgcbbkypjnmx/2rpQ8XhsMajhfDUgNoeErBiR+X57Ttoqg6+Hs9r6My518AvRCycCtXOBwzBao8DX3Ep8AU11z47Rre0eRy8MXzjB8eozPM0VQo11kOLvIFTKIBcsCVcDv7356gvICmbeDwsCwhVXNBiZTLNDI1uW9FpVMBz36qhIsMdbpaMF+DcXxd/tuKqw1JUgvE8fhO20vL8yJd2r7RYbgUdyCvSAPf94trt72AYJ6YXFh0uJV6xfW7LHMkUY8Re9HuU1hkgDNQtZwa4FcgPp4wp4ZIAMYivWxAiooYXv3dv0M3273nxQi52Rta09MG0kfFGV7GHMAvhS0hqCQCN4LruweYxpGhIrGi9ej1JNWaWXRnw/+Lx7Lhd110NUhNXzGcWKXUgC/keMKjaN3Yb3fCcd/p0GijdGxf4vvV7v6GIr4D9xgGoc54c1j X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 08:54:52.1086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55a6a357-d302-4aa2-138a-08dc390417ee X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB9035 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qHSyhYaEiagIbzbOWQOiMDc6x7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GDITiW6q; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishVersionLib/RedfishVersionLib.inf | 3 +-- .../RedfishVersionLib/RedfishVersionLib.c | 24 +++---------------- 2 files changed, 4 insertions(+), 23 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.i= nf b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.inf index 10e335af3..5c3f4de39 100644 --- a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.inf +++ b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.inf @@ -36,9 +36,8 @@ DebugLib MemoryAllocationLib PcdLib - RedfishLib + RedfishHttpLib JsonLib - RedfishHttpCacheLib =20 [Protocols] =20 diff --git a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c= b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c index 828693766..a55238d22 100644 --- a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c +++ b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c @@ -14,11 +14,10 @@ #include #include #include -#include +#include #include #include #include -#include =20 #define REDFISH_VERSION_DEFAULT_STRING L"v1" #define REDFISH_ROOT_URI L"/redfish" @@ -112,22 +111,12 @@ RedfishGetVersion ( Status =3D RedfishHttpGetResource ( Service, REDFISH_ROOT_URI, + NULL, &Response, TRUE ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a, RedfishGetByService to %s failed: %r\n", __f= unc__, REDFISH_ROOT_URI, Status)); - if (Response.Payload !=3D NULL) { - RedfishDumpPayload (Response.Payload); - RedfishFreeResponse ( - NULL, - 0, - NULL, - Response.Payload - ); - Response.Payload =3D NULL; - } - goto ON_ERROR; } =20 @@ -156,14 +145,7 @@ ON_ERROR: VersionString =3D REDFISH_VERSION_DEFAULT_STRING; } =20 - if (Response.Payload !=3D NULL) { - RedfishFreeResponse ( - Response.StatusCode, - Response.HeaderCount, - Response.Headers, - Response.Payload - ); - } + RedfishHttpFreeResponse (&Response); =20 DEBUG ((DEBUG_MANAGEABILITY, "%a: Redfish version - %s\n", __func__, Ver= sionString)); return AllocateCopyPool (StrSize (VersionString), VersionString); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116146): https://edk2.groups.io/g/devel/message/116146 Mute This Topic: https://groups.io/mt/104640227/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-