From: "Nickle Wang via groups.io" <nicklew=nvidia.com@groups.io>
To: <devel@edk2.groups.io>
Cc: Abner Chang <abner.chang@amd.com>, Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-devel] [edk2-redfish-client][PATCH 09/13] RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib
Date: Thu, 29 Feb 2024 16:54:48 +0800 [thread overview]
Message-ID: <20240229085448.112591-1-nicklew@nvidia.com> (raw)
Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
.../BootOptionCollectionDxe.inf | 5 ++--
.../BootOptionCollectionDxe.c | 26 ++++---------------
2 files changed, 7 insertions(+), 24 deletions(-)
diff --git a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.inf b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.inf
index 7977fa461..90aae8e9e 100644
--- a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.inf
+++ b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.inf
@@ -3,7 +3,7 @@
# Redfish BootOptionCollection collection driver.
#
# (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP<BR>
-# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -35,13 +35,12 @@
ConverterCommonLib
MemoryAllocationLib
RedfishFeatureUtilityLib
- RedfishLib
+ RedfishHttpLib
UefiLib
UefiDriverEntryPoint
UefiBootServicesTableLib
EdkIIRedfishResourceConfigLib
RedfishVersionLib
- RedfishHttpCacheLib
UefiBootManagerLib
DevicePathLib
diff --git a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.c b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.c
index 54cabcbe8..4f94a4495 100644
--- a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.c
+++ b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe.c
@@ -3,7 +3,7 @@
Redfish feature driver implementation - BootOptionCollection
(C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP<BR>
- Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -169,7 +169,7 @@ MarkBootOptionProcessed (
// Get boot option reference attribute
//
ZeroMem (&Response, sizeof (REDFISH_RESPONSE));
- Status = RedfishHttpGetResource (RedfishService, Uri, &Response, TRUE);
+ Status = RedfishHttpGetResource (RedfishService, Uri, NULL, &Response, TRUE);
if (EFI_ERROR (Status) || (Response.Payload == NULL)) {
DEBUG ((DEBUG_ERROR, "%a: failed to get resource from %s: %r", __func__, Uri, Status));
return Status;
@@ -212,12 +212,7 @@ MarkBootOptionProcessed (
ON_RELEASE:
- RedfishFreeResponse (
- Response.StatusCode,
- Response.HeaderCount,
- Response.Headers,
- Response.Payload
- );
+ RedfishHttpFreeResponse (&Response);
return Status;
}
@@ -436,18 +431,7 @@ ReleaseCollectionResource (
//
// Release resource
//
- if (Private->Response.Payload != NULL) {
- RedfishFreeResponse (
- Private->Response.StatusCode,
- Private->Response.HeaderCount,
- Private->Response.Headers,
- Private->Response.Payload
- );
- Private->Response.StatusCode = NULL;
- Private->Response.HeaderCount = 0;
- Private->Response.Headers = NULL;
- Private->Response.Payload = NULL;
- }
+ RedfishHttpFreeResponse (&Private->Response);
if (Private->CollectionJson != NULL) {
FreePool (Private->CollectionJson);
@@ -478,7 +462,7 @@ CollectionHandler (
//
// Query collection from Redfish service.
//
- Status = RedfishHttpGetResource (Private->RedfishService, Private->CollectionUri, &Private->Response, TRUE);
+ Status = RedfishHttpGetResource (Private->RedfishService, Private->CollectionUri, NULL, &Private->Response, TRUE);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: unable to get resource from: %s :%r\n", __func__, Private->CollectionUri, Status));
goto ON_RELEASE;
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116148): https://edk2.groups.io/g/devel/message/116148
Mute This Topic: https://groups.io/mt/104640231/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
reply other threads:[~2024-02-29 8:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229085448.112591-1-nicklew@nvidia.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox