From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 06A5F740053 for ; Thu, 29 Feb 2024 08:55:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wL8bWaSEf05zHHZhyMjroAvXaRLjnuoqcAyhXm96O9k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1709196927; v=1; b=EisAU062lsapQFv4YoBxnskVigabAg+IN6hooEe/NjNW11Qgzt2Oiwso1gBuW2+N4Sm/T+2n BCLKyFBp7AsQueX57chV+7dQm2u3c9IRPMebXB78JALrjNjx3u70kb/d0YNYML4xu2z+E3ZcCuE 4jHQkG0xslUpm3YdqhDotTzw= X-Received: by 127.0.0.2 with SMTP id ornjYY7687511xIGRbxE8lFC; Thu, 29 Feb 2024 00:55:27 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.74]) by mx.groups.io with SMTP id smtpd.web10.20247.1709196927052831294 for ; Thu, 29 Feb 2024 00:55:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=becy0ntskaB+idIxxHwXnI+kgF+6yGu7aKGBEPmwMPvVPsxR9NNO+XPd9NWcSuW+ag9ffYTOlv0plc1PEDDm9QO5w/XVdKT3NRMx56ebdCd7X+cj8Ckl8Mg6VgUwmo+RnstAIjeF8w+SYW0m/etLLrkDLngSVqSHRVQuIqcEDPyjJ2+wMlAPS1tvi+usGC3L0ZXIFVUHKj8dpX07MMfHr5jf08Ca2rfJgiXjbyVdeza4RI7WxSPjFLTxApr6AAaVchryG99I0Xk0tLrlGmtjfcb59uT2OCpsIFkLmRs16bYhUG1BZY+OHPlsiE3ZEMp8BSDNwBBoUIiDccsHhdKHUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jR/YyilaJC08TQJq08cxi6xVTzEUnZ5QcOj88SFugAc=; b=Y2vbsotftTByqoh14JvqaI7+qzyy5/ck0PeLYJuDGNTPTdiGHUzTVGnEnMdWLviC2c+yXaYMtTTKaQXjMfBJdZiKrTCGcyCss4JNYRI5BZUYMLeWlGdYSOhldhBGp0irFwL9nryY5c4hIZYky7Gw4E2vI87MP1pFUd9fOXhHdtuLHqLzpT3+AED5HCByvhhqwM/W+OyaZ6/F0gjRBVKypJ87QtB6fbMQL7TpsASkuNNQ3N3DFSGjZau3kP1+KlNz09uA7TfhYorFuAOEWsdHR5fW+7khZM5vkJJZDT7O5EhyJS3ABMmgaEkXgY3/z7JqYdYatZ0E5bUvLriYvo/UHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CH2PR14CA0057.namprd14.prod.outlook.com (2603:10b6:610:56::37) by CY8PR12MB7756.namprd12.prod.outlook.com (2603:10b6:930:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Thu, 29 Feb 2024 08:55:24 +0000 X-Received: from CH1PEPF0000A345.namprd04.prod.outlook.com (2603:10b6:610:56:cafe::2e) by CH2PR14CA0057.outlook.office365.com (2603:10b6:610:56::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend Transport; Thu, 29 Feb 2024 08:55:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A345.mail.protection.outlook.com (10.167.244.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Thu, 29 Feb 2024 08:55:24 +0000 X-Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 29 Feb 2024 00:55:05 -0800 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 29 Feb 2024 00:55:04 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Thu, 29 Feb 2024 00:55:03 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH 11/13] RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib Date: Thu, 29 Feb 2024 16:55:02 +0800 Message-ID: <20240229085502.112734-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A345:EE_|CY8PR12MB7756:EE_ X-MS-Office365-Filtering-Correlation-Id: f0730cb0-529d-4c64-28c4-08dc39042af2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: WS/RIID3C/e2E2YG72TgGUJTjbq57KHO1BNrflwUM98aH1J+qoiy9rml0j4fNTG0Nrsj+lxCIWbpbvEAWP5eoUCKLHLFlYDTUpAsHbL0w2id5DMq3zXvlcJNXgWlXJTA907t2CJauxYSAEESy5YRpov7r9IbpWeEH6lUQwLtt1c3TXCL8suQFAsw+eFbu0vEW9fpi3noEjydoHimmDjBqOSlzEaufGafvAK7bZfEJbpMmmiNiq6g0Ehd8kZANNn0+P2NON194i6lQsXkbq12OmY6zIZmolVsN3Ybg1ouTTyT7+qwQkshQwP78/+3D/ImUQr6eLdrg49OOx1zofOfdjCuI7EJdWD2JUgeP3WWhBeVWX3w7k/4njNQwQ7onIXfCUQfkYcqqRaCYooRa5en+uoZOxoCgGyNEcIV8CHn6WfpeqIOZ99pXUNnEQjvFO58go4nVKV0FGDncsmkroHM3rg1pED+f0m8EyFUE5nSj6GYHCI70lnOCn+xP5bL8QcS0NxemtlNO0RnrCsO/ogIScAV3r9mbSTiD7NfVxuQ5rXcFW+lS56ITy9UEn/6hEqiaFVCgs/9JD+GnVMkl0XCeUZ/WYYEcuPD3pM9ffs49cDyxHJKl/EULAfTNy5/pwRNV0VZ49b+WmizH7pmMFIwx9jm/877zdDkz0leVRlBQuswvMFUMzfgNbk0ET8d6dO9CADTStmpbfk6BsQO+MA0AGrJW86ZbslGQt9DtWkAKw/eWwzqDpUxE6WrwY0CqZUj X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 08:55:24.1058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0730cb0-529d-4c64-28c4-08dc39042af2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A345.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7756 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nMisQEaPtIVLmEd8jybPNvSCx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EisAU062; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../ComputerSystemCollectionDxe.inf | 3 +-- .../ComputerSystemCollectionDxe.c | 15 ++------------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/Computer= SystemCollectionDxe.inf b/RedfishClientPkg/Features/ComputerSystemCollectio= nDxe/ComputerSystemCollectionDxe.inf index b848f69f9..7c00f8f56 100644 --- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.inf +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.inf @@ -35,13 +35,12 @@ ConverterCommonLib MemoryAllocationLib RedfishFeatureUtilityLib - RedfishLib + RedfishHttpLib UefiLib UefiDriverEntryPoint UefiBootServicesTableLib EdkIIRedfishResourceConfigLib RedfishVersionLib - RedfishHttpCacheLib =20 [Protocols] gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMED diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/Computer= SystemCollectionDxe.c b/RedfishClientPkg/Features/ComputerSystemCollectionD= xe/ComputerSystemCollectionDxe.c index 05d746252..975ba0564 100644 --- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c +++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemC= ollectionDxe.c @@ -256,18 +256,7 @@ ReleaseCollectionResource ( // // Release resource // - if (Private->Response.Payload !=3D NULL) { - RedfishFreeResponse ( - Private->Response.StatusCode, - Private->Response.HeaderCount, - Private->Response.Headers, - Private->Response.Payload - ); - Private->Response.StatusCode =3D NULL; - Private->Response.HeaderCount =3D 0; - Private->Response.Headers =3D NULL; - Private->Response.Payload =3D NULL; - } + RedfishHttpFreeResponse (&Private->Response); =20 if (Private->CollectionJson !=3D NULL) { FreePool (Private->CollectionJson); @@ -298,7 +287,7 @@ CollectionHandler ( // // Query collection from Redfish service. // - Status =3D RedfishHttpGetResource (Private->RedfishService, Private->Col= lectionUri, &Private->Response, TRUE); + Status =3D RedfishHttpGetResource (Private->RedfishService, Private->Col= lectionUri, NULL, &Private->Response, TRUE); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: unable to get resource from: %s :%r\n", __fu= nc__, Private->CollectionUri, Status)); goto ON_RELEASE; --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116152): https://edk2.groups.io/g/devel/message/116152 Mute This Topic: https://groups.io/mt/104640235/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-