From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 315D5AC0E35 for ; Thu, 29 Feb 2024 08:55:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8ThloqyyPlPwJ65mme3Z6vgbkyBsY052TxS0up9mcl4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1709196939; v=1; b=C/yi1gKaJscsLYMAKKJ2eaxbf2SpalelN58b5pfpXbrkXONQd15/ZZWfFBFHL/USzGpXQbuk wjfpoK8j54XtXYtxZz9c6qYNTtnM/wid9YDY5tpFPJu1KHuX/Qeeg6UhWr1f4Etabgrg/cxYxnn EOgqBIaUx8Fpd1L3jwmRNTu4= X-Received: by 127.0.0.2 with SMTP id uVfsYY7687511xJRy1bWn4a5; Thu, 29 Feb 2024 00:55:39 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.78]) by mx.groups.io with SMTP id smtpd.web11.19942.1709196939297861837 for ; Thu, 29 Feb 2024 00:55:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uuih17Eqx2rgldR9hYXPHqB590/Ep5uYBbPNSR3N+l2/eLCkT6b96KXvgpfplvb0IB+64A6EwsYkr9Q3GPYbSYLTp1hTx3wGqaYONvuGU+RhjdthI5zZYkaNl1xMOUT5qe0CqkAJG3q458s7W7y6/ZL/4sly4CQC0/88D1hw/u3B14e/UJ0AbQ6JaxzXnkHwHkCrrNTdKg/LTwNM0hPo+Dm/XqxuvK+mDxZ7Ek2sDt59FTLlwX79bBnBDR1hT3ABWx+Bi9iXujFf74rKI6oypFqnsuPGANC1/4oouVBa/ypHMTpNC2mhoUiIFkeoLpM5IyF1wFDP/ZblmV5csHkAyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4MRU9n4BSckjFHh6cKf/8TyQ6HGB1y4RPt0oAcZxA8Y=; b=GzDt26z3Mc3Mss6EbQHlOBJxOW6IRsJtM9Y9q8KBXKgPG6ijxnNbfHI36PbPow4vzD6QENrTu6CCKBFK0L1l8AzxX4iUDriJjZR3G0ZgkgTWh7jQcAG/T8HOtgJEEKCl7wVAGsCQgzsSanqizbRZsjrQ+W4dKD9ULuKGowo+3TnNMi1F/GqR+ft0C8ZGFMSX3gn5NEEStlPTifLsOVbPXkxJYWY4TEhsImiKfGHT7DDNSi1cPSgac+qo3ve6lLg3FKCtRtUAyksAycgLVW3rqdnYXoMm6VXa6AktZNP16LYzsspIMMoIXYXWLxF17C3eO0MgrQJ7/S2wiQnbNaLJBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from CH5PR05CA0020.namprd05.prod.outlook.com (2603:10b6:610:1f0::13) by DM4PR12MB6592.namprd12.prod.outlook.com (2603:10b6:8:8a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Thu, 29 Feb 2024 08:55:36 +0000 X-Received: from CH1PEPF0000A349.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::4a) by CH5PR05CA0020.outlook.office365.com (2603:10b6:610:1f0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.13 via Frontend Transport; Thu, 29 Feb 2024 08:55:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A349.mail.protection.outlook.com (10.167.244.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Thu, 29 Feb 2024 08:55:36 +0000 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 29 Feb 2024 00:55:18 -0800 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 29 Feb 2024 00:55:17 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Thu, 29 Feb 2024 00:55:16 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-redfish-client][PATCH 13/13] RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib Date: Thu, 29 Feb 2024 16:55:15 +0800 Message-ID: <20240229085515.112880-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A349:EE_|DM4PR12MB6592:EE_ X-MS-Office365-Filtering-Correlation-Id: 492c90d0-6c7f-49eb-f040-08dc39043212 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 3DfJdrxpglvtq5op+AB/xhKW5HMwvOtuhVql/Ednjf7joTBp1yPR1fi/VluZUFGFCvhcBuzl+cSTcsZGj7uJQOQBirIKhDwpWk9AqWnqOCZyXeYAqysv8XRriwjav3mvTqdBi1I1B4/GxmsrJat3652BPIRMIng6Ly2f+6qkXA8USAQuQisBwLNp3i4MtRrPwiKFVWpWDc1BFSaqr8YoHA+qSwU9bCpslbjbzszm7c7n0/lBE1e5+SBJNsSOQuRl08Nwi9YsdO+aS4b+cCHbawnqfjSrQZUkWF95C9qwnk4APubttaH/iRc9hOjEzEmg/i10yogCg8M5b8Z/CIpUJwJbQvbT6jxa574kzpdhD3E9qpc39CcHO09ngd7xqCVqbqpqq8YGjXiHb33YoohBp/wPwLIMBFTFBVpTG3V/U+EKIHviBq1WtSI33uqVcoFG00pw6L1kYKYvZlNmkjSWF1CfOpgP8irJ7UFUbvPVjHyL87kPs4tSQ6lpplh4vOPQ4dKxdVejJNam227czON4MdGAEg7z2GfD+jEDDMum8PRHwKmsdN2Ek3qPS5Bbzrw0G/oxGOSjflrQ9kqlj69BgnvV43lenz01N1Lu2jhnte0/qfC9xQvLts0H4P3kJXLDcaVMx6Ne0xu97iqeWENuPNv45QZlwsE04v6be+WAfMTymtn7XTFcvB6cUTIrG/EIKz6cqYyyiqGRpvim9049thqF3EdkwGh2dtFvSR1CGFYv4psfXS1WK8tsuamDvbN3 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 08:55:36.0490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 492c90d0-6c7f-49eb-f040-08dc39043212 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A349.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6592 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2V6sqJMw95dFFA78DuMOSJY4x7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="C/yi1gKa"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Use EDK2 RedfishHttpLib to replace RedfishHttpCacheLib and RedfishLib Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../MemoryCollectionDxe/MemoryCollectionDxe.inf | 3 +-- .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 ++------------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollection= Dxe.inf b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe= .inf index 67c38f62d..97c59000c 100644 --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf @@ -35,13 +35,12 @@ ConverterCommonLib MemoryAllocationLib RedfishFeatureUtilityLib - RedfishLib + RedfishHttpLib UefiLib UefiDriverEntryPoint UefiBootServicesTableLib EdkIIRedfishResourceConfigLib RedfishVersionLib - RedfishHttpCacheLib =20 [Protocols] gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMED diff --git a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollection= Dxe.c b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c index 2127570fb..1b7d74e86 100644 --- a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c +++ b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c @@ -247,18 +247,7 @@ ReleaseCollectionResource ( // // Release resource // - if (Private->Response.Payload !=3D NULL) { - RedfishFreeResponse ( - Private->Response.StatusCode, - Private->Response.HeaderCount, - Private->Response.Headers, - Private->Response.Payload - ); - Private->Response.StatusCode =3D NULL; - Private->Response.HeaderCount =3D 0; - Private->Response.Headers =3D NULL; - Private->Response.Payload =3D NULL; - } + RedfishHttpFreeResponse (&Private->Response); =20 if (Private->CollectionJson !=3D NULL) { FreePool (Private->CollectionJson); @@ -289,7 +278,7 @@ CollectionHandler ( // // Query collection from Redfish service. // - Status =3D RedfishHttpGetResource (Private->RedfishService, Private->Col= lectionUri, &Private->Response, TRUE); + Status =3D RedfishHttpGetResource (Private->RedfishService, Private->Col= lectionUri, NULL, &Private->Response, TRUE); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a, unable to get resource from: %s :%r\n", __fu= nc__, Private->CollectionUri, Status)); goto ON_RELEASE; --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116153): https://edk2.groups.io/g/devel/message/116153 Mute This Topic: https://groups.io/mt/104640238/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-