From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C7B13AC090A for ; Fri, 1 Mar 2024 03:05:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=F8tXvbL0Zssn6vKIgCERh4gYJZ5rQm5fszVJiCKbP0U=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1709262346; v=1; b=CvG5HOG/JzXcQ3OeFgXKAFKk6Ku84qLclIZlP4uYlFIG67vVQEuZZoTuOxn8GftJ5UQobQH/ l3IwPdF8FKBuJVTGjfQQyvjgJIS42eKfPhGGFAEcEf9Nfqcdp7DDU6vRGkmcM/gL2+MahfAPl19 Z9Za5whAnmQClMbNxwVWAvDk= X-Received: by 127.0.0.2 with SMTP id m1irYY7687511xXaMRnDlCV1; Thu, 29 Feb 2024 19:05:46 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mx.groups.io with SMTP id smtpd.web10.14105.1709262340273339436 for ; Thu, 29 Feb 2024 19:05:46 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="3955934" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="3955934" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 19:05:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="8181903" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 19:05:43 -0800 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Liming Gao , Jiaxin Wu , Ray Ni , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [PATCH v3 3/4] StandaloneMmPkg: Support to unregister MMI handler inside MMI handler Date: Fri, 1 Mar 2024 11:01:32 +0800 Message-Id: <20240301030133.628-4-zhiguang.liu@intel.com> In-Reply-To: <20240301030133.628-1-zhiguang.liu@intel.com> References: <20240301030133.628-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7nPhi3oVfpQyhOVM52IUFsnWx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="CvG5HOG/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io To support unregister MMI handler inside MMI handler itself, get next node before MMI handler is executed, since LIST_ENTRY that Link points to may be freed if unregister MMI handler in MMI handler itself. Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Ray Ni Reviewed-by: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu --- StandaloneMmPkg/Core/Mmi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c index 0de6fd17fc..c1a1d76e85 100644 --- a/StandaloneMmPkg/Core/Mmi.c +++ b/StandaloneMmPkg/Core/Mmi.c @@ -154,9 +154,14 @@ MmiManage ( Head = &MmiEntry->MmiHandlers; } - for (Link = Head->ForwardLink; Link != Head; Link = Link->ForwardLink) { + for (Link = Head->ForwardLink; Link != Head;) { MmiHandler = CR (Link, MMI_HANDLER, Link, MMI_HANDLER_SIGNATURE); - + // + // To support unregister MMI handler inside MMI handler itself, + // get next node before handler is executed, since LIST_ENTRY that + // Link points to may be freed if unregister MMI handler. + // + Link = Link->ForwardLink; Status = MmiHandler->Handler ( (EFI_HANDLE)MmiHandler, Context, -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116205): https://edk2.groups.io/g/devel/message/116205 Mute This Topic: https://groups.io/mt/104657668/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-