From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C704AC12DB for ; Mon, 4 Mar 2024 11:38:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CRFu9j2wW9CG9HxrPavll/Ps7OVDggRzAFXY/8nAk8U=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709552280; v=1; b=L9W3Y3ayp/+9amoJloJFL9svw67h+8BWreJIZO+5cODtxfjIjmiXjERzWBu1+OCSurTuYYBQ y7Tspa0Ir6S28Gu75frUM0JrqTwMRK6Y4DVwYeU5Snjf84qeGh01C7a5HMRLLP7IxIkrvr6dRQZ tjtkoYnipnS9DnblaXVV8ZjI= X-Received: by 127.0.0.2 with SMTP id 5nFuYY7687511xnhIvfRJnLX; Mon, 04 Mar 2024 03:38:00 -0800 X-Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.groups.io with SMTP id smtpd.web10.96186.1709552279664607996 for ; Mon, 04 Mar 2024 03:38:00 -0800 X-Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33e17fc5aceso1932949f8f.0 for ; Mon, 04 Mar 2024 03:37:59 -0800 (PST) X-Gm-Message-State: bur2zKholkTY2ihj43dnW9NAx7686176AA= X-Google-Smtp-Source: AGHT+IH0DWlbkzydbmYDYYal4r4rvlAeitVB2OK2YDREKP+HFq6wRkjtW+0K38xdvT8X8TQCJcROIQ== X-Received: by 2002:adf:c788:0:b0:33e:def:8a26 with SMTP id l8-20020adfc788000000b0033e0def8a26mr7724860wrg.12.1709552278038; Mon, 04 Mar 2024 03:37:58 -0800 (PST) X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id b6-20020a170902650600b001dbb0348733sm8448777plk.67.2024.03.04.03.37.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2024 03:37:57 -0800 (PST) Date: Mon, 4 Mar 2024 19:37:52 +0800 From: "joeyli via groups.io" To: devel@edk2.groups.io Cc: Laszlo Ersek , Gao@linux-l9pv.suse, Liming , Michael D Kinney , joeyli.kernel@gmail.com, Gerd Hoffmann , Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Subject: Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again Message-ID: <20240304113752.GK31128@linux-l9pv.suse> References: <20240204092914.29813-1-jlee@suse.com> <3662a1f0-b06a-f53c-25ce-91c95e8dec59@redhat.com> <20240207075549.GZ21608@linux-l9pv.suse> <17B185EB8F3EA51B.19081@groups.io> MIME-Version: 1.0 In-Reply-To: <17B185EB8F3EA51B.19081@groups.io> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=L9W3Y3ay; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: > On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: > > Hi Laszlo, > > > > First, thanks for your review! > > > > On Mon, Feb 05, 2024 at 05:41:25PM +0100, Laszlo Ersek wrote: > > > On 2/4/24 10:29, Lee, Chun-Yi wrote: > > > > In case PcdFirmwareReleaseDateString is not set use a valid date > > > > as fallback. But the default valid date can _NOT_ pass the Microsoft > > > > SVVP test "Check SMBIOS Table Specific Requirements". The test emitted > > > > the error message: > > > > > > > > BIOS Release Date string is unexpected length: 8. This string must be in > > > > MM/DD/YYYY format. No other format is allowed and no additional information > > > > may be included. See field description in the SMBIOS specification. > > > > > > > > Base on SMBIOS spec v3.7.0: > > > > > > > > 08h 2.0+ BIOS Release Date BYTE STRING > > > > String number of the BIOS release date. The date > > > > string, if supplied, is in either mm/dd/yy or > > > > mm/dd/yyyy format. If the year portion of the string > > > > is two digits, the year is assumed to be 19yy. > > > > NOTE: The mm/dd/yyyy format is required for SMBIOS > > > > version 2.3 and later. > > > > > > > > So, let's tweek the fallback release date again. > > > > > > > > Fixes: a0f9628705e3 ("OvmfPkg/SmbiosPlatformDxe: tweak fallback release date") [edk2-stable202305~327] > > > > Signed-off-by: "Lee, Chun-Yi" > > > > --- > > > > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > > index 0ca3776045..e929da6b81 100644 > > > > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > > > > @@ -160,7 +160,7 @@ InstallAllStructures ( > > > > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > > > > DateLen = StrLen (DateStr); > > > > if (DateLen < 3) { > > > > - DateStr = L"2/2/2022"; > > > > + DateStr = L"02/02/2022"; > > > > DateLen = StrLen (DateStr); > > > > } > > > > > > > > > > Are you proposing this as an important (but low risk) bugfix that might > > > qualify for the freeze(s)? If so, please loop in Liming and Mike. > > > > > > > hm... What does freeze mean? > > > > ah... You mean soft feature freeze for edk2-stable202402. > > Hi Liming, Michael, > > This change is important but low risk. Could you please consider to add it > to edk2-stable202402 release? > > Thanks a lot! > Joey Lee This patch is not in edk2-stable202402. Will it to be merged to next release? Thanks a lot! Joey Lee -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116311): https://edk2.groups.io/g/devel/message/116311 Mute This Topic: https://groups.io/mt/104153758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-