From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Andrei Warkentin <andrei.warkentin@intel.com>,
Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Ashraf Ali S <ashraf.ali.s@intel.com>,
Bob Feng <bob.c.feng@intel.com>,
Catharine West <catharine.west@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Duggapu Chinni B <chinni.b.duggapu@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Gerd Hoffmann <kraxel@redhat.com>, Gua Guo <gua.guo@intel.com>,
Guo Dong <guo.dong@intel.com>, James Lu <james.lu@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Joey Vagedes <joey.vagedes@gmail.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Michael Roth <michael.roth@amd.com>, Min Xu <min.m.xu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>, Ray Ni <ray.ni@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Sean Rhodes <sean@starlabs.systems>,
Star Zeng <star.zeng@intel.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Susovan Mohapatra <susovan.mohapatra@intel.com>,
Ted Kuo <ted.kuo@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
Date: Tue, 5 Mar 2024 12:38:33 +0100 [thread overview]
Message-ID: <20240305113843.68812-1-lersek@redhat.com> (raw)
Bugzillas:
- https://bugzilla.tianocore.org/show_bug.cgi?id=990
- https://bugzilla.tianocore.org/show_bug.cgi?id=991
- https://bugzilla.tianocore.org/show_bug.cgi?id=4643
CI:
- https://github.com/tianocore/edk2/pull/5442
Branch:
- https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2
This patch series puts the recent BaseTools feature to use in which
AutoGen generates the ProcessLibraryConstructorList() declaration in
"AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
least 1.30. The BaseTools feature is present in both edk2 [1] and
edk2-basetools [2], and has been documented in the Build spec [3] and
the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
release [5] [6] with the new feature.
[1] edk2 commit bac9c74080cf
[2] edk2-basetools commit 5b7161de22ee
[3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
[4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
[5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
[6] https://pypi.org/project/edk2-basetools/0.1.51/
The edk2-basetools part is adopted in the first patch (for
"pip-requirements.txt").
The rest of the patches clean up -- superfluous, or even incorrect --
ProcessLibraryConstructorList() declarations (and, in some cases,
incorrect calls), together with raising the INF_VERSIONs in the related
SEC module INF files to 1.30.
Comparing this version to v1 is not useful, as the compatibility
approach is different, and so this version is structured differently.
Please review any patches for your subsystem from scratch (they are not
difficult or large).
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Catharine West <catharine.west@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gua Guo <gua.guo@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Joey Vagedes <joey.vagedes@gmail.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Roth <michael.roth@amd.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Thanks,
Laszlo
Laszlo Ersek (10):
pip-requirements.txt: require edk2-basetools version 0.1.51
OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList()
decl
OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList()
decl
OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
ArmPlatformPkg/PrePi/PrePi.h | 6 ------
ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
ArmVirtPkg/PrePi/PrePi.c | 6 ------
EmulatorPkg/Sec/Sec.h | 9 ---------
EmulatorPkg/Sec/Sec.inf | 2 +-
IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +-
OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
OvmfPkg/Sec/SecMain.c | 3 +--
OvmfPkg/Sec/SecMain.inf | 2 +-
UefiCpuPkg/SecCore/SecCore.inf | 2 +-
UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
UefiCpuPkg/SecCore/SecMain.h | 12 ------------
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
pip-requirements.txt | 4 ++--
28 files changed, 20 insertions(+), 100 deletions(-)
base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116367): https://edk2.groups.io/g/devel/message/116367
Mute This Topic: https://groups.io/mt/104742520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-03-05 11:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 11:38 Laszlo Ersek [this message]
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-06 21:08 ` Laszlo Ersek
2024-03-06 22:22 ` Michael D Kinney
2024-03-06 21:17 ` Rebecca Cran
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix " Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
2024-03-05 14:06 ` Sunil V L
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
2024-03-05 13:02 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-06 22:36 ` Michael D Kinney
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-07 9:09 ` Zeng, Star
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
2024-03-07 8:24 ` Gerd Hoffmann
2024-03-08 9:13 ` Laszlo Ersek
2024-03-08 9:34 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305113843.68812-1-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox