From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Erdem Aktas <erdemaktas@google.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Michael Roth <michael.roth@amd.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl
Date: Tue, 5 Mar 2024 12:38:35 +0100 [thread overview]
Message-ID: <20240305113843.68812-3-lersek@redhat.com> (raw)
In-Reply-To: <20240305113843.68812-1-lersek@redhat.com>
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for OVMF's SEC module. Rely on AutoGen for
(properly) declaring ProcessLibraryConstructorList(). Update the call.
Build-tested with:
build -a X64 -b DEBUG -m OvmfPkg/Sec/SecMain.inf \
-p OvmfPkg/OvmfPkgX64.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael Roth <michael.roth@amd.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4643
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Sec/SecMain.inf | 2 +-
OvmfPkg/Sec/SecMain.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf
index 3c47a664a95d..dca932a474ee 100644
--- a/OvmfPkg/Sec/SecMain.inf
+++ b/OvmfPkg/Sec/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecMain
FILE_GUID = df1ccef6-f301-4a63-9661-fc6030dcc880
MODULE_TYPE = SEC
diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
index 31da5d0ace51..a30d4ce09ea8 100644
--- a/OvmfPkg/Sec/SecMain.c
+++ b/OvmfPkg/Sec/SecMain.c
@@ -11,7 +11,6 @@
#include <PiPei.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseMemoryLib.h>
@@ -844,7 +843,7 @@ SecCoreStartupWithStack (
InitializeCpuExceptionHandlers (NULL);
}
- ProcessLibraryConstructorList (NULL, NULL);
+ ProcessLibraryConstructorList ();
if (!SevEsIsEnabled ()) {
//
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116368): https://edk2.groups.io/g/devel/message/116368
Mute This Topic: https://groups.io/mt/104742521/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-05 11:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-06 21:08 ` Laszlo Ersek
2024-03-06 22:22 ` Michael D Kinney
2024-03-06 21:17 ` Rebecca Cran
2024-03-05 11:38 ` Laszlo Ersek [this message]
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
2024-03-05 14:06 ` Sunil V L
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
2024-03-05 13:02 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-06 22:36 ` Michael D Kinney
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-07 9:09 ` Zeng, Star
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
2024-03-07 8:24 ` Gerd Hoffmann
2024-03-08 9:13 ` Laszlo Ersek
2024-03-08 9:34 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305113843.68812-3-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox