* [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-06 21:08 ` Laszlo Ersek
2024-03-06 21:17 ` Rebecca Cran
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl Laszlo Ersek
` (11 subsequent siblings)
12 siblings, 2 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Bob Feng, Joey Vagedes, Liming Gao, Michael D Kinney,
Rebecca Cran, Sean Brogan, Yuwei Chen
The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf
("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
modules", 2024-02-29) is 5b7161de22ee ("BaseTools/AutoGen: declare
ProcessLibraryConstructorList() for SEC modules", 2024-03-04); it is part
of tag v0.1.51.
Subsequent patches in this series put that feature to use. Require release
0.1.51 of edk2-basetools in "pip-requirements.txt", so that the next
patches work with in-tree and out-of-tree (e.g., CI) BaseTools.
Furthermore, require version 0.20.0 of edk2-pytool-library. This is a
dependency of edk2-basetools v0.1.50 (commit 08e5bbe755d2, "Add
pyproject.toml and fix setup.py deprecation warnings", 2024-02-13) and
v0.1.51 too (commit f3e15d654479, "Add pyproject.toml and fix setup.py
deprecation warnings", 2024-02-16).
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Joey Vagedes <joey.vagedes@gmail.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
pip-requirements.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 6420078822b5..2f4cd33cc620 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -12,9 +12,9 @@
# https://www.python.org/dev/peps/pep-0440/#version-specifiers
##
-edk2-pytool-library==0.19.9
+edk2-pytool-library==0.20.0
edk2-pytool-extensions==0.26.4
-edk2-basetools==0.1.48
+edk2-basetools==0.1.51
antlr4-python3-runtime==4.7.1
lcov-cobertura==2.0.2
regex==2023.12.25
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116366): https://edk2.groups.io/g/devel/message/116366
Mute This Topic: https://groups.io/mt/104742519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
@ 2024-03-06 21:08 ` Laszlo Ersek
2024-03-06 22:22 ` Michael D Kinney
2024-03-06 21:17 ` Rebecca Cran
1 sibling, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:08 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Bob Feng, Joey Vagedes, Liming Gao, Michael D Kinney,
Rebecca Cran, Sean Brogan, Yuwei Chen
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf
> ("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
> modules", 2024-02-29) is 5b7161de22ee ("BaseTools/AutoGen: declare
> ProcessLibraryConstructorList() for SEC modules", 2024-03-04); it is part
> of tag v0.1.51.
>
> Subsequent patches in this series put that feature to use. Require release
> 0.1.51 of edk2-basetools in "pip-requirements.txt", so that the next
> patches work with in-tree and out-of-tree (e.g., CI) BaseTools.
>
> Furthermore, require version 0.20.0 of edk2-pytool-library. This is a
> dependency of edk2-basetools v0.1.50 (commit 08e5bbe755d2, "Add
> pyproject.toml and fix setup.py deprecation warnings", 2024-02-13) and
> v0.1.51 too (commit f3e15d654479, "Add pyproject.toml and fix setup.py
> deprecation warnings", 2024-02-16).
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Joey Vagedes <joey.vagedes@gmail.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> pip-requirements.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pip-requirements.txt b/pip-requirements.txt
> index 6420078822b5..2f4cd33cc620 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -12,9 +12,9 @@
> # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> ##
>
> -edk2-pytool-library==0.19.9
> +edk2-pytool-library==0.20.0
> edk2-pytool-extensions==0.26.4
> -edk2-basetools==0.1.48
> +edk2-basetools==0.1.51
> antlr4-python3-runtime==4.7.1
> lcov-cobertura==2.0.2
> regex==2023.12.25
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116454): https://edk2.groups.io/g/devel/message/116454
Mute This Topic: https://groups.io/mt/104742519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51
2024-03-06 21:08 ` Laszlo Ersek
@ 2024-03-06 22:22 ` Michael D Kinney
0 siblings, 0 replies; 27+ messages in thread
From: Michael D Kinney @ 2024-03-06 22:22 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Feng, Bob C, Joey Vagedes, Liming Gao, Rebecca Cran, Sean Brogan,
Chen, Christine, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, March 6, 2024 1:09 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Joey Vagedes
> <joey.vagedes@gmail.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Sean Brogan <sean.brogan@microsoft.com>; Chen,
> Christine <yuwei.chen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt:
> require edk2-basetools version 0.1.51
>
> Can I please get a quick R-b for this patch -- it's urgent because of
> <https://edk2.groups.io/g/devel/message/116453>.
>
> Thank you,
> Laszlo
>
> On 3/5/24 12:38, Laszlo Ersek wrote:
> > The edk2-basetools commit that corresponds to edk2 commit
> bac9c74080cf
> > ("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
> > modules", 2024-02-29) is 5b7161de22ee ("BaseTools/AutoGen: declare
> > ProcessLibraryConstructorList() for SEC modules", 2024-03-04); it is
> part
> > of tag v0.1.51.
> >
> > Subsequent patches in this series put that feature to use. Require
> release
> > 0.1.51 of edk2-basetools in "pip-requirements.txt", so that the next
> > patches work with in-tree and out-of-tree (e.g., CI) BaseTools.
> >
> > Furthermore, require version 0.20.0 of edk2-pytool-library. This is a
> > dependency of edk2-basetools v0.1.50 (commit 08e5bbe755d2, "Add
> > pyproject.toml and fix setup.py deprecation warnings", 2024-02-13)
> and
> > v0.1.51 too (commit f3e15d654479, "Add pyproject.toml and fix
> setup.py
> > deprecation warnings", 2024-02-16).
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Joey Vagedes <joey.vagedes@gmail.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > pip-requirements.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/pip-requirements.txt b/pip-requirements.txt
> > index 6420078822b5..2f4cd33cc620 100644
> > --- a/pip-requirements.txt
> > +++ b/pip-requirements.txt
> > @@ -12,9 +12,9 @@
> > # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> > ##
> >
> > -edk2-pytool-library==0.19.9
> > +edk2-pytool-library==0.20.0
> > edk2-pytool-extensions==0.26.4
> > -edk2-basetools==0.1.48
> > +edk2-basetools==0.1.51
> > antlr4-python3-runtime==4.7.1
> > lcov-cobertura==2.0.2
> > regex==2023.12.25
> >
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116461): https://edk2.groups.io/g/devel/message/116461
Mute This Topic: https://groups.io/mt/104742519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-06 21:08 ` Laszlo Ersek
@ 2024-03-06 21:17 ` Rebecca Cran
1 sibling, 0 replies; 27+ messages in thread
From: Rebecca Cran @ 2024-03-06 21:17 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-groups-io
Cc: Bob Feng, Joey Vagedes, Liming Gao, Michael D Kinney, Sean Brogan,
Yuwei Chen
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
On 3/5/2024 4:38 AM, Laszlo Ersek wrote:
> The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf
> ("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
> modules", 2024-02-29) is 5b7161de22ee ("BaseTools/AutoGen: declare
> ProcessLibraryConstructorList() for SEC modules", 2024-03-04); it is part
> of tag v0.1.51.
>
> Subsequent patches in this series put that feature to use. Require release
> 0.1.51 of edk2-basetools in "pip-requirements.txt", so that the next
> patches work with in-tree and out-of-tree (e.g., CI) BaseTools.
>
> Furthermore, require version 0.20.0 of edk2-pytool-library. This is a
> dependency of edk2-basetools v0.1.50 (commit 08e5bbe755d2, "Add
> pyproject.toml and fix setup.py deprecation warnings", 2024-02-13) and
> v0.1.51 too (commit f3e15d654479, "Add pyproject.toml and fix setup.py
> deprecation warnings", 2024-02-16).
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Joey Vagedes <joey.vagedes@gmail.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> pip-requirements.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pip-requirements.txt b/pip-requirements.txt
> index 6420078822b5..2f4cd33cc620 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -12,9 +12,9 @@
> # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> ##
>
> -edk2-pytool-library==0.19.9
> +edk2-pytool-library==0.20.0
> edk2-pytool-extensions==0.26.4
> -edk2-basetools==0.1.48
> +edk2-basetools==0.1.51
> antlr4-python3-runtime==4.7.1
> lcov-cobertura==2.0.2
> regex==2023.12.25
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116460): https://edk2.groups.io/g/devel/message/116460
Mute This Topic: https://groups.io/mt/104742519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix " Laszlo Ersek
` (10 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Ard Biesheuvel, Erdem Aktas, Gerd Hoffmann, Jiewen Yao,
Michael Roth, Min Xu, Tom Lendacky
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for OVMF's SEC module. Rely on AutoGen for
(properly) declaring ProcessLibraryConstructorList(). Update the call.
Build-tested with:
build -a X64 -b DEBUG -m OvmfPkg/Sec/SecMain.inf \
-p OvmfPkg/OvmfPkgX64.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael Roth <michael.roth@amd.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4643
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Sec/SecMain.inf | 2 +-
OvmfPkg/Sec/SecMain.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf
index 3c47a664a95d..dca932a474ee 100644
--- a/OvmfPkg/Sec/SecMain.inf
+++ b/OvmfPkg/Sec/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecMain
FILE_GUID = df1ccef6-f301-4a63-9661-fc6030dcc880
MODULE_TYPE = SEC
diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c
index 31da5d0ace51..a30d4ce09ea8 100644
--- a/OvmfPkg/Sec/SecMain.c
+++ b/OvmfPkg/Sec/SecMain.c
@@ -11,7 +11,6 @@
#include <PiPei.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseMemoryLib.h>
@@ -844,7 +843,7 @@ SecCoreStartupWithStack (
InitializeCpuExceptionHandlers (NULL);
}
- ProcessLibraryConstructorList (NULL, NULL);
+ ProcessLibraryConstructorList ();
if (!SevEsIsEnabled ()) {
//
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116368): https://edk2.groups.io/g/devel/message/116368
Mute This Topic: https://groups.io/mt/104742521/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51 Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 02/10] OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() decl Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
` (9 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for IntelTdx's SEC module. Rely on AutoGen
for (properly) declaring ProcessLibraryConstructorList(). Update the call.
Build-tested with:
build -a X64 -b DEBUG -m OvmfPkg/IntelTdx/Sec/SecMain.inf \
-p OvmfPkg/IntelTdx/IntelTdxX64.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +-
OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/IntelTdx/Sec/SecMain.inf b/OvmfPkg/IntelTdx/Sec/SecMain.inf
index 7fb27941b7ed..cf95284f027e 100644
--- a/OvmfPkg/IntelTdx/Sec/SecMain.inf
+++ b/OvmfPkg/IntelTdx/Sec/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecMain
FILE_GUID = 69d96630-eb64-4b33-8491-13a5cf023dcf
MODULE_TYPE = SEC
diff --git a/OvmfPkg/IntelTdx/Sec/SecMain.c b/OvmfPkg/IntelTdx/Sec/SecMain.c
index 42a587adfa57..4e750755bf7f 100644
--- a/OvmfPkg/IntelTdx/Sec/SecMain.c
+++ b/OvmfPkg/IntelTdx/Sec/SecMain.c
@@ -11,7 +11,6 @@
#include <PiPei.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseMemoryLib.h>
@@ -125,7 +124,7 @@ SecCoreStartupWithStack (
IdtDescriptor.Base = (UINTN)&IdtTableInStack.IdtTable;
IdtDescriptor.Limit = (UINT16)(sizeof (IdtTableInStack.IdtTable) - 1);
- ProcessLibraryConstructorList (NULL, NULL);
+ ProcessLibraryConstructorList ();
//
// Load the IDTR.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116369): https://edk2.groups.io/g/devel/message/116369
Mute This Topic: https://groups.io/mt/104742523/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (2 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 03/10] OvmfPkg/IntelTdx: auto-gen & fix " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-05 14:06 ` Sunil V L
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
` (8 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Andrei Warkentin, Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao,
Sunil V L
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for the OvmfPkg/RiscVVirt SEC module. Rely
on AutoGen for (properly) declaring ProcessLibraryConstructorList().
Remove the correct, but superfluous, declaration as well.
Build-tested with:
build -a RISCV64 -b DEBUG -m OvmfPkg/RiscVVirt/Sec/SecMain.inf \
-p OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc -t GCC5
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
3 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
index 0e2a5785e8a4..73df0ee4cbe7 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf
+++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x0001001B
+ INF_VERSION = 1.30
BASE_NAME = SecMainRiscV64
FILE_GUID = 16740C0A-AA84-4F62-A06D-AE328057AE07
MODULE_TYPE = SEC
diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h b/OvmfPkg/RiscVVirt/Sec/SecMain.h
index 7c7650f0d298..fd7c48f87653 100644
--- a/OvmfPkg/RiscVVirt/Sec/SecMain.h
+++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h
@@ -49,18 +49,6 @@ SecStartup (
IN VOID *DeviceTreeAddress
);
-/**
- Auto-generated function that calls the library constructors for all of the module's
- dependent libraries. This function must be called by the SEC Core once a stack has
- been established.
-
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Perform Platform PEIM initialization.
diff --git a/OvmfPkg/RiscVVirt/Sec/Memory.c b/OvmfPkg/RiscVVirt/Sec/Memory.c
index 7c6d920bd2a6..14c9569c78d4 100644
--- a/OvmfPkg/RiscVVirt/Sec/Memory.c
+++ b/OvmfPkg/RiscVVirt/Sec/Memory.c
@@ -25,7 +25,6 @@ Module Name:
#include <Library/HobLib.h>
#include <Library/IoLib.h>
#include <Library/PcdLib.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/ResourcePublicationLib.h>
#include <Library/BaseRiscVSbiLib.h>
#include <Register/RiscV64/RiscVEncoding.h>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116370): https://edk2.groups.io/g/devel/message/116370
Mute This Topic: https://groups.io/mt/104742524/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
@ 2024-03-05 14:06 ` Sunil V L
0 siblings, 0 replies; 27+ messages in thread
From: Sunil V L @ 2024-03-05 14:06 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Andrei Warkentin, Ard Biesheuvel,
Gerd Hoffmann, Jiewen Yao
On Tue, Mar 05, 2024 at 12:38:37PM +0100, Laszlo Ersek wrote:
> <Library/PeimEntryPoint.h> declares a bogus
> ProcessLibraryConstructorList() for the OvmfPkg/RiscVVirt SEC module. Rely
> on AutoGen for (properly) declaring ProcessLibraryConstructorList().
> Remove the correct, but superfluous, declaration as well.
>
> Build-tested with:
>
> build -a RISCV64 -b DEBUG -m OvmfPkg/RiscVVirt/Sec/SecMain.inf \
> -p OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc -t GCC5
>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
> 3 files changed, 1 insertion(+), 14 deletions(-)
>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116392): https://edk2.groups.io/g/devel/message/116392
Mute This Topic: https://groups.io/mt/104742524/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (3 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 04/10] OvmfPkg/RiscVVirt/Sec: clean up " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-05 13:02 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
` (7 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Ard Biesheuvel, Leif Lindholm
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a AARCH64 -b DEBUG \
-m ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf \
-p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
build -a AARCH64 -b DEBUG \
-m ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf \
-p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
build -a AARCH64 -b DEBUG \
-m ArmPlatformPkg/PrePi/PeiMPCore.inf \
-p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
build -a AARCH64 -b DEBUG \
-m ArmPlatformPkg/PrePi/PeiUniCore.inf \
-p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
ArmPlatformPkg/PrePi/PrePi.h | 6 ------
6 files changed, 4 insertions(+), 20 deletions(-)
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
index 4a3112b58dcb..c5cad7e37fbd 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
@@ -8,7 +8,7 @@
#**/
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = ArmPlatformPrePeiCore
FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
MODULE_TYPE = SEC
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
index ab5bf1dac2d8..1d50b4d0b5f2 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
@@ -8,7 +8,7 @@
#**/
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = ArmPlatformPrePeiCore
FILE_GUID = 469fc080-aec1-11df-927c-0002a5d5c51b
MODULE_TYPE = SEC
diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
index a613b24c340e..0b13b723539c 100644
--- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
+++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
@@ -8,7 +8,7 @@
#**/
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = ArmPlatformPrePiMPCore
FILE_GUID = d959e387-7b91-452c-90e0-a1dbac90ddb8
MODULE_TYPE = SEC
diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
index b62ea3c485bd..2e237172d571 100644
--- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
+++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
@@ -9,7 +9,7 @@
#**/
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = ArmPlatformPrePiUniCore
FILE_GUID = 3e401783-cc94-4fcd-97bc-bd35ac369d2f
MODULE_TYPE = SEC
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
index c1e13e23e11e..fbf6207db816 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
@@ -73,14 +73,4 @@ PeiCommonExceptionEntry (
IN UINTN LR
);
-/*
- * Autogenerated function that calls the library constructors for all of the
- * module's dependent libraries.
- */
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
#endif
diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h
index 6074a22108d2..1d47ba26be3a 100644
--- a/ArmPlatformPkg/PrePi/PrePi.h
+++ b/ArmPlatformPkg/PrePi/PrePi.h
@@ -79,10 +79,4 @@ ArchInitialize (
VOID
);
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
#endif /* _PREPI_H_ */
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116371): https://edk2.groups.io/g/devel/message/116371
Mute This Topic: https://groups.io/mt/104742525/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
@ 2024-03-05 13:02 ` Ard Biesheuvel
0 siblings, 0 replies; 27+ messages in thread
From: Ard Biesheuvel @ 2024-03-05 13:02 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-groups-io, Leif Lindholm
On Tue, 5 Mar 2024 at 12:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a AARCH64 -b DEBUG \
> -m ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf \
> -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
> build -a AARCH64 -b DEBUG \
> -m ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf \
> -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
> build -a AARCH64 -b DEBUG \
> -m ArmPlatformPkg/PrePi/PeiMPCore.inf \
> -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
> build -a AARCH64 -b DEBUG \
> -m ArmPlatformPkg/PrePi/PeiUniCore.inf \
> -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
> ArmPlatformPkg/PrePi/PrePi.h | 6 ------
> 6 files changed, 4 insertions(+), 20 deletions(-)
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> index 4a3112b58dcb..c5cad7e37fbd 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
> @@ -8,7 +8,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = ArmPlatformPrePeiCore
> FILE_GUID = b78d02bb-d0b5-4389-bc7f-b39ee846c784
> MODULE_TYPE = SEC
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> index ab5bf1dac2d8..1d50b4d0b5f2 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
> @@ -8,7 +8,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = ArmPlatformPrePeiCore
> FILE_GUID = 469fc080-aec1-11df-927c-0002a5d5c51b
> MODULE_TYPE = SEC
> diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> index a613b24c340e..0b13b723539c 100644
> --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> @@ -8,7 +8,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = ArmPlatformPrePiMPCore
> FILE_GUID = d959e387-7b91-452c-90e0-a1dbac90ddb8
> MODULE_TYPE = SEC
> diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> index b62ea3c485bd..2e237172d571 100644
> --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> @@ -9,7 +9,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = ArmPlatformPrePiUniCore
> FILE_GUID = 3e401783-cc94-4fcd-97bc-bd35ac369d2f
> MODULE_TYPE = SEC
> diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> index c1e13e23e11e..fbf6207db816 100644
> --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
> @@ -73,14 +73,4 @@ PeiCommonExceptionEntry (
> IN UINTN LR
> );
>
> -/*
> - * Autogenerated function that calls the library constructors for all of the
> - * module's dependent libraries.
> - */
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> #endif
> diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h
> index 6074a22108d2..1d47ba26be3a 100644
> --- a/ArmPlatformPkg/PrePi/PrePi.h
> +++ b/ArmPlatformPkg/PrePi/PrePi.h
> @@ -79,10 +79,4 @@ ArchInitialize (
> VOID
> );
>
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> #endif /* _PREPI_H_ */
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116389): https://edk2.groups.io/g/devel/message/116389
Mute This Topic: https://groups.io/mt/104742525/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (4 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
` (6 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Ard Biesheuvel, Gerd Hoffmann, Leif Lindholm, Sami Mujawar
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a AARCH64 -b DEBUG \
-m ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf \
-p ArmVirtPkg/ArmVirtKvmTool.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
ArmVirtPkg/PrePi/PrePi.c | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
index 6b9244bd1a6b..578ee37e7467 100755
--- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
+++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
@@ -8,7 +8,7 @@
#**/
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = ArmVirtPrePiUniCoreRelocatable
FILE_GUID = f7d9fd14-9335-4389-80c5-334d6abfcced
MODULE_TYPE = SEC
diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c
index ff51a757a21a..f27e0ad3d223 100755
--- a/ArmVirtPkg/PrePi/PrePi.c
+++ b/ArmVirtPkg/PrePi/PrePi.c
@@ -22,12 +22,6 @@
#include "PrePi.h"
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
VOID
PrePiMain (
IN UINTN UefiMemoryBase,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116372): https://edk2.groups.io/g/devel/message/116372
Mute This Topic: https://groups.io/mt/104742526/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
@ 2024-03-05 13:01 ` Ard Biesheuvel
0 siblings, 0 replies; 27+ messages in thread
From: Ard Biesheuvel @ 2024-03-05 13:01 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Gerd Hoffmann, Leif Lindholm, Sami Mujawar
On Tue, 5 Mar 2024 at 12:39, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a AARCH64 -b DEBUG \
> -m ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf \
> -p ArmVirtPkg/ArmVirtKvmTool.dsc -t GCC5
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
> ArmVirtPkg/PrePi/PrePi.c | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> index 6b9244bd1a6b..578ee37e7467 100755
> --- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> +++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf
> @@ -8,7 +8,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = ArmVirtPrePiUniCoreRelocatable
> FILE_GUID = f7d9fd14-9335-4389-80c5-334d6abfcced
> MODULE_TYPE = SEC
> diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c
> index ff51a757a21a..f27e0ad3d223 100755
> --- a/ArmVirtPkg/PrePi/PrePi.c
> +++ b/ArmVirtPkg/PrePi/PrePi.c
> @@ -22,12 +22,6 @@
>
> #include "PrePi.h"
>
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> VOID
> PrePiMain (
> IN UINTN UefiMemoryBase,
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116388): https://edk2.groups.io/g/devel/message/116388
Mute This Topic: https://groups.io/mt/104742526/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (5 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
` (5 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Andrew Fish, Ray Ni
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \
-p EmulatorPkg/EmulatorPkg.dsc -t GCC5
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
EmulatorPkg/Sec/Sec.inf | 2 +-
EmulatorPkg/Sec/Sec.h | 9 ---------
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/EmulatorPkg/Sec/Sec.inf b/EmulatorPkg/Sec/Sec.inf
index 2f9e3d4780cc..7476094f1305 100644
--- a/EmulatorPkg/Sec/Sec.inf
+++ b/EmulatorPkg/Sec/Sec.inf
@@ -11,7 +11,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = EmuSec
FILE_GUID = BCAF98C9-22B0-3B4F-9CBD-C8A6B4DBCEE9
MODULE_TYPE = SEC
diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h
index 29272a29ffa5..94689eb41d35 100644
--- a/EmulatorPkg/Sec/Sec.h
+++ b/EmulatorPkg/Sec/Sec.h
@@ -20,15 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Ppi/TemporaryRamSupport.h>
-//
-// I think this should be defined in a MdePkg include file?
-//
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
EFI_STATUS
EFIAPI
SecTemporaryRamSupport (
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116373): https://edk2.groups.io/g/devel/message/116373
Mute This Topic: https://groups.io/mt/104742527/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
@ 2024-03-06 21:09 ` Laszlo Ersek
2024-03-06 22:36 ` Michael D Kinney
0 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:09 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Andrew Fish, Ray Ni
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \
> -p EmulatorPkg/EmulatorPkg.dsc -t GCC5
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> EmulatorPkg/Sec/Sec.inf | 2 +-
> EmulatorPkg/Sec/Sec.h | 9 ---------
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/EmulatorPkg/Sec/Sec.inf b/EmulatorPkg/Sec/Sec.inf
> index 2f9e3d4780cc..7476094f1305 100644
> --- a/EmulatorPkg/Sec/Sec.inf
> +++ b/EmulatorPkg/Sec/Sec.inf
> @@ -11,7 +11,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = EmuSec
> FILE_GUID = BCAF98C9-22B0-3B4F-9CBD-C8A6B4DBCEE9
> MODULE_TYPE = SEC
> diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h
> index 29272a29ffa5..94689eb41d35 100644
> --- a/EmulatorPkg/Sec/Sec.h
> +++ b/EmulatorPkg/Sec/Sec.h
> @@ -20,15 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #include <Ppi/TemporaryRamSupport.h>
>
> -//
> -// I think this should be defined in a MdePkg include file?
> -//
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> EFI_STATUS
> EFIAPI
> SecTemporaryRamSupport (
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116455): https://edk2.groups.io/g/devel/message/116455
Mute This Topic: https://groups.io/mt/104742527/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-06 21:09 ` Laszlo Ersek
@ 2024-03-06 22:36 ` Michael D Kinney
0 siblings, 0 replies; 27+ messages in thread
From: Michael D Kinney @ 2024-03-06 22:36 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Andrew Fish, Ni, Ray, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:10 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate
> SEC ProcessLibraryConstructorList() decl
>
> Can I please get a quick R-b for this patch -- it's urgent because of
> <https://edk2.groups.io/g/devel/message/116453>.
>
> Thank you,
> Laszlo
>
> On 3/5/24 12:38, Laszlo Ersek wrote:
> > Rely on AutoGen for declaring ProcessLibraryConstructorList().
> >
> > Build-tested with:
> >
> > build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \
> > -p EmulatorPkg/EmulatorPkg.dsc -t GCC5
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > EmulatorPkg/Sec/Sec.inf | 2 +-
> > EmulatorPkg/Sec/Sec.h | 9 ---------
> > 2 files changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/EmulatorPkg/Sec/Sec.inf b/EmulatorPkg/Sec/Sec.inf
> > index 2f9e3d4780cc..7476094f1305 100644
> > --- a/EmulatorPkg/Sec/Sec.inf
> > +++ b/EmulatorPkg/Sec/Sec.inf
> > @@ -11,7 +11,7 @@
> > ##
> >
> > [Defines]
> > - INF_VERSION = 0x00010005
> > + INF_VERSION = 1.30
> > BASE_NAME = EmuSec
> > FILE_GUID = BCAF98C9-22B0-3B4F-9CBD-
> C8A6B4DBCEE9
> > MODULE_TYPE = SEC
> > diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h
> > index 29272a29ffa5..94689eb41d35 100644
> > --- a/EmulatorPkg/Sec/Sec.h
> > +++ b/EmulatorPkg/Sec/Sec.h
> > @@ -20,15 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > #include <Ppi/TemporaryRamSupport.h>
> >
> > -//
> > -// I think this should be defined in a MdePkg include file?
> > -//
> > -VOID
> > -EFIAPI
> > -ProcessLibraryConstructorList (
> > - VOID
> > - );
> > -
> > EFI_STATUS
> > EFIAPI
> > SecTemporaryRamSupport (
> >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116464): https://edk2.groups.io/g/devel/message/116464
Mute This Topic: https://groups.io/mt/104742527/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (6 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 07/10] EmulatorPkg: " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-06 21:09 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
` (4 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Ashraf Ali S, Chasel Chiu, Duggapu Chinni B, Nate DeSimone,
Star Zeng, Susovan Mohapatra, Ted Kuo
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf \
-p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf \
-p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
3 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
index cb011f99f964..7d60e2283e26 100644
--- a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = Fsp24SecCoreM
FILE_GUID = C5BC0719-4A23-4F6E-94DA-05FB6A0DFA9C
MODULE_TYPE = SEC
diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
index 8029832235ec..d496f3957d1b 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = FspSecCoreM
FILE_GUID = C2F9AE46-3437-4FEF-9CB1-9A568B282FEE
MODULE_TYPE = SEC
diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h b/IntelFsp2Pkg/FspSecCore/SecMain.h
index 023deb7e2bda..eb1458d19773 100644
--- a/IntelFsp2Pkg/FspSecCore/SecMain.h
+++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
@@ -110,18 +110,6 @@ SecStartup (
IN UINT32 ApiIdx
);
-/**
- Autogenerated function that calls the library constructors for all of the module's
- dependent libraries. This function must be called by the SEC Core once a stack has
- been established.
-
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Return value of esp.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116375): https://edk2.groups.io/g/devel/message/116375
Mute This Topic: https://groups.io/mt/104742530/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
@ 2024-03-06 21:09 ` Laszlo Ersek
2024-03-07 9:09 ` Zeng, Star
0 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:09 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Ashraf Ali S, Chasel Chiu, Duggapu Chinni B, Nate DeSimone,
Star Zeng, Susovan Mohapatra, Ted Kuo
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf \
> -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
>
> build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf \
> -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
> 3 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> index cb011f99f964..7d60e2283e26 100644
> --- a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = Fsp24SecCoreM
> FILE_GUID = C5BC0719-4A23-4F6E-94DA-05FB6A0DFA9C
> MODULE_TYPE = SEC
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 8029832235ec..d496f3957d1b 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = FspSecCoreM
> FILE_GUID = C2F9AE46-3437-4FEF-9CB1-9A568B282FEE
> MODULE_TYPE = SEC
> diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h b/IntelFsp2Pkg/FspSecCore/SecMain.h
> index 023deb7e2bda..eb1458d19773 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.h
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
> @@ -110,18 +110,6 @@ SecStartup (
> IN UINT32 ApiIdx
> );
>
> -/**
> - Autogenerated function that calls the library constructors for all of the module's
> - dependent libraries. This function must be called by the SEC Core once a stack has
> - been established.
> -
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> /**
>
> Return value of esp.
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116456): https://edk2.groups.io/g/devel/message/116456
Mute This Topic: https://groups.io/mt/104742530/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-06 21:09 ` Laszlo Ersek
@ 2024-03-07 9:09 ` Zeng, Star
0 siblings, 0 replies; 27+ messages in thread
From: Zeng, Star @ 2024-03-07 9:09 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: S, Ashraf Ali, Chiu, Chasel, Duggapu, Chinni B,
Desimone, Nathaniel L, Mohapatra, Susovan, Kuo, Ted, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
Sent: Thursday, March 7, 2024 5:10 AM
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: S, Ashraf Ali <ashraf.ali.s@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Mohapatra, Susovan <susovan.mohapatra@intel.com>; Kuo, Ted <ted.kuo@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
Can I please get a quick R-b for this patch -- it's urgent because of <https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf \
> -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
>
> build -a X64 -b DEBUG -m IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf \
> -p IntelFsp2Pkg/IntelFsp2Pkg.dsc -t GCC5
>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
> 3 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> index cb011f99f964..7d60e2283e26 100644
> --- a/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = Fsp24SecCoreM
> FILE_GUID = C5BC0719-4A23-4F6E-94DA-05FB6A0DFA9C
> MODULE_TYPE = SEC
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> index 8029832235ec..d496f3957d1b 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = FspSecCoreM
> FILE_GUID = C2F9AE46-3437-4FEF-9CB1-9A568B282FEE
> MODULE_TYPE = SEC
> diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.h
> b/IntelFsp2Pkg/FspSecCore/SecMain.h
> index 023deb7e2bda..eb1458d19773 100644
> --- a/IntelFsp2Pkg/FspSecCore/SecMain.h
> +++ b/IntelFsp2Pkg/FspSecCore/SecMain.h
> @@ -110,18 +110,6 @@ SecStartup (
> IN UINT32 ApiIdx
> );
>
> -/**
> - Autogenerated function that calls the library constructors for all
> of the module's
> - dependent libraries. This function must be called by the SEC Core
> once a stack has
> - been established.
> -
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> /**
>
> Return value of esp.
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116480): https://edk2.groups.io/g/devel/message/116480
Mute This Topic: https://groups.io/mt/104742530/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (7 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
` (3 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Catharine West, Gerd Hoffmann, Rahul Kumar, Ray Ni
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCore.inf \
-p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCoreNative.inf \
-p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
Cc: Catharine West <catharine.west@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
UefiCpuPkg/SecCore/SecCore.inf | 2 +-
UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
UefiCpuPkg/SecCore/SecMain.h | 12 ------------
3 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/UefiCpuPkg/SecCore/SecCore.inf b/UefiCpuPkg/SecCore/SecCore.inf
index cab69b8b97f3..4f732cccb7fc 100644
--- a/UefiCpuPkg/SecCore/SecCore.inf
+++ b/UefiCpuPkg/SecCore/SecCore.inf
@@ -13,7 +13,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecCore
MODULE_UNI_FILE = SecCore.uni
FILE_GUID = 1BA0062E-C779-4582-8566-336AE8F78F09
diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/SecCoreNative.inf
index fa241cca94d4..454a3629e505 100644
--- a/UefiCpuPkg/SecCore/SecCoreNative.inf
+++ b/UefiCpuPkg/SecCore/SecCoreNative.inf
@@ -13,7 +13,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecCoreNative
MODULE_UNI_FILE = SecCore.uni
FILE_GUID = 43CA74CA-7D29-49A0-B3B9-20F84015B27D
diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h
index b50d96e45b33..81c561424e3b 100644
--- a/UefiCpuPkg/SecCore/SecMain.h
+++ b/UefiCpuPkg/SecCore/SecMain.h
@@ -101,18 +101,6 @@ FindAndReportEntryPoints (
OUT EFI_PEI_CORE_ENTRY_POINT *PeiCoreEntryPoint
);
-/**
- Auto-generated function that calls the library constructors for all of the module's
- dependent libraries. This function must be called by the SEC Core once a stack has
- been established.
-
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_INFORMATION_PPI.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116374): https://edk2.groups.io/g/devel/message/116374
Mute This Topic: https://groups.io/mt/104742529/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
@ 2024-03-06 21:10 ` Laszlo Ersek
0 siblings, 0 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:10 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Catharine West, Gerd Hoffmann, Rahul Kumar, Ray Ni
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCore.inf \
> -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
>
> build -a X64 -b DEBUG -m UefiCpuPkg/SecCore/SecCoreNative.inf \
> -p UefiCpuPkg/UefiCpuPkg.dsc -t GCC5
>
> Cc: Catharine West <catharine.west@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiCpuPkg/SecCore/SecCore.inf | 2 +-
> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
> UefiCpuPkg/SecCore/SecMain.h | 12 ------------
> 3 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/UefiCpuPkg/SecCore/SecCore.inf b/UefiCpuPkg/SecCore/SecCore.inf
> index cab69b8b97f3..4f732cccb7fc 100644
> --- a/UefiCpuPkg/SecCore/SecCore.inf
> +++ b/UefiCpuPkg/SecCore/SecCore.inf
> @@ -13,7 +13,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = SecCore
> MODULE_UNI_FILE = SecCore.uni
> FILE_GUID = 1BA0062E-C779-4582-8566-336AE8F78F09
> diff --git a/UefiCpuPkg/SecCore/SecCoreNative.inf b/UefiCpuPkg/SecCore/SecCoreNative.inf
> index fa241cca94d4..454a3629e505 100644
> --- a/UefiCpuPkg/SecCore/SecCoreNative.inf
> +++ b/UefiCpuPkg/SecCore/SecCoreNative.inf
> @@ -13,7 +13,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = SecCoreNative
> MODULE_UNI_FILE = SecCore.uni
> FILE_GUID = 43CA74CA-7D29-49A0-B3B9-20F84015B27D
> diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h
> index b50d96e45b33..81c561424e3b 100644
> --- a/UefiCpuPkg/SecCore/SecMain.h
> +++ b/UefiCpuPkg/SecCore/SecMain.h
> @@ -101,18 +101,6 @@ FindAndReportEntryPoints (
> OUT EFI_PEI_CORE_ENTRY_POINT *PeiCoreEntryPoint
> );
>
> -/**
> - Auto-generated function that calls the library constructors for all of the module's
> - dependent libraries. This function must be called by the SEC Core once a stack has
> - been established.
> -
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> /**
> Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_INFORMATION_PPI.
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116457): https://edk2.groups.io/g/devel/message/116457
Mute This Topic: https://groups.io/mt/104742529/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (8 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 09/10] UefiCpuPkg: " Laszlo Ersek
@ 2024-03-05 11:38 ` Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
` (2 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-05 11:38 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Gua Guo, Guo Dong, James Lu, Sean Rhodes
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -t GCC5
python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -f \
-t GCC5
build -a X64 -b DEBUG -p UefiPayloadPkg/UefiPayloadPkg.dsc -t GCC5 \
-D BUILD_ARCH=X64
Cc: Gua Guo <gua.guo@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
4 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
index 01fb3aceb3e4..b87a0989eee3 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = FitUniversalPayloadEntry
FILE_GUID = CED5A8A9-B6EA-4D5A-8689-577EE88566CF
MODULE_TYPE = SEC
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
index e2af8a4b7c1b..a3ff4b86eaf6 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
@@ -9,7 +9,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = PayloadEntry
FILE_GUID = 2119BBD7-9432-4f47-B5E2-5C4EA31B6BDC
MODULE_TYPE = SEC
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
index 5112cdc1e5df..a62da5c7059d 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = UniversalPayloadEntry
FILE_GUID = D4F0F269-1209-4A66-8039-C4D5A700EA4E
MODULE_TYPE = SEC
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
index ad8a9fd22b66..80ccc5072c55 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
@@ -51,16 +51,6 @@
#define E820_PMEM 7
#define E820_UNDEFINED 8
-/**
- Auto-generated function that calls the library constructors for all of the module's
- dependent libraries.
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Add a new HOB to the HOB List.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116376): https://edk2.groups.io/g/devel/message/116376
Mute This Topic: https://groups.io/mt/104742531/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
@ 2024-03-06 21:10 ` Laszlo Ersek
0 siblings, 0 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:10 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Gua Guo, Guo Dong, James Lu, Sean Rhodes
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 12:38, Laszlo Ersek wrote:
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -t GCC5
>
> python UefiPayloadPkg/UniversalPayloadBuild.py -a X64 -b DEBUG -f \
> -t GCC5
>
> build -a X64 -b DEBUG -p UefiPayloadPkg/UefiPayloadPkg.dsc -t GCC5 \
> -D BUILD_ARCH=X64
>
> Cc: Gua Guo <gua.guo@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
> 4 files changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> index 01fb3aceb3e4..b87a0989eee3 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = FitUniversalPayloadEntry
> FILE_GUID = CED5A8A9-B6EA-4D5A-8689-577EE88566CF
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> index e2af8a4b7c1b..a3ff4b86eaf6 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
> @@ -9,7 +9,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = PayloadEntry
> FILE_GUID = 2119BBD7-9432-4f47-B5E2-5C4EA31B6BDC
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> index 5112cdc1e5df..a62da5c7059d 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = UniversalPayloadEntry
> FILE_GUID = D4F0F269-1209-4A66-8039-C4D5A700EA4E
> MODULE_TYPE = SEC
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> index ad8a9fd22b66..80ccc5072c55 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h
> @@ -51,16 +51,6 @@
> #define E820_PMEM 7
> #define E820_UNDEFINED 8
>
> -/**
> - Auto-generated function that calls the library constructors for all of the module's
> - dependent libraries.
> -**/
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> /**
> Add a new HOB to the HOB List.
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116458): https://edk2.groups.io/g/devel/message/116458
Mute This Topic: https://groups.io/mt/104742531/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (9 preceding siblings ...)
2024-03-05 11:38 ` [edk2-devel] [PATCH v2 10/10] UefiPayloadPkg: " Laszlo Ersek
@ 2024-03-05 12:26 ` Yao, Jiewen
2024-03-07 8:24 ` Gerd Hoffmann
2024-03-08 9:13 ` Laszlo Ersek
12 siblings, 0 replies; 27+ messages in thread
From: Yao, Jiewen @ 2024-03-05 12:26 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-groups-io
Cc: Warkentin, Andrei, Andrew Fish, Ard Biesheuvel, S, Ashraf Ali,
Feng, Bob C, West, Catharine, Chiu, Chasel, Duggapu, Chinni B,
Aktas, Erdem, Gerd Hoffmann, Guo, Gua, Dong, Guo, Lu, James,
Joey Vagedes, Leif Lindholm, Liming Gao, Kinney, Michael D,
Michael Roth, Xu, Min M, Desimone, Nathaniel L, Kumar, Rahul R,
Ni, Ray, Rebecca Cran, Sami Mujawar, Sean Brogan, Rhodes, Sean,
Zeng, Star, Sunil V L, Mohapatra, Susovan, Kuo, Ted, Tom Lendacky,
Chen, Christine
For OvmfPkg, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, March 5, 2024 7:39 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Warkentin, Andrei <andrei.warkentin@intel.com>; Andrew Fish
> <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; West, Catharine
> <catharine.west@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Duggapu,
> Chinni B <chinni.b.duggapu@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; Gerd Hoffmann <kraxel@redhat.com>; Guo, Gua
> <gua.guo@intel.com>; Dong, Guo <guo.dong@intel.com>; Lu, James
> <james.lu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Joey Vagedes
> <joey.vagedes@gmail.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Michael Roth <michael.roth@amd.com>; Xu, Min
> M <min.m.xu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Rebecca Cran <rebecca@bsdio.com>; Sami Mujawar
> <sami.mujawar@arm.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Rhodes, Sean <sean@starlabs.systems>; Zeng, Star <star.zeng@intel.com>; Sunil
> V L <sunilvl@ventanamicro.com>; Mohapatra, Susovan
> <susovan.mohapatra@intel.com>; Kuo, Ted <ted.kuo@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Chen, Christine <yuwei.chen@intel.com>
> Subject: [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations
> in SEC modules
>
> Bugzillas:
> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
> - https://bugzilla.tianocore.org/show_bug.cgi?id=991
> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643
>
> CI:
> - https://github.com/tianocore/edk2/pull/5442
>
> Branch:
> - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-
> 991-v2
>
> This patch series puts the recent BaseTools feature to use in which
> AutoGen generates the ProcessLibraryConstructorList() declaration in
> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
> least 1.30. The BaseTools feature is present in both edk2 [1] and
> edk2-basetools [2], and has been documented in the Build spec [3] and
> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
> release [5] [6] with the new feature.
>
> [1] edk2 commit bac9c74080cf
> [2] edk2-basetools commit 5b7161de22ee
> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
> [6] https://pypi.org/project/edk2-basetools/0.1.51/
>
> The edk2-basetools part is adopted in the first patch (for
> "pip-requirements.txt").
>
> The rest of the patches clean up -- superfluous, or even incorrect --
> ProcessLibraryConstructorList() declarations (and, in some cases,
> incorrect calls), together with raising the INF_VERSIONs in the related
> SEC module INF files to 1.30.
>
> Comparing this version to v1 is not useful, as the compatibility
> approach is different, and so this version is structured differently.
> Please review any patches for your subsystem from scratch (they are not
> difficult or large).
>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Gua Guo <gua.guo@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Joey Vagedes <joey.vagedes@gmail.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (10):
> pip-requirements.txt: require edk2-basetools version 0.1.51
> OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList()
> decl
> OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList()
> decl
> OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
> ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
> UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>
> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PrePi.h | 6 ------
> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
> ArmVirtPkg/PrePi/PrePi.c | 6 ------
> EmulatorPkg/Sec/Sec.h | 9 ---------
> EmulatorPkg/Sec/Sec.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
> OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
> OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +-
> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
> OvmfPkg/Sec/SecMain.c | 3 +--
> OvmfPkg/Sec/SecMain.inf | 2 +-
> UefiCpuPkg/SecCore/SecCore.inf | 2 +-
> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
> UefiCpuPkg/SecCore/SecMain.h | 12 ------------
> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
> pip-requirements.txt | 4 ++--
> 28 files changed, 20 insertions(+), 100 deletions(-)
>
>
> base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116385): https://edk2.groups.io/g/devel/message/116385
Mute This Topic: https://groups.io/mt/104742520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (10 preceding siblings ...)
2024-03-05 12:26 ` [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Yao, Jiewen
@ 2024-03-07 8:24 ` Gerd Hoffmann
2024-03-08 9:13 ` Laszlo Ersek
12 siblings, 0 replies; 27+ messages in thread
From: Gerd Hoffmann @ 2024-03-07 8:24 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Andrei Warkentin, Andrew Fish,
Ard Biesheuvel, Ashraf Ali S, Bob Feng, Catharine West,
Chasel Chiu, Duggapu Chinni B, Erdem Aktas, Gua Guo, Guo Dong,
James Lu, Jiewen Yao, Joey Vagedes, Leif Lindholm, Liming Gao,
Michael D Kinney, Michael Roth, Min Xu, Nate DeSimone,
Rahul Kumar, Ray Ni, Rebecca Cran, Sami Mujawar, Sean Brogan,
Sean Rhodes, Star Zeng, Sunil V L, Susovan Mohapatra, Ted Kuo,
Tom Lendacky, Yuwei Chen
On Tue, Mar 05, 2024 at 12:38:33PM +0100, Laszlo Ersek wrote:
> Bugzillas:
> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
> - https://bugzilla.tianocore.org/show_bug.cgi?id=991
> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643
>
> CI:
> - https://github.com/tianocore/edk2/pull/5442
>
> Branch:
> - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2
>
> This patch series puts the recent BaseTools feature to use in which
> AutoGen generates the ProcessLibraryConstructorList() declaration in
> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
> least 1.30. The BaseTools feature is present in both edk2 [1] and
> edk2-basetools [2], and has been documented in the Build spec [3] and
> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
> release [5] [6] with the new feature.
Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116477): https://edk2.groups.io/g/devel/message/116477
Mute This Topic: https://groups.io/mt/104742520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
2024-03-05 11:38 [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (11 preceding siblings ...)
2024-03-07 8:24 ` Gerd Hoffmann
@ 2024-03-08 9:13 ` Laszlo Ersek
2024-03-08 9:34 ` Laszlo Ersek
12 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-08 9:13 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Andrei Warkentin, Andrew Fish, Ard Biesheuvel, Ashraf Ali S,
Bob Feng, Catharine West, Chasel Chiu, Duggapu Chinni B,
Erdem Aktas, Gerd Hoffmann, Gua Guo, Guo Dong, James Lu,
Jiewen Yao, Joey Vagedes, Leif Lindholm, Liming Gao,
Michael D Kinney, Michael Roth, Min Xu, Nate DeSimone,
Rahul Kumar, Ray Ni, Rebecca Cran, Sami Mujawar, Sean Brogan,
Sean Rhodes, Star Zeng, Sunil V L, Susovan Mohapatra, Ted Kuo,
Tom Lendacky, Yuwei Chen
On 3/5/24 12:38, Laszlo Ersek wrote:
> Bugzillas:
> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
> - https://bugzilla.tianocore.org/show_bug.cgi?id=991
> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643
>
> CI:
> - https://github.com/tianocore/edk2/pull/5442
>
> Branch:
> - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2
>
> This patch series puts the recent BaseTools feature to use in which
> AutoGen generates the ProcessLibraryConstructorList() declaration in
> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
> least 1.30. The BaseTools feature is present in both edk2 [1] and
> edk2-basetools [2], and has been documented in the Build spec [3] and
> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
> release [5] [6] with the new feature.
>
> [1] edk2 commit bac9c74080cf
> [2] edk2-basetools commit 5b7161de22ee
> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
> [6] https://pypi.org/project/edk2-basetools/0.1.51/
>
> The edk2-basetools part is adopted in the first patch (for
> "pip-requirements.txt").
>
> The rest of the patches clean up -- superfluous, or even incorrect --
> ProcessLibraryConstructorList() declarations (and, in some cases,
> incorrect calls), together with raising the INF_VERSIONs in the related
> SEC module INF files to 1.30.
>
> Comparing this version to v1 is not useful, as the compatibility
> approach is different, and so this version is structured differently.
> Please review any patches for your subsystem from scratch (they are not
> difficult or large).
>
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Catharine West <catharine.west@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Gua Guo <gua.guo@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Joey Vagedes <joey.vagedes@gmail.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (10):
> pip-requirements.txt: require edk2-basetools version 0.1.51
> OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList()
> decl
> OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList()
> decl
> OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
> ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
> UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>
> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
> ArmPlatformPkg/PrePi/PrePi.h | 6 ------
> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
> ArmVirtPkg/PrePi/PrePi.c | 6 ------
> EmulatorPkg/Sec/Sec.h | 9 ---------
> EmulatorPkg/Sec/Sec.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
> OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
> OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +-
> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
> OvmfPkg/Sec/SecMain.c | 3 +--
> OvmfPkg/Sec/SecMain.inf | 2 +-
> UefiCpuPkg/SecCore/SecCore.inf | 2 +-
> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
> UefiCpuPkg/SecCore/SecMain.h | 12 ------------
> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
> pip-requirements.txt | 4 ++--
> 28 files changed, 20 insertions(+), 100 deletions(-)
>
>
> base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0
Series merged as commit range e60529df58e4..1c0db2315109, via
<https://github.com/tianocore/edk2/pull/5450>.
One might argue that the last two patches in the series had not been
sufficiently reviewed, per strict review process. That may be the case;
however, I'm out of time, and this series -- like any other global
cleanup series -- only really makes sense if it is as comprehensive as
possible. If that's not tolerable, then feel free to revert the
UefiCpuPkg and UefiPayloadPkg patches.
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116494): https://edk2.groups.io/g/devel/message/116494
Mute This Topic: https://groups.io/mt/104742520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules
2024-03-08 9:13 ` Laszlo Ersek
@ 2024-03-08 9:34 ` Laszlo Ersek
0 siblings, 0 replies; 27+ messages in thread
From: Laszlo Ersek @ 2024-03-08 9:34 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Andrei Warkentin, Andrew Fish, Ard Biesheuvel, Ashraf Ali S,
Bob Feng, Catharine West, Chasel Chiu, Duggapu Chinni B,
Erdem Aktas, Gerd Hoffmann, Gua Guo, Guo Dong, James Lu,
Jiewen Yao, Joey Vagedes, Leif Lindholm, Liming Gao,
Michael D Kinney, Michael Roth, Min Xu, Nate DeSimone,
Rahul Kumar, Ray Ni, Rebecca Cran, Sami Mujawar, Sean Brogan,
Sean Rhodes, Star Zeng, Sunil V L, Susovan Mohapatra, Ted Kuo,
Tom Lendacky, Yuwei Chen
On 3/8/24 10:13, Laszlo Ersek wrote:
> On 3/5/24 12:38, Laszlo Ersek wrote:
>> Bugzillas:
>> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
>> - https://bugzilla.tianocore.org/show_bug.cgi?id=991
>> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643
>>
>> CI:
>> - https://github.com/tianocore/edk2/pull/5442
>>
>> Branch:
>> - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-990-991-v2
>>
>> This patch series puts the recent BaseTools feature to use in which
>> AutoGen generates the ProcessLibraryConstructorList() declaration in
>> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
>> least 1.30. The BaseTools feature is present in both edk2 [1] and
>> edk2-basetools [2], and has been documented in the Build spec [3] and
>> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
>> release [5] [6] with the new feature.
>>
>> [1] edk2 commit bac9c74080cf
>> [2] edk2-basetools commit 5b7161de22ee
>> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
>> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
>> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
>> [6] https://pypi.org/project/edk2-basetools/0.1.51/
>>
>> The edk2-basetools part is adopted in the first patch (for
>> "pip-requirements.txt").
>>
>> The rest of the patches clean up -- superfluous, or even incorrect --
>> ProcessLibraryConstructorList() declarations (and, in some cases,
>> incorrect calls), together with raising the INF_VERSIONs in the related
>> SEC module INF files to 1.30.
>>
>> Comparing this version to v1 is not useful, as the compatibility
>> approach is different, and so this version is structured differently.
>> Please review any patches for your subsystem from scratch (they are not
>> difficult or large).
>>
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
>> Cc: Bob Feng <bob.c.feng@intel.com>
>> Cc: Catharine West <catharine.west@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
>> Cc: Erdem Aktas <erdemaktas@google.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Gua Guo <gua.guo@intel.com>
>> Cc: Guo Dong <guo.dong@intel.com>
>> Cc: James Lu <james.lu@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Joey Vagedes <joey.vagedes@gmail.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Michael Roth <michael.roth@amd.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Sean Rhodes <sean@starlabs.systems>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
>> Cc: Ted Kuo <ted.kuo@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Cc: Yuwei Chen <yuwei.chen@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (10):
>> pip-requirements.txt: require edk2-basetools version 0.1.51
>> OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList()
>> decl
>> OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList()
>> decl
>> OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl
>> ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>> ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>> EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>> IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl
>> UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>> UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl
>>
>> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 ----------
>> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +-
>> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +-
>> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +-
>> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +-
>> ArmPlatformPkg/PrePi/PrePi.h | 6 ------
>> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +-
>> ArmVirtPkg/PrePi/PrePi.c | 6 ------
>> EmulatorPkg/Sec/Sec.h | 9 ---------
>> EmulatorPkg/Sec/Sec.inf | 2 +-
>> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +-
>> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +-
>> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 ------------
>> OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +--
>> OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +-
>> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 -
>> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 ------------
>> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +-
>> OvmfPkg/Sec/SecMain.c | 3 +--
>> OvmfPkg/Sec/SecMain.inf | 2 +-
>> UefiCpuPkg/SecCore/SecCore.inf | 2 +-
>> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +-
>> UefiCpuPkg/SecCore/SecMain.h | 12 ------------
>> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +-
>> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 ----------
>> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +-
>> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +-
>> pip-requirements.txt | 4 ++--
>> 28 files changed, 20 insertions(+), 100 deletions(-)
>>
>>
>> base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0
>
> Series merged as commit range e60529df58e4..1c0db2315109, via
> <https://github.com/tianocore/edk2/pull/5450>.
Forgot to say: many thanks for the quick reviews!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116498): https://edk2.groups.io/g/devel/message/116498
Mute This Topic: https://groups.io/mt/104742520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 27+ messages in thread